From nobody Wed Dec 21 18:49:40 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NcjD46BcGz1Gl2X; Wed, 21 Dec 2022 18:49:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NcjD45l4Nz45nG; Wed, 21 Dec 2022 18:49:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671648580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0PBh1M+Xc4ioLWs11kwgTl/6TprmH+Jbx5BmWIB9V3s=; b=VL1NylAVRBTcAdj78QbAkTacGdKnzqsU/WmSMenliqawO95YRrZZKavPwnsqIR/obITWIy ADeZbS/UKv2oAQnjLMOYhDNP8OJNfjjJV+vpHROlZpi5QBm2eo3jxEi8a1Tp/V+cNGZY7R ySVPpcRYRY+x0hxwOlPCP2z7QGu7tHFvA34ZM+TKdAjk1OfG4Kat7aSsfzdn8fmEHMpAyt F52fv9UV3LBGoE8xi7BNFev1toGvbi5hCmIzvPneS1oJUItjkNrKctCBjxBGaHl7Yk9TQ5 FUW0vOlrPfjKOaNAvE7mkM5StU2fFty4Hm6STQhXw8dK1wUH6Bf8d7oB7OPjuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671648580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0PBh1M+Xc4ioLWs11kwgTl/6TprmH+Jbx5BmWIB9V3s=; b=kPBVKLT2VMihpYfaMGKiU1PcqNXDZz6w9xKXwU/KAfaq5jeHrC0hwn9lz2jurFp1EqUjEh KCCROXefihwTLKspqOQ8iNmBYO2VKIbrWEB+a3PkuJunN7pHupGRcup89lOtn4hz49TGi4 LaGXwJFHFfFs+PhRGXk2t7PQHQT+Kax3twcCYAsTx8R1Osg9sYMr8YKCwnCXr5UdZPIz+R LUE68fmnefr4sG/HER8E1Aa++o8FImiH7xFbjRk7u+poriEgmE7lpIbJma/PPdWU26vKQe rUOiCS0RbGhLu3AYQJ3vlJYBhiI5A8TQTN5yigaXAHZO1jrGK1p0FqhTFdf2ng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1671648580; a=rsa-sha256; cv=none; b=Dx5vhZCIQPgV5dfBgkD1Y/jTmEBHIKDrgCLF1yJRnkQHOxrnys/MGRD0urqmyIkTEuP8iv 6VPMkVLFfKB5zlfHGH+9K4yMBNxvtNRoKnDeCj9edVikMupZE4QUWerHuntCpjQU7gjRTa VhzJ4n/GZVRlVzBsGrrSvBXXsTIvCs7IaNuudl+sXuH+foRdMjNu/PUnvc6mfuCAgyerZ4 VWUfy7ThqZNKLemQne5GCM2EX/Uy4mBrAdc1PEKrgyEOn6zzM63VYaw0TlBySo8HkZJCv3 CrhsgOFz3p2DaFWP4t4AS5LcBq33wQScMF5z5MPwc8m0hdVhPgR2rDZ61zQbQQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NcjD44s7HzQP0; Wed, 21 Dec 2022 18:49:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2BLIne1O084533; Wed, 21 Dec 2022 18:49:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2BLIneiI084532; Wed, 21 Dec 2022 18:49:40 GMT (envelope-from git) Date: Wed, 21 Dec 2022 18:49:40 GMT Message-Id: <202212211849.2BLIneiI084532@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 95d146592f5e - main - iee80211_hwmp: Don't dereference NULL ni in debug printf. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 95d146592f5ee3fa998496713f28475e65996ff9 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=95d146592f5ee3fa998496713f28475e65996ff9 commit 95d146592f5ee3fa998496713f28475e65996ff9 Author: John Baldwin AuthorDate: 2022-12-21 18:45:45 +0000 Commit: John Baldwin CommitDate: 2022-12-21 18:45:45 +0000 iee80211_hwmp: Don't dereference NULL ni in debug printf. In this call to IEEE80211_NOTE, ni is always NULL due to the assignment a few lines earlier at the start of the function. If debug traces are enabled, then this will pass an invalid pointer as the 'mac' pointer to ieee80211_note_mac. Use IEEE80211_DPRINTF which doesn't take a 'ni' argument instead. Reported by: GCC -Wstringop-overread Reviewed by: bz, emaste Differential Revision: https://reviews.freebsd.org/D37626 --- sys/net80211/ieee80211_hwmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/net80211/ieee80211_hwmp.c b/sys/net80211/ieee80211_hwmp.c index 77ba218ccd50..ad3de543664f 100644 --- a/sys/net80211/ieee80211_hwmp.c +++ b/sys/net80211/ieee80211_hwmp.c @@ -1928,8 +1928,8 @@ hwmp_discover(struct ieee80211vap *vap, if (rt == NULL) { rt = ieee80211_mesh_rt_add(vap, dest); if (rt == NULL) { - IEEE80211_NOTE(vap, IEEE80211_MSG_HWMP, - ni, "unable to add discovery path to %6D", + IEEE80211_DPRINTF(vap, IEEE80211_MSG_HWMP, + "unable to add discovery path to %6D", dest, ":"); vap->iv_stats.is_mesh_rtaddfailed++; goto done;