From nobody Fri Dec 09 14:11:06 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NTCcB3YCGz4jNl6; Fri, 9 Dec 2022 14:11:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NTCcB2rJmz46Ld; Fri, 9 Dec 2022 14:11:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670595066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8Fj8T0AgGqAcb5z+IXrH6Hr6VpuQ4/c3C4H0KaZovfU=; b=O1GbJU7iHGZ12ZRhOtCkUZ22X3lR1wfS7NCtdr8MqRUuuPirwU/7UBX8LYKMy64RT5gwEJ u2RAjrN5lfUqSpmwuCdOzsvk+XnZmoXywC8xgmnrBtZcuXE0Kpd7FqkMa6JtSLT2PviHZd nlFD9+UgmBj3tXugfQAIXaL2e7NCs7sJL67iPTza8Wb0vuuHmmTm22EM0hEozaObeO9SzM Y+SJag/R7/pSHsZPKDUud0KA3HC9wYMql3hJKN6COY15CEW7Vl7gpy5Dn1B54JnzLh1ZRy OTV8n5tYYGEiN0y4E6opcVKVp4xbBMakCjlzja6s6HGYUooYUw1hlzZBfuQTLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670595066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8Fj8T0AgGqAcb5z+IXrH6Hr6VpuQ4/c3C4H0KaZovfU=; b=aMYKW60at+6+nqPi6LKacEpYqI6o9fb8jFEw1uQkFeZQ0QVsMY/qybzGGAzjGPs9uw7d6+ WAlFi7HDPr/FnDiSVd4EH+MLauRwxvgKxxuBtyL6wd69lOQH1jcUyXy6OE8TGsbuHx2+u7 wrgQBCldAHaWMdfURfU0Fvg47vhy7yfxi4vwrTsMWQZ6E1ZXxlOU+VCNABrNfAG72MIizn PiF85yknCOKtllJfQ/1QjVeNSBqbXW3YJ2dZxNrpmIgDROb24lZ+t6CdNCniOTjLDNjsZS UjpgrVw4KwF7oPtxv9TAdsQi9mT00AXhBzX+2LygDYPRB7LxsnYPTZPH44gjRA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670595066; a=rsa-sha256; cv=none; b=JcJT7C8tqd6nZ85cnG+lpS665THCW3AuxCJ5YDgwaEEElpvWAD+Yt2YZ4a29hFRutBNyip ShG2BND2J0K2F8TlDPVxLRa1/I3VIXYZ2zbhcMvmkmD1BQgVQyneERPFAsM0Ao09vPZMYk ijdd0brTMpbpORhwxQDCsdYa6EPpmQmxKDpuuT1U0YYBuGlvfPJkGdE27abRngu1hIcT9Y kracxwWdk59Vieu66W7YdVtB/eFL+hBhcFHEFXtYSXoEg+PT789VLHBhHKa5vAfmyW0h2M kvvfg+imw3iyQShHNYgyGk7wm4GcSyVWxH4GqAm5wqsM8GfynNIkzI9AGm2eWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NTCcB1vYkzds4; Fri, 9 Dec 2022 14:11:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2B9EB6uM052861; Fri, 9 Dec 2022 14:11:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2B9EB629052860; Fri, 9 Dec 2022 14:11:06 GMT (envelope-from git) Date: Fri, 9 Dec 2022 14:11:06 GMT Message-Id: <202212091411.2B9EB629052860@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Cy Schubert Subject: git: 5319949668a5 - main - Revert "heimdal: Fix bus fault when zero-length request received" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5319949668a5cb4d182d7252ce26799506b3585d Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=5319949668a5cb4d182d7252ce26799506b3585d commit 5319949668a5cb4d182d7252ce26799506b3585d Author: Cy Schubert AuthorDate: 2022-12-08 16:08:50 +0000 Commit: Cy Schubert CommitDate: 2022-12-09 14:09:54 +0000 Revert "heimdal: Fix bus fault when zero-length request received" This is the wrong fix for PR/268062. MFC after: immediately This reverts commit 6742ff42ab3b6e65239f975314060b1393e22d62. --- crypto/heimdal/lib/krb5/read_message.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/crypto/heimdal/lib/krb5/read_message.c b/crypto/heimdal/lib/krb5/read_message.c index e994b0f09133..4e9bd012dd67 100644 --- a/crypto/heimdal/lib/krb5/read_message.c +++ b/crypto/heimdal/lib/krb5/read_message.c @@ -55,11 +55,6 @@ krb5_read_message (krb5_context context, return HEIM_ERR_EOF; } len = (buf[0] << 24) | (buf[1] << 16) | (buf[2] << 8) | buf[3]; - if (len == 0) { - krb5_clear_error_message(context); - return HEIM_ERR_EOF; - } - ret = krb5_data_alloc (data, len); if (ret) { krb5_clear_error_message(context);