From nobody Thu Dec 08 23:06:20 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NSqXH0xfZz4jjrn; Thu, 8 Dec 2022 23:06:23 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NSqXH004Cz3qhP; Thu, 8 Dec 2022 23:06:22 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTP id 3JttpRdsNyQ9e3PyApfHfI; Thu, 08 Dec 2022 23:06:22 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id 3Py8prA8eibmA3Py9pFNwl; Thu, 08 Dec 2022 23:06:22 +0000 X-Authority-Analysis: v=2.4 cv=YPCMdDKx c=1 sm=1 tr=0 ts=63926dee a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=sHyYjHe8cH0A:10 a=7ASnObcnAAAA:8 a=6I5d2MoRAAAA:8 a=NEAV23lmAAAA:8 a=rZKjHobUAAAA:20 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=QJvs-E_vABXWSPAO9rsA:9 a=CjuIK1q_8ugA:10 a=5L0X0vKsh3gA:10 a=pj5rz7AvTRnaHDIeLm0D:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id A11634FF; Thu, 8 Dec 2022 15:06:20 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 809E51B3; Thu, 8 Dec 2022 15:06:20 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Emmanuel Vadot cc: Alan Somers , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6c93a2d0bc37 - main - [skip ci] improvements to cap_sysctl.3 In-reply-to: <20221208232454.32fbd074896a1834cd7b2737@bidouilliste.com> References: <202212081946.2B8Jk1e8070942@gitrepo.freebsd.org> <20221208221501.4abec4c251863fe23a35ce78@bidouilliste.com> <20221208225915.72b1b339de1a7962e3e38c9e@bidouilliste.com> <20221208232454.32fbd074896a1834cd7b2737@bidouilliste.com> Comments: In-reply-to Emmanuel Vadot message dated "Thu, 08 Dec 2022 23:24:54 +0100." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 08 Dec 2022 15:06:20 -0800 Message-Id: <20221208230620.809E51B3@slippy.cwsent.com> X-CMAE-Envelope: MS4xfFgon/aXVkiJwpQlrZgu+5ufNi80LaTqL81kIG0XB9O5u8cjevq9f3HBEInfLg2rRlDHozEK2a5vsPpJvV966sYljMfrCXBVXQgOq/34iANMTK1M/PNm zMojBwYl0CWWpRuG0kwX7YilHfl17EwUozI698qPkTplMCIAzjcHDpZCdLixNVzxxkUE4noXzw2Td7pAvaWWS7gp+bQbqbdOGO+ZsxBY1HnB/fiKx1ybvdFC dnXuRxot293e8XWYafWxRIS0hjCSlK1+HujNwB1avEoPCFYeoZj/+wYesoCjKBY5VHcryw2uwo6rIW0qJchSdpbr3JWGa7SjnbPm3b+ck4UOug3hJDNlMxCz bBJzet5d/VJ1VoA5a+G2fke3tON7cQ== X-Rspamd-Queue-Id: 4NSqXH004Cz3qhP X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N In message <20221208232454.32fbd074896a1834cd7b2737@bidouilliste.com>, Emmanuel Vadot writes: > On Thu, 8 Dec 2022 15:15:30 -0700 > Alan Somers wrote: > > > On Thu, Dec 8, 2022 at 2:59 PM Emmanuel Vadot wrote > : > > > > > > On Thu, 8 Dec 2022 14:28:34 -0700 > > > Alan Somers wrote: > > > > > > > On Thu, Dec 8, 2022 at 2:15 PM Emmanuel Vadot w > rote: > > > > > > > > > > > > > > > Hi Alan, > > > > > > > > > > On Thu, 8 Dec 2022 19:46:01 GMT > > > > > Alan Somers wrote: > > > > > > > > > > > The branch main has been updated by asomers: > > > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=6c93a2d0bc37f0c912e402 > f3f94c3c01350dca26 > > > > > > > > > > > > commit 6c93a2d0bc37f0c912e402f3f94c3c01350dca26 > > > > > > Author: Alan Somers > > > > > > AuthorDate: 2022-12-01 16:49:57 +0000 > > > > > > Commit: Alan Somers > > > > > > CommitDate: 2022-12-08 19:45:47 +0000 > > > > > > > > > > > > [skip ci] improvements to cap_sysctl.3 > > > > > > > > > > You keep doing commit with this [skip ci] prefix, what is it for ? > > > > > AFAIK the official FreeBSD CI doesn't support this and I find that > > > > > really ugly to have this in the commit subject. > > > > > Mind sharing more on why you add this ? > > > > > > > > > > Cheers, > > > > > > > > > > -- > > > > > Emmanuel Vadot > > > > > > > > It tells CI systems not to run any tests on this commit. Both Cirrus > > > > and Jenkins understand it, among others. For example, if you browse > > > > to https://github.com/freebsd/freebsd-src/commits/main and hover over > > > > the green checkmark next to this commit, you'll see a bunch of > > > > "skipped" symbols. So I use it just to save resources. I think I > > > > could put it on a separate line, though. > > > > -Alan > > > > > > Mhm ok, I find that very ugly, couldn't we add some git push options > > > instead ? We use gitlab at current work and we use a lot of those push > > > options, this avoid having ugly commit subject. > > > > > > How? What is a "git push option"? > > https://docs.gitlab.com/ee/user/project/push_options.html > > This is the same kind of stuff we use when you push some commit > authored by someone without a @freebsd.org email address. Seems Github and Gitlab accomplish the same thing, differently. https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow- runs But our CI happens in jenkins. Wouldn't push options and "magic" strings in commit logs mean nothing in our case, because we use cgit and jenkins? I don't understand how skipping Github workflows does anything to affect our jenkins workflow. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0