From nobody Wed Dec 07 21:05:35 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NS8vP419Kz4jqkh; Wed, 7 Dec 2022 21:05:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NS8vP3Mwqz3pWn; Wed, 7 Dec 2022 21:05:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670447137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AmqPDd9fwp2FUGSwLxF8XuOe7P9Fd6LLZ/8kcHfYhVg=; b=P3S4QaSWiRnpEAF/ZaquSEFpwjywt7wAXh2PwZlOtacezIobXUQIU0on/8EM6ZJuVfrraQ ryOl46xGgMUwMnOxGuUZ63C2Ql0a1diT6F7sEpq385JURdxXoVujP2liXOLfF0CxBmHHpU /0btXeRwVRGuo9QKQteZfFcuherAnP4T4kfCxbRq83QRdu1kb+hOuhrNE8qwmwYwIzfjkd v9iY5KEBJhc84bfAdYrKWwGI7pbJRNFbcZ2FSAtKqMDBTmOc1ThOsLgCFx9mLM0dYNxUNr EzdcxdtQRTzY//89l6HUQbpVuTN0aFCvTNMKBu+r10FO/i4sTZaYrr/o/rQpLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670447137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AmqPDd9fwp2FUGSwLxF8XuOe7P9Fd6LLZ/8kcHfYhVg=; b=WPa7NzHI6p/KiQ/a5O5n51iCw/36Qwc19LeHBTpw31J8TpwZn19rko5VxAE05eMm/l7tPB LrPE6YlYSvYrKVEgI86gKtGBB4Fu3N/xE0xh+xiWVxfIyGyspJ8U3AJ7hq454PtQnuc+KK SMyvsNStCQ69LMlwk9B2S/8WeLxdasAElQT2hES+aNcstMWC/msdOkakSye8URqdtb2GeN Ja6Fc+0ElXoa11bgyZbh7LgfxrD7qJHjhZ1+1NkVE4hm0VX99DLlEEQKLXQ4RIAyo2HzU3 DSm8z9Vg5tYSGD4yXhZOADw5J26UOTa4t6EbCZ6/U5EGQIO5SuS3CWdGQhCvSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670447137; a=rsa-sha256; cv=none; b=hwUx5LAcSkZzI5iiYVKwVCKPyRe4joFDHWtrUC/yd5Ghfli92vQuIk2QaktV6OSxh8fD7L L1ofHwv2vWMVVv9Qke2PkvQg/VqbGuaeN4PVfb1q9bbiX/apVJz1Aj0nZNU7xrUGcpAEZW h/3pCHVDIX3x/XxnD2QrF4iiVb1TPfV6exTFm5qCDajNxCzQ3BOH2DqnDXo4sCLV0YAYe7 KXmq9MxuhrnKRYoMuLNyXjAjP720NBL9mqDwKfwijzur2C2cjhDsYJ/Twt7ymYABOx/9oi 2EYNlyPDP22rxaaYR7VL/wewuruYoSYSH9NasSzqhwRZqaDHX42cr8MK78jjZA== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NS8vN64Fxz10rH; Wed, 7 Dec 2022 21:05:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 7 Dec 2022 13:05:35 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: git: cdcd52d41e24 - main - irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 Content-Language: en-US To: Eric Joyner Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202205232354.24NNs69N032987@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 6/13/22 2:18 PM, Eric Joyner wrote: > On Fri, Jun 10, 2022 at 3:29 PM John Baldwin wrote: > >> On 5/23/22 4:54 PM, Eric Joyner wrote: >>> The branch main has been updated by erj: >>> >>> URL: >> https://cgit.FreeBSD.org/src/commit/?id=cdcd52d41e246ba1c0fcfad0769bd691487355ef >>> >>> commit cdcd52d41e246ba1c0fcfad0769bd691487355ef >>> Author: Bartosz Sobczak >>> AuthorDate: 2022-05-23 23:39:27 +0000 >>> Commit: Eric Joyner >>> CommitDate: 2022-05-23 23:52:49 +0000 >>> >>> irdma: Add RDMA driver for Intel(R) Ethernet Controller E810 >>> >>> This is an initial commit for RDMA FreeBSD driver for Intel(R) >> Ethernet >>> Controller E810, called irdma. Supporting both RoCEv2 and iWARP >>> protocols in per-PF manner, RoCEv2 being the default. >>> >>> Testing has been done using krping tool, perftest, ucmatose, rping, >>> ud_pingpong, rc_pingpong and others. >>> >>> Signed-off-by: Eric Joyner >>> >>> Reviewed by: #manpages (pauamma_gundo.com) [documentation] >>> MFC after: 1 week >>> Relnotes: yes >>> Sponsored by: Intel Corporation >>> Differential Revision: https://reviews.freebsd.org/D34690 >> >> I'm trying to get the tree building again with GCC and ld.bfd does not like >> libirdma.map at all complaining with an error: >> >> duplicate expression '*' in version information >> >> I looked at the version map, and it seems rather bogus to me and not like >> version maps used anywhere else. It seems to be exporting all symbols in >> two different versions? That would seem to defeat the point of having >> symbol versions? >> >> /* Export symbols should be added below according to >> Documentation/versioning.md document. */ >> IRDMA_1.0 { >> global: *; >> local: *; >> }; >> >> IRDMA_1.1 { >> global: *; >> } IRDMA_1.0; >> >> (I'm also not sure why lld accepts such a version map.) >> >> -- >> John Baldwin >> > > Hi, > > I don't know how to answer this; I'm going to forward this to the FreeBSD > RDMA guy and another one (the first guy might still be out on vacation) and > see if they can answer this. FYI, this is now the current breakage for the new GCC 12 job in FreeBSD's CI: https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc12_build/47/console The error is buried in the log there, but should be obtainable by doing 'pkg install amd64-gcc12' and 'make CROSS_TOOLCHAIN=amd64-gcc12 buildworld' on main. -- John Baldwin