From nobody Sun Aug 28 01:33:09 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MFbg94YfMz4ZQhL; Sun, 28 Aug 2022 01:33:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MFbg943hRz3Rl1; Sun, 28 Aug 2022 01:33:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661650389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9kye03eZMlrL5DCdUJoPHTqyaq4eufqUqQI2CfIRkpk=; b=p0Y023xoanKvuLjx9Hfm0WTIFgaRyVerEofk0+MJtAZXenqFC8xsQZBu3Ip1wwPRARbRrf WtRUSSCS+CTWiTVKGaD7M8cWHLhRRVAjQxemCoyo/DN+it+ipSsj25vbNndCqNabEOoIyT o+zwBECzMW27fiMvMLsd8bgPvStV/d4YrKWdGslp3TC1SeXCJbtQExh59fcdl/ccF5GGzu NxyO5XOUKUtRrBhBNE7ijfVVOeCmKfKW1oSqMsRMDvlIm8mjfcCc255WIMeDfb2kCX1M8G /eE1C3kPLonGCAap5ovNYcl9ZMR5TWmBtcLUbNoItPwQMpn9uuOQoMABccTegw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MFbg936SFzwC6; Sun, 28 Aug 2022 01:33:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 27S1X9dI072475; Sun, 28 Aug 2022 01:33:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 27S1X9Kp072474; Sun, 28 Aug 2022 01:33:09 GMT (envelope-from git) Date: Sun, 28 Aug 2022 01:33:09 GMT Message-Id: <202208280133.27S1X9Kp072474@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: b875d4f5ddcb - main - nfsd: Update console message for no session found List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b875d4f5ddcbe0ce06f22650dd471b7518546dd6 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661650389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9kye03eZMlrL5DCdUJoPHTqyaq4eufqUqQI2CfIRkpk=; b=u4VZTvmQJKv0hjsSBxtPJIwKd/wrSscOPynVvpRB34Gh8tJvLL/+iZq8dSY1zRGcobZool OrdlvFibLcOyC3QwZiwNOMkJTBJai/aEVQaIdcoUEqQvrapsaybKYgRH9mYUUICp5GMMBs ApGCM8Y56afWqmzhMa1606l4J4PV4s8s5tOf79yMCpzy/3n6Lzxg6c7r1Mk2SUs4VpWPYv H902PN/Nd/8uefeiKGyr4X8gO5LeYL2D2lOrE6SLCWjI9VQvk63l5rSLZ+EcFb2bpgFOV1 zurxARetGKS9iC2+Qn4XLEyhPILGWDLkcvBopBFEi/09RiPfA0lTAMvxgQI7SQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661650389; a=rsa-sha256; cv=none; b=kF0kcyGzHmlHQ5IUv0v0YAYNUnGEMAjV3YLudpo0Mg3Vwqm8usAZAC3yGH80SWObG60KyZ 1WC2uFWN5oqz6bsiBojfSxZxyJXerLy96lllcnk7XzhEahIbhuWHCDfyeogkory1XHfhYq +29OrMeVHw4AgojSw98hYSQ3nFEg1AzHQnv1BEevAQvYwrv1Qn9tWN4m62CTgRV5YUNwaQ 7/0WzA1sgALR9omxC1BtuAsPG7UVWEgNd0gPfjJx4V+YTMVm5+c9ginqO14rOk52mseTsN Dsu1rjrf7ZQdBXbPClw5SMFF04/97jxV287zJN38JS3NRhKB/i6xUO2/2wG9/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=b875d4f5ddcbe0ce06f22650dd471b7518546dd6 commit b875d4f5ddcbe0ce06f22650dd471b7518546dd6 Author: Rick Macklem AuthorDate: 2022-08-28 01:31:20 +0000 Commit: Rick Macklem CommitDate: 2022-08-28 01:31:20 +0000 nfsd: Update console message for no session found The NFSv4.1/4.2 server generates a console message that indicates that there is no session. I was until recently perplexed w.r.t. how this could occur. It turns out that the common cause is multiple NFS clients with the same /etc/hostid. The host uuid is used by the FreeBSD NFSv4.1/4.2 client as a unique identifier for the client. If multiple clients use the same host uuid, this indicates to the NFSv4.1/4.2 server that they are the same client and confusion occurs. This trivial patch modifies the console message to suggest that the client's /etc/hostid needs to be checked for uniqueness. Reviewed by: asomers MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D36377 --- sys/fs/nfsserver/nfs_nfsdstate.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sys/fs/nfsserver/nfs_nfsdstate.c b/sys/fs/nfsserver/nfs_nfsdstate.c index aac845e68af7..d5d7f9fbd363 100644 --- a/sys/fs/nfsserver/nfs_nfsdstate.c +++ b/sys/fs/nfsserver/nfs_nfsdstate.c @@ -6383,9 +6383,12 @@ nfsrv_cache_session(struct nfsrv_descript *nd, struct mbuf **m) } if (cp != NULL) printf("nfsrv_cache_session: no session " - "IPaddr=%s\n", cp); + "IPaddr=%s, check NFS clients for unique " + "/etc/hostid's\n", cp); else - printf("nfsrv_cache_session: no session\n"); + printf("nfsrv_cache_session: no session, " + "check NFS clients for unique " + "/etc/hostid's\n"); free(buf, M_TEMP); } m_freem(*m);