From nobody Fri Aug 26 21:27:41 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MDtGf3529z4ZyBF for ; Fri, 26 Aug 2022 21:27:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [IPv6:2607:f8b0:4864:20::a2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MDtGd4MGhz3sFK for ; Fri, 26 Aug 2022 21:27:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vk1-xa2b.google.com with SMTP id o198so1246789vko.4 for ; Fri, 26 Aug 2022 14:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=uf69XJHmBvPoaRbLBarn1eUbVwx02A2R/MNpFav1xmU=; b=RigrQ4dxAkw2DAn5P6Y3XE3DRgq5sGPRMfcwlMn6SRnJ3sUiKzDXbex6uo/iXHLj6a Z+IA1HgPGr7JBfbC1NZslr4kGusFTmD0+ngPShqgModxLCga8sygHEQHGpQE5J7ZjIxE ON041vGV3asrt+vHvX0qjy18J3uuZ6XDYZfGSDKNlrW1TuUoMdQuV3UkvwviNrPoOW/K IsgCI5OoDKsFrvR/LSgitfYUdsFDSCHxEatRHAHRYFOAmTZKWnNjMuhs1GATMoR5KHfz N3lZEbJQhtH684706lZY6+RbRZtohjHyAh+4nX3PQ50SvWBIbB3WkSh8IwdxB4vyNZyU az6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=uf69XJHmBvPoaRbLBarn1eUbVwx02A2R/MNpFav1xmU=; b=SZP+boMQEFfET0YXkEMKCeHSfhraHp0zEGjzyaPA+V6W2c5WmvxkPAGcB+oHoNmBeK UDeoszQpcQPrEr2J2H1zkJFKKHXROY6EKjF9gYYff4FlbE+gX2+LkxJVrI4tEUf0RWHn gNpl3Rg4kInNxjiZv2aWQ64aHjHkIYLPBSQrdcMvIXZIHuLacb6dRTrtBFQL0U8i43Ws eQmObEbiNRa0GTjuDaPVN9okLVjqqZrwUROCaj6jt8rYW8+TmmvO3cwoS3FDq9Bd+oRL 1dxSR11Xce7qPTYwuQxt6t9nyL0+acWxQ15uSYOnV/0SbkItpGnNy2VwkCmZwDbk/UuB ehlw== X-Gm-Message-State: ACgBeo3NQTdn7VopKghSwdGvMmJ8/QAfy2cv9ID6HZ1UhknvfYThi/nV TN0l2QdmJIa1lASon86FQvP97Z7O0W+ZC+KZ5p0Mmw== X-Google-Smtp-Source: AA6agR6I/ZN4R8pX5SxUkLbGu6uIaeTyQsK/dATfrhmAMSfSMULHS3sUXpQ629tPB0OI0dbQlXHgw0YUyQ5qlAijus0= X-Received: by 2002:a05:6122:178a:b0:380:c120:6760 with SMTP id o10-20020a056122178a00b00380c1206760mr609683vkf.7.1661549272725; Fri, 26 Aug 2022 14:27:52 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202208232031.27NKVT2H033895@gitrepo.freebsd.org> <9108301c-5035-440f-0db0-a98b7465e297@FreeBSD.org> In-Reply-To: <9108301c-5035-440f-0db0-a98b7465e297@FreeBSD.org> From: Warner Losh Date: Fri, 26 Aug 2022 15:27:41 -0600 Message-ID: Subject: Re: git: e66390736613 - main - Define _NPCM and the last PC_FREEn constant in terms of _NPCPV. To: John Baldwin Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000002d8c7d05e72b96f8" X-Rspamd-Queue-Id: 4MDtGd4MGhz3sFK X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=RigrQ4dx; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::a2b) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::a2b:from]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[bsdimp.com]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N --0000000000002d8c7d05e72b96f8 Content-Type: text/plain; charset="UTF-8" Hey John, On Fri, Aug 26, 2022 at 12:10 PM John Baldwin wrote: > On 8/23/22 1:31 PM, John Baldwin wrote: > > The branch main has been updated by jhb: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=e66390736613a452238531f64bb9f674ebd4c3a6 > > > > commit e66390736613a452238531f64bb9f674ebd4c3a6 > > Author: John Baldwin > > AuthorDate: 2022-08-23 20:31:02 +0000 > > Commit: John Baldwin > > CommitDate: 2022-08-23 20:31:02 +0000 > > > > Define _NPCM and the last PC_FREEn constant in terms of _NPCPV. > > > > This applies one of the changes from > > 5567d6b4419b02a2099527228b1a51cc55a5b47d to other architectures > > besides arm64. > > > > Reviewed by: kib > > Sponsored by: DARPA > > Differential Revision: https://reviews.freebsd.org/D36263 > > So this actually broke emulators/qemu because now > requires . I have a patch to fix the port available at > https://reviews.freebsd.org/D36362. What I don't know is if there are > other ports broken by this that might change how to address this? I > would mostly hope that wouldn't be a header that userland > would need to use and that adding in a few places would > be the end of it. However, if there's wider-spread breakage then I > would hack on this to avoid the need for . > This will break qemu building on FreeBSD in the 7.1 release. It's almost out (last rc is out and that's expected to be the actual release). Any chance we can fix this in our sources? Warner --0000000000002d8c7d05e72b96f8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hey John,

On Fri, Aug 26, 2022 at 12:1= 0 PM John Baldwin <jhb@freebsd.org> wrote:
On = 8/23/22 1:31 PM, John Baldwin wrote:
> The branch main has been updated by jhb:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3De66390736613a452238531f64bb9f674ebd4c3a6<= /a>
>
> commit e66390736613a452238531f64bb9f674ebd4c3a6
> Author:=C2=A0 =C2=A0 =C2=A0John Baldwin <jhb@FreeBSD.org>
> AuthorDate: 2022-08-23 20:31:02 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0John Baldwin <jhb@FreeBSD.org>
> CommitDate: 2022-08-23 20:31:02 +0000
>
>=C2=A0 =C2=A0 =C2=A0 Define _NPCM and the last PC_FREEn constant in ter= ms of _NPCPV.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 This applies one of the changes from
>=C2=A0 =C2=A0 =C2=A0 5567d6b4419b02a2099527228b1a51cc55a5b47d to other = architectures
>=C2=A0 =C2=A0 =C2=A0 besides arm64.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 kib
>=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0DARPA
>=C2=A0 =C2=A0 =C2=A0 Differential Revision:=C2=A0 https://revi= ews.freebsd.org/D36263

So this actually broke emulators/qemu because <machine/pmap.h> now requires <sys/param.h>.=C2=A0 I have a patch to fix the port availabl= e at
https://reviews.freebsd.org/D36362.=C2=A0 What I don't kno= w is if there are
other ports broken by this that might change how to address this?=C2=A0 I would mostly hope that <machine/pmap.h> wouldn't be a header that= userland
would need to use and that adding <sys/param.h> in a few places would=
be the end of it.=C2=A0 However, if there's wider-spread breakage then = I
would hack on this to avoid the need for <sys/param.h>.

This will break qemu building on FreeBSD in the 7.1 = release. It's almost out (last
rc is out and that's expec= ted to be the actual release). Any chance we can fix
this in our = sources?

Warner=C2=A0
--0000000000002d8c7d05e72b96f8--