From nobody Fri Aug 26 18:43:55 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MDpdg2tjNz4ZgwQ for ; Fri, 26 Aug 2022 18:44:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MDpdg2SClz3dmP for ; Fri, 26 Aug 2022 18:44:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vs1-xe35.google.com with SMTP id k10so2466486vsr.4 for ; Fri, 26 Aug 2022 11:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=l7HYSN1YjYUqnvo79/yiYGHK8QEqMRQNwKf0LrzT1M8=; b=3+oM70ZvcVDdENzBQfWQL86y3Uzi+D4TQNsmchjGyuESjumDNMUday9Ui6L4CFS8iS zbdLNEG7u/7Q80kwUc3V/rzlDo4er2arVaYzs6IeuP07DF1m2Un8nBgk2yXfUmSyWPq5 YpXPQXO9Hm15nDQRV631HJ6UqipHN9quuJVBZALSOE3E+8f+V0HDxdG7GvLa4Awy3oTQ j1I7wgTwPoF0bfFl/GMHyJv+XZ24OsDlt4ujRSuUtncJHBPWnBkPAcz7LDVjmn3KSXht UZCAD82X+LLft548JAdTIqeSyyjTzUBiMDBnvV9BaEZ9pWVobtMvXGaqvxXNhLFS3pFp HGbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=l7HYSN1YjYUqnvo79/yiYGHK8QEqMRQNwKf0LrzT1M8=; b=QekQ+AjBGHpbJsYpelNhlApbKaX8GBKhHYyRKM3xtt4c+gEbL5Gv5e0xjyMSxgmTHf aif+SQpSAikBcEUuId6QP9UBEtA/cDVU9qBdBo6lAKBK0f/pCaPGadi8vIyLt2aLer2v ELMyFhZ/EcLdHRPejC6q9Ot7Dg8Wzp0hGdO03NwzRvDn/EPrjKi+pQPq+ght9avj6nRC HeiIfNX/7yRlOdZXneji69miMw4h04iwCRAhlA2YcR6mLjXoNmqsEAmz5M0VJDWy/Su/ asOEuoxNdL738lUMn9d7X18gZ3eZ2+wR5A8FBzvHqac7jfhyKovoTQrwGx9v26+m5/mf ViCw== X-Gm-Message-State: ACgBeo2AvfeqnTcb1OXHAP6JuwhVtHiWdjD9Vzip+GmEvdejXedrJ4bQ b/SSbMTY6sh+ZH4iQwVbuZiWc56arAb0AALJkwlue1QUlTotXQ== X-Google-Smtp-Source: AA6agR4mo2M+FhwetwQ/aKytV0gGlVyfd5QAJNluN7DFmRGe7noFuBWA//Ajk2k9Jy1d2UcvoVok6Eg+s8UbrVrdkbg= X-Received: by 2002:a05:6102:2146:b0:38f:f3d6:51da with SMTP id h6-20020a056102214600b0038ff3d651damr393539vsg.38.1661539446223; Fri, 26 Aug 2022 11:44:06 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202208261741.27QHfVse092900@gitrepo.freebsd.org> <563EB46C-FEA6-4E1D-B9D5-9EFCF3427FCF@freebsd.org> In-Reply-To: <563EB46C-FEA6-4E1D-B9D5-9EFCF3427FCF@freebsd.org> From: Warner Losh Date: Fri, 26 Aug 2022 12:43:55 -0600 Message-ID: Subject: Re: git: 74704a26bc2c - main - efi: Create a define for memory descriptor version To: Jessica Clarke Cc: Warner Losh , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="000000000000790ac905e7294cf0" X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4MDpdg2SClz3dmP X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --000000000000790ac905e7294cf0 Content-Type: text/plain; charset="UTF-8" On Fri, Aug 26, 2022 at 11:45 AM Jessica Clarke wrote: > On 26 Aug 2022, at 18:41, Warner Losh wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=74704a26bc2cfc72de6821d29a1f53b9d8c65f55 > > > > commit 74704a26bc2cfc72de6821d29a1f53b9d8c65f55 > > Author: Warner Losh > > AuthorDate: 2022-08-26 17:39:37 +0000 > > Commit: Warner Losh > > CommitDate: 2022-08-26 17:40:42 +0000 > > > > efi: Create a define for memory descriptor version > > > > For true EFI platforms, the EFI BIOS will return version 1 (since no > > other version is defined as of this commit). However, for environments > > that wish to create an EFI memory mapping table that aren't actually > > EFI, we need to know this. Add EFI_MEMORY_DESCRIPTOR_VERSION for this > > constant. > > Should such environments not be hard-coding version 1? Otherwise you > risk starting to silently create version 2 structures in the future if > this is bumped, but initialised as if they were version 1, which could > mean leaving some new fields uninitialised. > Hmmm, currently we don't check the version.... But we likely should add an assert to say that this version is 1, because who knows what version 2 will bring... But yes, it's a good idea to be explicit about that. Warner --000000000000790ac905e7294cf0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Aug 26, 2022 at 11:45 AM Jess= ica Clarke <jrtc27@freebsd.org= > wrote:
On 2= 6 Aug 2022, at 18:41, Warner Losh <imp@FreeBSD.org> wrote:
>
> The branch main has been updated by imp:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3D74704a26bc2cfc72de6821d29a1f53b9d8c65f55<= /a>
>
> commit 74704a26bc2cfc72de6821d29a1f53b9d8c65f55
> Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2022-08-26 17:39:37 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2022-08-26 17:40:42 +0000
>
>=C2=A0 =C2=A0 efi: Create a define for memory descriptor version
>
>=C2=A0 =C2=A0 For true EFI platforms, the EFI BIOS will return version = 1 (since no
>=C2=A0 =C2=A0 other version is defined as of this commit). However, for= environments
>=C2=A0 =C2=A0 that wish to create an EFI memory mapping table that aren= 't actually
>=C2=A0 =C2=A0 EFI, we need to know this. Add EFI_MEMORY_DESCRIPTOR_VERS= ION for this
>=C2=A0 =C2=A0 constant.

Should such environments not be hard-coding version 1? Otherwise you
risk starting to silently create version 2 structures in the future if
this is bumped, but initialised as if they were version 1, which could
mean leaving some new fields uninitialised.

=
Hmmm, currently we don't check the version.... But we likely shoul= d
add an assert to say that this version is 1, because who knows = what version
2 will bring... But yes, it's a good idea to be = explicit about that.

Warner
--000000000000790ac905e7294cf0--