From nobody Sun Aug 21 09:25:43 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M9VTn2dHmz4ZKNM; Sun, 21 Aug 2022 09:25:49 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M9VTn1tWDz3lgt; Sun, 21 Aug 2022 09:25:49 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from smtpclient.apple (ip1f100e7e.dynamic.kabel-deutschland.de [31.16.14.126]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 331C97220BFAF; Sun, 21 Aug 2022 11:25:44 +0200 (CEST) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 8338690a0a43 - main - ip_reass: provide sysctl MIB returning IP fragment TTL From: Michael Tuexen In-Reply-To: Date: Sun, 21 Aug 2022 11:25:43 +0200 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <9EFEAD3E-F940-43C3-9465-FA26DCBD1888@macmic.franken.de> References: <202208202041.27KKfe9e061428@gitrepo.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4M9VTn1tWDz3lgt X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N > On 21. Aug 2022, at 04:18, Gleb Smirnoff wrote: >=20 > On Sun, Aug 21, 2022 at 12:07:39AM +0200, Michael Tuexen wrote: > M> > commit 8338690a0a43c8b11a382e2160f8eedb9aeecf91 > M> > Author: Gleb Smirnoff > M> > AuthorDate: 2022-08-20 20:33:39 +0000 > M> > Commit: Gleb Smirnoff > M> > CommitDate: 2022-08-20 20:39:12 +0000 > M> >=20 > M> > ip_reass: provide sysctl MIB returning IP fragment TTL > M> >=20 > M> > For now it is read-only, but eventually the cycle that goes = over > M> > all fragments should be refactored and this MIB should also = become > M> > read/write. > M> >=20 > M> > This MIB will allow SNMP daemons to implement MIB-II = ipReasmTimeout MIB > M> > straightfoward. Right now net-snmp compilation is broken by = 1922eb3e9c2. > M> > The base system bsnmpd is not broken just because it ignored = PR_SLOWTIMO, > M> > and thus always returned incorrectly doubled value for = ipReasmTimeout. > M> > --- > M> > sys/netinet/ip_reass.c | 4 ++++ > M> > 1 file changed, 4 insertions(+) > M> >=20 > M> > diff --git a/sys/netinet/ip_reass.c b/sys/netinet/ip_reass.c > M> > index 0420091e0a2a..e581e2e622c7 100644 > M> > --- a/sys/netinet/ip_reass.c > M> > +++ b/sys/netinet/ip_reass.c > M> > @@ -167,6 +167,10 @@ SYSCTL_PROC(_net_inet_ip, OID_AUTO, = maxfragbucketsize, > M> > sysctl_maxfragbucketsize, "I", > M> > "Maximum number of IPv4 fragment reassembly queue entries per = bucket"); > M> >=20 > M> > +static u_int ipfragttl =3D IPFRAGTTL / 2; > M> > +SYSCTL_UINT(_net_inet_ip, OID_AUTO, fragttl, CTLFLAG_RD, = &ipfragttl, > M> > + IPFRAGTTL / 2, "IP fragment life time on reassembly queue"); > M> What unit is used? seconds? milliseconds? You might want to state = that. > M> What us the semantic of IPFRAGTTL? What is the unit of that = constant? >=20 > I'll add '(seconds)' to the sysctl description. Perfect, thank you. >=20 > The semantic of IPFRAGTTL is ugly. It is number of timeouts, which are = 0.5 > second. A legacy of PR_SLOWTIMO. This will go away, so is not worth = documenting. Not sure what goes away. IPFRAGTTL or PR_SLOWTIMO. If IPFRAGTTL goes = away, everything is fine. If not, you might change the unit of IPFRAGTTL to seconds an = update the code correspondingly. Best regards Michael >=20 > --=20 > Gleb Smirnoff