From nobody Sat Aug 20 17:34:51 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M95NX2BsNz4ZpDD; Sat, 20 Aug 2022 17:34:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M95NX1TPyz3X8s; Sat, 20 Aug 2022 17:34:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661016892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mNFjv3jUH3RJs4hk+MNQwLARUwDFfOxrsdmU+n4ahy4=; b=vun9vzJtP4lgvP8+Do1ooymBEIG6vac6vv/wI1Bwwn4HqhS6hqsLUtGtlZdB+611WoXwON FEnDF2ZwvML4v1jOQ4/XMiaNBWvRQftn40q1ITTHYcVHG1emulSTdPZ3OFbUtj9gKfzzfC clFpJ2NuLCVG1AydyTWkIxgTEb5F+x8TRh4aexYqR6aj8B/9WS1qRHgnSizqTzrhIEZAMz WbVqFl7IHuDmzToP+MLYwGe0qoRbTx206aLljWTpTKLVUTtDLWcttjaJeGTFD7NdxmqRpu w714113fCluTw8QlgkjX7UdKohltIxqB/yoY2DM0TRrXmwNinQ7NgjxRWAQI1A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4M95NX0WMlzgWN; Sat, 20 Aug 2022 17:34:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 27KHYpI3093289; Sat, 20 Aug 2022 17:34:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 27KHYpZa093288; Sat, 20 Aug 2022 17:34:51 GMT (envelope-from git) Date: Sat, 20 Aug 2022 17:34:51 GMT Message-Id: <202208201734.27KHYpZa093288@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: da39a100dbfe - main - sleepq_check_ast_sc_locked(): update comment List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: da39a100dbfe60da6512a8b230386b1105c42445 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661016892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mNFjv3jUH3RJs4hk+MNQwLARUwDFfOxrsdmU+n4ahy4=; b=gCTpYhcSYl1pjxJt0WRTqJuUrzaBJOHaOux4piIwSpn6ioTi+Vgc8LcFhbEqyx1dOVDzhM 9T0CzjTpLMgV/M58MVTdphRAddkzNwnw7sGtxzVebab9emvUuU0A/Gp+3EfGwLZgZ+B/s8 7lYMwqugCJIWKSk/T8St0grhSEr9nK0U0JgooiP2c90iMcB+yuewCOSA/HfPD+Ak/5EJwn gtl7OWSWR20+Z05d5WVi9daOPSQTRJ3TLhTBYkxFrFP0S4fEvoMdy5Pz/pxgaAtbD9gTDl 9gZEtjMCP2ypYwRHdeFrCh08UUAxv4WrmuScEHBSqGeq+2fOSwUyuAM5IQ/SNQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661016892; a=rsa-sha256; cv=none; b=XiZ2KwOabSP0bX9FMDq+cD/C4fymu5FnY9r1m+SqK5K8sb34sgDzG7jz/6woeZGsmSW6yc ny6+4yHIEjusXDGA3vXS+5VhS7qNuSfArviF6rpTcFVCZwtyh4ECk4WsTM3eKLYeGveQVv E0XQ+7YaCqkpfiUyYaszJUJIKStJGYxSu2q5CiB/iKfkMHQpVhJVvpQVOgRafTj9QJfZiy OKcSikbzRAsXzF7vWLliWRaNHWNQkLuq5k1mPBhlM7vsTs3qw0J5w35Zu6NMEWkklu2q4u Nxs0Ro89y/+osJQkvNninVC6s6Z1SyHdKwqttARIH5qlSAeTdsg2X0L9yUM1Cg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=da39a100dbfe60da6512a8b230386b1105c42445 commit da39a100dbfe60da6512a8b230386b1105c42445 Author: Konstantin Belousov AuthorDate: 2022-08-12 00:19:36 +0000 Commit: Konstantin Belousov CommitDate: 2022-08-20 17:33:17 +0000 sleepq_check_ast_sc_locked(): update comment The relock order is important not only for a signal delivery, but also for the suspension requests. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 3 days Differential revision: https://reviews.freebsd.org/D36207 --- sys/kern/subr_sleepqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/subr_sleepqueue.c b/sys/kern/subr_sleepqueue.c index b5245879a05f..112dbbf93960 100644 --- a/sys/kern/subr_sleepqueue.c +++ b/sys/kern/subr_sleepqueue.c @@ -482,7 +482,7 @@ sleepq_check_ast_sc_locked(struct thread *td, struct sleepqueue_chain *sc) * Lock the per-process spinlock prior to dropping the * PROC_LOCK to avoid a signal delivery race. * PROC_LOCK, PROC_SLOCK, and thread_lock() are - * currently held in tdsendsignal(). + * currently held in tdsendsignal() and thread_single(). */ PROC_SLOCK(p); mtx_lock_spin(&sc->sc_lock);