From nobody Tue Aug 16 14:00:00 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M6XpY4BM0z4ZB2s; Tue, 16 Aug 2022 14:00:05 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M6XpX6TJyz3CXM; Tue, 16 Aug 2022 14:00:04 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTP id NsMioi3x0Sp39Nx6xoqAL9; Tue, 16 Aug 2022 14:00:03 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id Nx6uoqexGGRNlNx6voJb6a; Tue, 16 Aug 2022 14:00:03 +0000 X-Authority-Analysis: v=2.4 cv=Sfrky9du c=1 sm=1 tr=0 ts=62fba2e3 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=biHskzXt2R4A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=jexT3A_dk5yQqbzDV3oA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 42A9F12E; Tue, 16 Aug 2022 07:00:00 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 365C5150; Tue, 16 Aug 2022 07:00:00 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Alexey Dokuchaev cc: Dimitry Andric , Jessica Clarke , Konstantin Belousov , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning In-reply-to: References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> Comments: In-reply-to Alexey Dokuchaev message dated "Tue, 16 Aug 2022 11:47:59 -0000." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 16 Aug 2022 07:00:00 -0700 Message-Id: <20220816140000.365C5150@slippy.cwsent.com> X-CMAE-Envelope: MS4xfGhJEOiMwMYmQXOykUkX/V7ZfQh7ZuoD/JDUlnjja70RwvmzTaZtGIiOtOvlWGGqafx3FVITzmh+yYOjquiI5Adn/W9R8WRigYLkFsxvI2KA4PytJPmw x2NLAHo1eIhTvjTTOgdUxnamVyIXo4iBW0vS8Kgsf1/LWEuisqXE4a7Mj7QeOeWT7jU98o4GL2KJ3BQtdNmasUI6AlxgZAZm4tnAT5puC2ZFNoHiXZD5HAqV 4OUAZNUuhyZ8S/OLEwGFnq6Zln4yMeafeBfjpQfGeQhUcDsLsuFwfkAi1e4V5WTANv/iJJnlUlAbZbmw+4iEWEPUDzCh6jf9Gwc/CBLa5PxEaGAAzAQCGNvn UwlwQgTbiJtI8gYpehygMTc872S2/TTKuZJ7tic5N/V9R410jCeTAYAKs9JU5YIyrSftFcih X-Rspamd-Queue-Id: 4M6XpX6TJyz3CXM X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 3.97.99.33) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-1.80 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; MV_CASE(0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[3.97.99.33:from]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[7]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; REPLYTO_EQ_FROM(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; FREEMAIL_CC(0.00)[freebsd.org,gmail.com] X-ThisMailContainsUnwantedMimeParts: N In message , Alexey Dokuchaev writes: > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > > ... > > But I think it is better to have the definitions matching the > > declarations exactly. We should sweep through the whole tree and get > > rid of all K&R functions too. I believe Warner wanted to attempt that. > > I won't comment on the technical side of things, but seeing this plethora > of identical commits is not just annoying, but pessimizes blaming as well. > Why can't it all be done in more coarse pieces, if not one commit? Agreed. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0