From nobody Tue Aug 16 12:41:51 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M6W4J5l7Tz4Z1Xw; Tue, 16 Aug 2022 12:41:52 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M6W4J5Jzkz4K94; Tue, 16 Aug 2022 12:41:52 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660653712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m+T2m/Bvj7jwkC5Q3omsMcPFmROJh716Dy9BZo0KNfM=; b=Vl47v/98RlpUNvXVv75bjcBUM2csjERQgyg914/D/i278dOKIvUFZSQ4DU1TKbnJVhOSfq bPNkDxx7trnI0CyccAcNiZ7efc1o30obnjUyNhF0prmri+oFAOItTi6gL33703zCKRpPsn 3n9bu0/dbyfkd8pop2nydFgUwJ1U1yTH4fo9stO4xZIS4BAiyPjrGWxs+BqVRVIfACOO9D AxkJLkc3lSxLw4AF4v6RIMtD0+XJggIw3j7MblH0nmecEXSpShkEJb5ot+sgLDa6IuZFOK wFg+L9tyHpwlaJpmg2CbWPn3yZZduQTbuhTgX11d9iYxJjeM+kb7w064hcvpVw== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4M6W4J3jMHzxjN; Tue, 16 Aug 2022 12:41:52 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [192.168.0.11] (kilchoman.home.andric.com [192.168.0.11]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id E014446A81; Tue, 16 Aug 2022 14:41:50 +0200 (CEST) Message-ID: <4ed11043-d368-3084-bb21-2b794e9da748@FreeBSD.org> Date: Tue, 16 Aug 2022 14:41:51 +0200 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning Content-Language: en-US To: Alexey Dokuchaev Cc: Jessica Clarke , Konstantin Belousov , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> From: Dimitry Andric In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660653712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m+T2m/Bvj7jwkC5Q3omsMcPFmROJh716Dy9BZo0KNfM=; b=LAzWhrCuNjGYvy8fKCPPQsUuBdvOkl08LPtz3qnbXCOQhe06zuN8HlQhs700K8+36mp6EB fqLztq9AaYpzn+CLN7QBXpkYVBlSJbRD1JgtsEQIE07UGphruGcOSPoUH4XVSSMms0At2o jtcwWVLuveSeyfq1tZvE2xEH+OAS2RV8s3Ziwf3LiSn5iAFZR78Y3+jX1E64lfMQnkkQbQ XRdoo0JyykU5RQwSW7hhGR1qxalgl1hKgHVgIPUM4BgtN3hBZkh9LzehyKKffTL0tGmuVI wa/CC5jSXoYl6JiQSAhfIFhU6my/0m8OrPod8BQh+mB+MoowhZ5wF7rJu+spXg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660653712; a=rsa-sha256; cv=none; b=AROknYrD/cYPjVj62M8kMEaK4xzVgOIxqiVW7PC7SIvPDWK4vUQRg4TWi8sXc5pokaoTXR cm3kvniyUlEsMwoRYW+d30+HYFcIEfxAg/952NoMCIsyuMw5ZN98MpplD09dAYwwx11BYi sNmjlxKActDdP2V3cKgcvNkqh9OIl1/tUyCqTWElp0G6wMobuPiubw1y3/qXvz8EvMhpq5 rG8pnSAOEN4lSUCyu2AEctSKPjzd53fMU8fsY7S+R98QxyE1mNEYB8wTga6xp/GFI2b+cK RC6kHuvW8Q6NJGnV28DMGXGWY3rq3PqHtQREhSFO7wgZEeiwfmSN62iJuhHnPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 2022-08-16 13:47, Alexey Dokuchaev wrote: > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: >> ... >> But I think it is better to have the definitions matching the >> declarations exactly. We should sweep through the whole tree and get >> rid of all K&R functions too. I believe Warner wanted to attempt that. > > I won't comment on the technical side of things, but seeing this plethora > of identical commits is not just annoying, but pessimizes blaming as well. I don't see any reason why this would "pessimize blaming"? What do you mean with that? > Why can't it all be done in more coarse pieces, if not one commit? Because then somebody else will probably complain "why everything in one commit, it should be fine-grained"? It has to be fixed or worked around either way. I'm now more inclined to put in a suppression for this warning, since apparently they are just seen as "annoying". It is probably easier to just kick the can down the road again... Btw, similar issues affect ports, where we can either globally suppress new warnings (temporarily or permanently) and hope that the future won't catch up, or gradually start fixing things. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265425#c13 for more details. -Dimitry