From nobody Mon Aug 15 18:49:21 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M63Gn3fNZz4YXgy; Mon, 15 Aug 2022 18:49:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M63Gn34fXz4B6G; Mon, 15 Aug 2022 18:49:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660589361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VR0ksFjoi1h0iPi+5kUIr68errwoZ7HqPeiAAnajTnw=; b=sMINJHtl/jIJLwI+uPvTqp3HptfJg8t6L6mo0F3c1GGN83wT1uOyXTeNC/KXezswbbbF9O s0FKFn9/yA4ki3EtemkVwHg5ViEKBYSdzZolS4GkDgJyZtwdaTpi/O5yetfc9moMWhqxMd PGK7cTooj8lRp+GVXDi3R16cVPh7QzFuotsALEjrISPyecXuWcgJyI9AURQr2vydmmIKC7 jVAjndcypL/IX4ZA1v3fY5A/sLm/dDcGkwlUnbhpcSKLTG5r4wu27JWEi696ypSGid/N0F eKOZrktq8eqrCYGvQR9j6kqUVIG3cO4rWS7oCPBNwhop+7XVYAoW+hH0s7mCxQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4M63Gn2BCSzgDt; Mon, 15 Aug 2022 18:49:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 27FInLCo027725; Mon, 15 Aug 2022 18:49:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 27FInL8e027724; Mon, 15 Aug 2022 18:49:21 GMT (envelope-from git) Date: Mon, 15 Aug 2022 18:49:21 GMT Message-Id: <202208151849.27FInL8e027724@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: b33bfe6e1574 - main - Fix unused variable warnings in tcp_hpts.c List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b33bfe6e157429ad764e9a883a5e3a194a6d1f9f Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660589361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VR0ksFjoi1h0iPi+5kUIr68errwoZ7HqPeiAAnajTnw=; b=ptewJZw0Ku5JHgOUzMt52QSomKAzwn6eigp9ETcfdn+hrL3PVGDTXgn65JoDZ0O7uy38Zy nx7CZmEt/ONgfMz4vSEGpB04conD7ZxlgTm5mFoY5PN0h6zhvqpcr13MCdOQ2qSwjadZvE uBtb5q/Xg4zmun9XT7UNxUwoMq9uvMP+908oQj64FvIgD8M0Fao/dlYx8ChWVn1HW7Aklh IdFhPU4/lmUd3aSVhewuyIbBKBsYgzW6jXCcIbg/IyO7bdVjDSMfKszAky61ApcKmAPnfB RYNtQ/1+slDIUgvczHJx0H9ruIuOo1sNU9BFYAxzMSe7Gh9OSbdyuNcVBIh2WA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660589361; a=rsa-sha256; cv=none; b=hHTsY4JE7BiWXoFqZUFAUDk4pYA3c004Ggt83pv33dxujdMMZBI8LIcgYGCyiclSFbbUrZ Ns8BMkNjmTwly6PhRdhuZOgIYhalcY8buPBWhbqMAoP13ij0iNgGVmZMIoCnM0njVdffcB hFFXX7YjLs9Vnl8m0PSy1Ahlkn2Gw67kV6xHFkC31cbRnz7WKhaigJVQJZZU5bIP+1gT2T q4uj+r0wj7ibmeFZMoZeTaLTkfMxGFJ2aaXqDPNw/oLarQ7qFBFsAo4i/P2pZgPuq6xkZT syFF2mCXZh7PfHMe9SNYRz+4sKjnaNswdCLvwQWzzuc4Dd3/BKS+u7dwuLuauw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=b33bfe6e157429ad764e9a883a5e3a194a6d1f9f commit b33bfe6e157429ad764e9a883a5e3a194a6d1f9f Author: Dimitry Andric AuthorDate: 2022-08-15 18:14:39 +0000 Commit: Dimitry Andric CommitDate: 2022-08-15 18:48:34 +0000 Fix unused variable warnings in tcp_hpts.c With clang 15, the following -Werror warning is produced: sys/netinet/tcp_hpts.c:1114:10: error: variable 'paced_cnt' set but not used [-Werror,-Wunused-but-set-variable] int32_t paced_cnt = 0; ^ sys/netinet/tcp_hpts.c:1112:11: error: variable 'total_slots_processed' set but not used [-Werror,-Wunused-but-set-variable] uint64_t total_slots_processed = 0; ^ The 'paced_cnt' variable was in tcp_hpts.c when it was first added, and the 'total_slots_processed' variable was added in d7955cc0ffdf9, but both appear to have been debugging aids that have never been used, so remove them. MFC after: 3 days --- sys/netinet/tcp_hpts.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/netinet/tcp_hpts.c b/sys/netinet/tcp_hpts.c index 4df5a236dcce..b8d09523113f 100644 --- a/sys/netinet/tcp_hpts.c +++ b/sys/netinet/tcp_hpts.c @@ -1109,9 +1109,7 @@ tcp_hptsi(struct tcp_hpts_entry *hpts, int from_callout) struct tcpcb *tp; struct inpcb *inp; struct timeval tv; - uint64_t total_slots_processed = 0; int32_t slots_to_run, i, error; - int32_t paced_cnt = 0; int32_t loop_cnt = 0; int32_t did_prefetch = 0; int32_t prefetch_ninp = 0; @@ -1258,8 +1256,6 @@ again: /* Record the new position */ orig_exit_slot = runningslot; } - total_slots_processed++; - paced_cnt++; INP_WLOCK(inp); if (inp->inp_hpts_cpu_set == 0) {