Re: git: 6a70a0c8bfa6 - main - Document implicit dependencies of the mlx5(4) & friends.

On 2022-08-11 at 19:33 EDT, Maxim Sobolev <sobomax@FreeBSD.org> wrote:

>The branch main has been updated by sobomax:
>
>URL: https://cgit.FreeBSD.org/src/commit/?id=6a70a0c8bfa6fe8a2739527e5c822aec985e83e9
>
>commit 6a70a0c8bfa6fe8a2739527e5c822aec985e83e9
>Author:     Maxim Sobolev <sobomax@FreeBSD.org>
>AuthorDate: 2022-08-11 23:28:27 +0000
>Commit:     Maxim Sobolev <sobomax@FreeBSD.org>
>CommitDate: 2022-08-11 23:33:09 +0000
>
>    Document implicit dependencies of the mlx5(4) & friends.
>
>    MFC after:      2 weeks
>---
> sys/amd64/conf/GENERIC | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/sys/amd64/conf/GENERIC b/sys/amd64/conf/GENERIC
>index 53c6043a0146..9178abba36cc 100644
>--- a/sys/amd64/conf/GENERIC
>+++ b/sys/amd64/conf/GENERIC
>@@ -260,7 +260,8 @@ device		le			# AMD Am7900 LANCE and 
>Am79C9xx PCnet
> device		ti			# Alteon Networks Tigon I/II gigabit Ethernet
>
> # Nvidia/Mellanox Connect-X 4 and later, Ethernet only
>-# mlx5ib requires ibcore infra and is not included by default
>+#  o requires COMPAT_LINUXKPI and xz(4)
>+#  o mlx5ib requires ibcore infra and is not included by default

Hi Maxim,

May I suggest editing the above line to "mlx5ib requires ibcore infra, 
thus it is not included here" (replacing "and" with "thus" being the 
important part).

The mlx5en(4) page, in SYNOPSIS, lists also option RATELIMIT, option 
KERN_TLS, and device firmware. Are these needed? I imagine that "device 
firmware" certainly is (thus should perhaps be listed in the comment 
above), but what about the options?

> device		mlx5			# Base driver
> device		mlxfw			# Firmware update
> device		mlx5en			# Ethernet driver

Thanks,
Matteo