From nobody Mon Apr 25 18:54:55 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 304A41A8FC62; Mon, 25 Apr 2022 18:54:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KnDhw0LR3z4WhN; Mon, 25 Apr 2022 18:54:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650912896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cKjo8QNqhAu9Hfj3q6Gt+9bLC6W0F3xItyKoRgiG5EM=; b=cKUIOF/L8aU5QZGInedTHIOztsIirodJPW7USYOtCn/ykF9SEdM8AQaOU4lCjSqYah8Ppu QFml9EVVRfWfLeAFnS289dEyUWAHHrFu2P0vtrcBa7wTnLyiWc6sZyLUs2IsgQvZBxR4MQ hWrHz8Cq4XWkB4OqZnYECYV+wSO60Avyhf84adBI2gqXJLCWOGTRqSX00nUPK/bKQAA9sk Zk9m2oyYwsZcKt/TmTZllkP8kOeXBFKs9X0gOKGMMrIDzJIwxXoyvUkE6Qn9E44aI4v01D zhHUtB5ZOLHxTDrNPsAr9lbgqbMeYe2muEQPkPZSIX/nXeHffhQ84uk+fVHxqw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D0F6C20584; Mon, 25 Apr 2022 18:54:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23PIstXK098206; Mon, 25 Apr 2022 18:54:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23PIstWw098205; Mon, 25 Apr 2022 18:54:55 GMT (envelope-from git) Date: Mon, 25 Apr 2022 18:54:55 GMT Message-Id: <202204251854.23PIstWw098205@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: ccaec73d0b49 - main - ada: Eliminate dead code List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ccaec73d0b490a95e97f1adb973de70f7421d52c Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650912896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cKjo8QNqhAu9Hfj3q6Gt+9bLC6W0F3xItyKoRgiG5EM=; b=pBr8zqIGwW3Arrx2uUCiejwYxELcVgNW8lhThrTiAuMvQtbgifBCHL9mG7nvmULz6kaw3m 2mrHPfMSmWvNqql4716xRVtXmpzxQ9U5++zz31UCeS22ThP4L1RkpDjwRwRiuH27h7xyRh lwGDYG3dJMXfaO3uE3+oBLTOPBrpItPYRNyymx4j7i6OktDrzKQAY1MdYo/bNt18aR6UAZ v8ANDRmkc7oMsY8MkoH8l51yUxTXE2uvtwYeGcKTsaBCfw6q0tU8TIDLS7KoxVaCRwpHJb lAfEva05xS14ztnPkfTUm72gtAXRw8IOIZfLHOIpAIa0tCYLdpvODCNHXWiKTQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650912896; a=rsa-sha256; cv=none; b=Y0yPQBGEOy7qetTl6ZILicbcAbrBThgG0GQtpVbvVd4zRROb7MK7LQL55YhAyS7RTUQKil bFpzBeaYW/t5vt3H26DCXWd5mLy/5QlOuN1YfqZZ9eIX1NQq8tUvxe8RlpAKR4KDzoyfNz ivxqTqytE1tdvz7N2taVOICGHB/z3AkVnptUwZiomJAXVQTyDdMVpHF6WrNdlTWVzZxEP0 eFx4z/p9zZtyGFCywnl/CcCgqfh/TQHl4E/8sb3kSEWAAJeY9Hfndt/eUH8RcD4lWCzDwb yZiMw1VsMSSXTDpDF6G5xuiBRWBjmDw2UOVuB5H30pWklLuhP/0TIQ1JvDJKJA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=ccaec73d0b490a95e97f1adb973de70f7421d52c commit ccaec73d0b490a95e97f1adb973de70f7421d52c Author: Warner Losh AuthorDate: 2022-04-25 18:54:37 +0000 Commit: Warner Losh CommitDate: 2022-04-25 18:55:04 +0000 ada: Eliminate dead code We never use the cgd that we get from the XPT_GDEV_TYPE call. Prior to 9a6844d55fe33 we used it to determine if READ AHEAD or WRITE CACHING was supported. However, all that information was moved into adasetflags so we no longer need to this since it's cached in the softc and updated with the IDENTIFY data changes automatically. Sponsored by: Netflix Reviewed by: mav Differential Revision: https://reviews.freebsd.org/D35039 --- sys/cam/ata/ata_da.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c index efca987b39b4..a83c5a50c5f3 100644 --- a/sys/cam/ata/ata_da.c +++ b/sys/cam/ata/ata_da.c @@ -1377,10 +1377,6 @@ adaasync(void *callback_arg, u_int32_t code, cam_periph_async(periph, code, path, arg); if (softc->state != ADA_STATE_NORMAL) break; - memset(&cgd, 0, sizeof(cgd)); - xpt_setup_ccb(&cgd.ccb_h, periph->path, CAM_PRIORITY_NORMAL); - cgd.ccb_h.func_code = XPT_GDEV_TYPE; - xpt_action((union ccb *)&cgd); if (ADA_RA >= 0 && softc->flags & ADA_FLAG_CAN_RAHEAD) softc->state = ADA_STATE_RAHEAD; else if (ADA_WC >= 0 && softc->flags & ADA_FLAG_CAN_WCACHE)