From nobody Thu Apr 21 17:25:42 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C3B0F198F7E9; Thu, 21 Apr 2022 17:25:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kkkvq1drrz4TTS; Thu, 21 Apr 2022 17:25:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650561945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PYqn9vfS5jyvdvoHw3MLHpBWCcmwEsN26aaNDdzqH1c=; b=EJ1ieGwITlI6GOC6mzll8xBDsAzPbpAQOjsb8XRvlxYMyzL0GjHraoR4AahaRRJWza5oH9 FtFSDuH2h2XLkDYRLfHzuxIfrN78a8n1VGWcdDqEvCFBv1Myu+fZtUw60nKykRU+iTuB2D 3/pAJkOnC9klJd+hnbp2ldsVOaYFGp/z50qnLvKAOp4VQChC5slnbmw4eweKZN8grwUUgN Hl9jEoMzw38yQB7j1ZVndHsAosX9Of/lI8vu61NP1XsipsBpBidtkoTdn6iGA0hbsT/w8J rFIiSPVXfpOYPS2Vt3hdLLy+D3wkxxJeOXMF0XSSBib2yn/vFgJ6LPJsbsxqlw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8EF325107; Thu, 21 Apr 2022 17:25:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23LHPgIx098832; Thu, 21 Apr 2022 17:25:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23LHPgUZ098831; Thu, 21 Apr 2022 17:25:42 GMT (envelope-from git) Date: Thu, 21 Apr 2022 17:25:42 GMT Message-Id: <202204211725.23LHPgUZ098831@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 5d691ab4f03d - main - mld6: Ensure that mld_domifattach() always succeeds List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5d691ab4f03d436d38f46777c3c117cf5a27f1bc Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650561945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PYqn9vfS5jyvdvoHw3MLHpBWCcmwEsN26aaNDdzqH1c=; b=D2VLQDD9cFAuEMCiX+Tvtwhxywmt/4HlXCKrp9wdj4fuRhxFH/7kkmrjIggBCJ982TXA/w OgzZh/sdVXqKWi7TgGZ/KEsL4loL/g4BiAftcGwyUyNIckRxb72qYTHyUj5NfUEx9ylB0R 8oM0iYjR5uvCTTztCGMaBCC2qSOFi4oItKfHKka1J6QshxtGNMMSdAm4PF1Z8dOivnhqLe v1xuEAUArQtUbz2ajf/LC+VfsGPya8Tjt/fCqJBQDTpLRa5al6o4GtXjYeruUj31OdzHkc +xQitpnqKcN4y2iDMtoBuRv3nbC2LvLdEXY3pztgRV6MiEC4p2Cy3vxyiVjiPA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650561945; a=rsa-sha256; cv=none; b=S4+7O9gZV1qFyUdRapTIWeNoeIUMdgOXOvqQFCOfN4IyZ+gLaCwmStKyw7bXwNFW0UsAr6 fm3yKWTK8bAXKsspQ9WbfEVRj+L4qmWAaGu9uIHXSyohnLjJUfCYDnAB9L9rgjlEW1ZgIU h44mIDaUphPSdXbkryhC2ugjiNRwj4sKvf+a3laBD7tMQz8bDPV0y/th2jZeME7RsP1GOJ Unpj36phyVYT27eiokjbsSb6Qy2r6acgapYiwcVVhBbOArCQxdZaMxT3oedvSoTOIeJ/lj xFQ2R+Bm+98qShSF+etXDLvVA/id6iSr3haCMzkmY6VfoHkPCBXKTcJJXHy2+A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=5d691ab4f03d436d38f46777c3c117cf5a27f1bc commit 5d691ab4f03d436d38f46777c3c117cf5a27f1bc Author: Mark Johnston AuthorDate: 2022-04-21 17:22:09 +0000 Commit: Mark Johnston CommitDate: 2022-04-21 17:23:59 +0000 mld6: Ensure that mld_domifattach() always succeeds mld_domifattach() does a memory allocation under the global MLD mutex and so can fail, but no error handling prevents a null pointer dereference in this case. The mutex is only needed when updating the global softc list; the allocation and static initialization of the softc does not require this mutex. So, reduce the scope of the mutex and use M_WAITOK for the allocation. PR: 261457 MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D34943 --- sys/netinet6/mld6.c | 48 ++++++++++-------------------------------------- 1 file changed, 10 insertions(+), 38 deletions(-) diff --git a/sys/netinet6/mld6.c b/sys/netinet6/mld6.c index dae0cea48cdc..1230599ea0d8 100644 --- a/sys/netinet6/mld6.c +++ b/sys/netinet6/mld6.c @@ -104,8 +104,6 @@ __FBSDID("$FreeBSD$"); #define KTR_MLD KTR_INET6 #endif -static struct mld_ifsoftc * - mli_alloc_locked(struct ifnet *); static void mli_delete_locked(const struct ifnet *); static void mld_dispatch_packet(struct mbuf *); static void mld_dispatch_queue(struct mbufq *, int); @@ -466,45 +464,17 @@ mld_is_addr_reported(const struct in6_addr *addr) } /* - * Attach MLD when PF_INET6 is attached to an interface. - * - * SMPng: Normally called with IF_AFDATA_LOCK held. + * Attach MLD when PF_INET6 is attached to an interface. Assumes that the + * current VNET is set by the caller. */ struct mld_ifsoftc * mld_domifattach(struct ifnet *ifp) { struct mld_ifsoftc *mli; - CTR3(KTR_MLD, "%s: called for ifp %p(%s)", - __func__, ifp, if_name(ifp)); - - MLD_LOCK(); - - mli = mli_alloc_locked(ifp); - if (!(ifp->if_flags & IFF_MULTICAST)) - mli->mli_flags |= MLIF_SILENT; - if (mld_use_allow) - mli->mli_flags |= MLIF_USEALLOW; - - MLD_UNLOCK(); - - return (mli); -} - -/* - * VIMAGE: assume curvnet set by caller. - */ -static struct mld_ifsoftc * -mli_alloc_locked(/*const*/ struct ifnet *ifp) -{ - struct mld_ifsoftc *mli; - - MLD_LOCK_ASSERT(); - - mli = malloc(sizeof(struct mld_ifsoftc), M_MLD, M_NOWAIT|M_ZERO); - if (mli == NULL) - goto out; + CTR3(KTR_MLD, "%s: called for ifp %p(%s)", __func__, ifp, if_name(ifp)); + mli = malloc(sizeof(struct mld_ifsoftc), M_MLD, M_WAITOK | M_ZERO); mli->mli_ifp = ifp; mli->mli_version = MLD_VERSION_2; mli->mli_flags = 0; @@ -513,13 +483,15 @@ mli_alloc_locked(/*const*/ struct ifnet *ifp) mli->mli_qri = MLD_QRI_INIT; mli->mli_uri = MLD_URI_INIT; mbufq_init(&mli->mli_gq, MLD_MAX_RESPONSE_PACKETS); + if ((ifp->if_flags & IFF_MULTICAST) == 0) + mli->mli_flags |= MLIF_SILENT; + if (mld_use_allow) + mli->mli_flags |= MLIF_USEALLOW; + MLD_LOCK(); LIST_INSERT_HEAD(&V_mli_head, mli, mli_link); + MLD_UNLOCK(); - CTR2(KTR_MLD, "allocate mld_ifsoftc for ifp %p(%s)", - ifp, if_name(ifp)); - -out: return (mli); }