From nobody Tue Apr 19 09:35:32 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3834B11FAEDC; Tue, 19 Apr 2022 09:35:35 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KjJZG5PGXz4ns4; Tue, 19 Apr 2022 09:35:34 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-lf1-x12f.google.com with SMTP id x17so28340023lfa.10; Tue, 19 Apr 2022 02:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Q1mL8r/ypk2XMK/yqCyI8XyGeV5fPoq6kAis4DfzG5k=; b=EOZVcwOmrAqA7s4oJqpSaZ/v8ymotS4lMDSCVcfbCQt4LB6ma1JJU5CHLl82PUyDzz yycnNMhhliqXorM1W4t4bny9+bZzJtM08NL3VShNzr36esuvvjOu7JmqjL6GHzQXlTTp NcJOaSXd/0G4BcRiHtYfFmCbT12VNcf0AOq7kfAhcQXVWMlaQZnZbmlnC2rvifKIjU/F 004rRRm3ldIMayfs3ieHbY2gzbCttr/6qGKmszhDFHOwtmsNzFyyKO+2TGOhWs80pPpf AX5Bw2qz6oAHwdm8M6qG2fqPmQJPxLgegd057z0Tzmjlu/g/V+k5NZnvHunJ1PhPSe36 VFaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Q1mL8r/ypk2XMK/yqCyI8XyGeV5fPoq6kAis4DfzG5k=; b=Gle+Y2hEjDUpX0KH8ODJomxtF8uptPwglEmoqT8wgq9Ryt8XPdkUcyUT04PXIWCZXa OOBiMgGDtzapkoTaxNX16fa0oWp6U0kddeLDchRy0C8dIf/JRrwKg0o8sGGTGZlYN9m7 2zJO1cMXd5TS91BJq3ucLZbWfr9ebmb9ozPD39l3E8qJ5gkoU1TJx6WcRIWfXTbJ6VEQ F7joQLbDTC7UhQP+s0rb0kuteZwg4cwLoENt6jhowmoS1J+rA4TveeDAo8OAf/xra2HD vmHFgZCSuuYHjbAbyj3HybAiYleQBwTVcTLcEq4bpbctBCtieydjTE6eMVN3+nRIHhcY OF9w== X-Gm-Message-State: AOAM5337kIhU65I2sYgKR0+YyOfJm5TgYQIw/Z92jgM/SypJH6haPCnC xUpZOi4mBbS+ikWuUJp8jl8IXFJbrnzRJ1uBnk0RtuzR X-Google-Smtp-Source: ABdhPJwDqNuTuroxX56UnjM4dqK7xJlywBdzWY5hkpq7M8huDpexAgKygeFmwmMobzNDQc1fUef4CxNOn65U8KMfitk= X-Received: by 2002:a05:6512:2102:b0:46b:b6f2:83ab with SMTP id q2-20020a056512210200b0046bb6f283abmr10481388lfr.202.1650360933271; Tue, 19 Apr 2022 02:35:33 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Received: by 2002:a05:6520:6145:b0:1bb:7433:4cdd with HTTP; Tue, 19 Apr 2022 02:35:32 -0700 (PDT) In-Reply-To: <20220419090201.6aa24c73@freyja> References: <202204182311.23INBqfC025671@gitrepo.freebsd.org> <20220419090201.6aa24c73@freyja> From: Mateusz Guzik Date: Tue, 19 Apr 2022 11:35:32 +0200 Message-ID: Subject: Re: git: 8b83d7e0ee54 - main - Make -Wunused-but-set-variable a fatal error for clang 13+ for kernel builds. To: FreeBSD User Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4KjJZG5PGXz4ns4 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N try main as of f2edc9155721af9e98eaf86928cf270aedd87f80 On 4/19/22, FreeBSD User wrote: > On Mon, 18 Apr 2022 23:11:52 GMT > John Baldwin wrote: > >> The branch main has been updated by jhb: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=8b83d7e0ee54416b0ee58bd85f9c0ae7fb3357a1 >> >> commit 8b83d7e0ee54416b0ee58bd85f9c0ae7fb3357a1 >> Author: John Baldwin >> AuthorDate: 2022-04-18 23:06:27 +0000 >> Commit: John Baldwin >> CommitDate: 2022-04-18 23:06:27 +0000 >> >> Make -Wunused-but-set-variable a fatal error for clang 13+ for kernel >> builds. >> Reviewed by: imp, emaste >> Differential Revision: https://reviews.freebsd.org/D34949 >> --- >> sys/conf/kern.mk | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/sys/conf/kern.mk b/sys/conf/kern.mk >> index f97be774ea10..b86149ab4618 100644 >> --- a/sys/conf/kern.mk >> +++ b/sys/conf/kern.mk >> @@ -42,9 +42,6 @@ CWARNEXTRA?= -Wno-error=tautological-compare >> -Wno-error=empty-body \ -Wno-error=pointer-sign >> CWARNEXTRA+= -Wno-error=shift-negative-value >> CWARNEXTRA+= -Wno-address-of-packed-member >> -.if ${COMPILER_VERSION} >= 130000 >> -CWARNFLAGS+= -Wno-error=unused-but-set-variable >> -.endif >> .endif # clang >> >> .if ${COMPILER_TYPE} == "gcc" >> > > Hello, > > this setting results in a kernel build failure: > > [...] > /usr/src/sys/dev/uart/uart_core.c:348:6: error: variable 'rxp' set but not > used > [-Werror,-Wunused-but-set-variable] int rxp; > [...] > > and, when having set > makeoptions WITH_EXTRA_TCP_STACKS=YES > in the kernel definition/configuration: > > [...] > --- rack_bbr_common.o --- > /usr/src/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/rack_bbr_common.c:399:16: > error: variable 'inp' set but not used [-Werror,-Wunused-but-set-variable] > struct inpcb *inp; > [...] > > > Kind regards, > > Oliver > > -- Mateusz Guzik