Re: git: a30eb84a5dc4 - main - powerpc mpc85xx: Remove unused variables.

From: John Baldwin <jhb_at_FreeBSD.org>
Date: Wed, 13 Apr 2022 23:17:53 UTC 
On 4/13/22 4:10 PM, John Baldwin wrote:
> The branch main has been updated by jhb:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=a30eb84a5dc4cb3c7e50f4f01473eeeab8b5bbd3
> 
> commit a30eb84a5dc4cb3c7e50f4f01473eeeab8b5bbd3
> Author:     John Baldwin <jhb@FreeBSD.org>
> AuthorDate: 2022-04-13 23:08:24 +0000
> Commit:     John Baldwin <jhb@FreeBSD.org>
> CommitDate: 2022-04-13 23:08:24 +0000
> 
>      powerpc mpc85xx: Remove unused variables.

At this point I'm able to build all of the kernels in universe/tinderbox with
-Wunused-but-set-variable as an error.  The remaining changes are:

8b0e1936fced Needs Review   D34840: uhid_snes: Mark new_status as unused.
3aa93f9e5006 Needs Review   D34854: qoriq_gpio_pin_setflags: Propagate error from qoriq_gpio_pin_configure.
d1e4b88f2d29 Needs Review   D34855: as3722_gpio_pin_setflags: Use computed mode instead of hardcoded PUSHPULL.
71c51a63c794 Needs Review   D34856: arm ti_mbox_attach: Mark sysconfig as unused.
bbc6a1169554 Accepted       D34887: vm_phys_init: Quiet unused but set warnings about npages.
72dbc6a7ddab Accepted       D34888: ata_kauai: Fix support for "shasta" controllers.
c9f7e2fa2328 Needs Review   D34891: cpu_idle_booke: Mark msr as unused.
1a10f716107c Needs Review   D34902: powerpc booke cpu_machine_check: Use a void cast instead of a dummy variable.
1405e028bd10 Needs Review   D34905: powerpc cpu_idle_60x: Move some variables fully under #ifdef AIM.

Most of these reviews have some open questions about if they are in fact
indications of larger bugs and/or if there are larger chunks of dead code
to remove, etc.

-- 
John Baldwin