From nobody Tue Apr 12 16:26:50 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6F0027ED4AC; Tue, 12 Apr 2022 16:26:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KdB222gtPz4bf7; Tue, 12 Apr 2022 16:26:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649780810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Hh+Jy1r43/WOJrd5RBl+j9xyeTLGqMrzniBwMkbSqs=; b=Rg4zsy/eqoetLZH4VrOEb1gY4qj/60CNK8SddhGlPNnNybqhqBOadA5YXoiHbyg2Ls1bIX HbahB/2fgi0rKVVg0TWp9EYhGsgXzL1ysy21ZjInLq9FXT49e7W9m+1cMrIpKvQlz7hwsK nqOenLMx+7X74ky5VeU0hwQhCSXXUlToeWXGkrT1o7VkvoOuo7Lw2sucF9GMeLmLmMhqIK tixYsaLhWGzBmRb7nYf/poN795YcsyMQB1g7th86inOGuUBzPqnx9I5QlvB84Bo96q5JjB m/PDJ3p5Bhf3ercSfwkSmoOwiGEpN4U0KTxslyUa+JxKOpwtiRrL/1sQAHf3AA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 37AA81A2FC; Tue, 12 Apr 2022 16:26:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23CGQo9m088141; Tue, 12 Apr 2022 16:26:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23CGQoIZ088140; Tue, 12 Apr 2022 16:26:50 GMT (envelope-from git) Date: Tue, 12 Apr 2022 16:26:50 GMT Message-Id: <202204121626.23CGQoIZ088140@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: David Bright Subject: git: 0966fb1b74b3 - main - Extend the length of dirpath to fix failure in kyua test List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dab X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0966fb1b74b38b31dc83e3cca48701ec796bf73a Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649780810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Hh+Jy1r43/WOJrd5RBl+j9xyeTLGqMrzniBwMkbSqs=; b=s5OGEmCldmGvqDi6HObLkj5vLCV4ezHwlKDEnnkiceG7W16RQfocgu6A4zpxnT1JZoCo6X CYdZBVsCGmSVQ9dfURBYik31LV8VVkgSRdINlbWD3PuP4MJQpcaR3hJsp/eOZFv1UQXLPi 0oKyH7A/6RlV/MQs78tciBE5uFP4K9Tm9ydLliDBlQtPeMhwvNzE/cMGZesAjwgOsiQZxV 0qIH+GuvXV94FOZFZZEFv+9F1uQi0QVqKFR/J2sAJ5Rig8eDVZao37JJp+nEV0P1EJBuWv FaJ4xJY5HKTTNZzxATIeNGOPAC653jC0dLU3l5cDW1B8/2jaxqEj+OeXohxGkg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649780810; a=rsa-sha256; cv=none; b=iFF6+SmHYZKCXmhqrkIgQZ4mAonZIpqBdDKmuZQ1AbTR1YQQ5WBohJNqRcCe6KzO5ktERZ I+3RDYvaieU0f7+CePqX8Y9WqeQZAZK7qBnjiQM3wB+9SBlqMmaENUk1uiR89GH159eRL0 9KBm97Y/s/DMLpm7BkXMD1VrZDgFKBQUWxn/Wy/hUKxRouXWZu9SqzY202baoE/qG3UH8m DmYEtdE9m/sk//6vbjgFRmZg6A0Vjyo9jhTqBGFXNFX93EopmvwoYeAXHPbaeMnb0wRjh1 axW72rO5ymO6gKPSBVkBp6m0iSmbhp8XVG4rAN74+pmjBgYOQ6VX58HtbkEk5A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dab: URL: https://cgit.FreeBSD.org/src/commit/?id=0966fb1b74b38b31dc83e3cca48701ec796bf73a commit 0966fb1b74b38b31dc83e3cca48701ec796bf73a Author: David Bright AuthorDate: 2022-04-12 16:15:06 +0000 Commit: David Bright CommitDate: 2022-04-12 16:23:56 +0000 Extend the length of dirpath to fix failure in kyua test When an overlength path is set as the temporary directory for test case sys/audit/inter-process:shm_unlink_success, the test will fail, e.g. ``` root@freebsd:/usr/tests/sys/audit # env TMPDIR=/var/tmp/tests/kyua kyua test inter-process:shm_unlink_success inter-process:shm_unlink_success -> failed: shm_unlink.*fileforaudit.*return,success not found in auditpipe within the time limit [10.452s] Results file id is usr_tests_sys_audit.20220412-221852-924310 Results saved to /root/.kyua/store/results.usr_tests_sys_audit.20220412-221852-924310.db 0/1 passed (1 failed) ``` The root cause is that dirpath is defined too small to handle it. Reviewers: vangyzen, dab Differential Revision: https://reviews.freebsd.org/D34885 Submitted by: Yongbo Yao (yongbo.yao@dell.com) Sponsored by: Dell Technologies --- tests/sys/audit/inter-process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/sys/audit/inter-process.c b/tests/sys/audit/inter-process.c index f29c23a4326b..6a9111712bf2 100644 --- a/tests/sys/audit/inter-process.c +++ b/tests/sys/audit/inter-process.c @@ -1454,7 +1454,7 @@ ATF_TC_HEAD(shm_unlink_success, tc) ATF_TC_BODY(shm_unlink_success, tc) { /* Build an absolute path to a file in the test-case directory */ - char dirpath[50]; + char dirpath[PATH_MAX]; ATF_REQUIRE(getcwd(dirpath, sizeof(dirpath)) != NULL); strlcat(dirpath, path, sizeof(dirpath)); ATF_REQUIRE(shm_open(dirpath, O_CREAT | O_TRUNC | O_RDWR, 0600) != -1);