From nobody Fri Apr 08 19:27:35 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0841D1AAAFD5; Fri, 8 Apr 2022 19:27:38 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KZpDT6rbFz4XML; Fri, 8 Apr 2022 19:27:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649446058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0aP1qKvdEQNveIIq2fj/2DybAmG277Yb87jLzEhTwoc=; b=TTYsh7W4Zbw0j3hhWdvuEa5l2f64ZxEd/1D369e/wRvrR5VD2lUQQSGZ/RVaAY4BPKlPF2 +HREkl5g1zFhNuIgElzIepSa+8WG5CcXS2UixHO80iy1D1CkC/mab2bmoVfDImoqJf3S/k S9sEb/AbezmAz/NMiMPRZ4ue54d4hH+eHyZtP7KJAEaDa9VJunXAG0A2QfPgrRPIGuY8+V L9G+vJ/9eP9xpxDuosn0cq8gVSBqgqyV/5vrXFlM5XNclO2qCk8HyEhFw4BUQiMCxqYS2I 6I+gyVeiW4ZK87lg8IKeizWAmvgwRZpIQE+vKA7QXYTqgyd16Pwd2fdt3XMYjA== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 3D5182DEDA; Fri, 8 Apr 2022 19:27:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <75ce6441-0043-f4f8-7ca1-94242660a134@FreeBSD.org> Date: Fri, 8 Apr 2022 12:27:35 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: git: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd. Content-Language: en-US To: Ravi Pokala , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202204080003.23803Vau086461@gitrepo.freebsd.org> <0FDDF3BC-0B91-405F-8E81-83309B1FA684@panasas.com> From: John Baldwin In-Reply-To: <0FDDF3BC-0B91-405F-8E81-83309B1FA684@panasas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649446058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0aP1qKvdEQNveIIq2fj/2DybAmG277Yb87jLzEhTwoc=; b=Hc2ah4kRZWg/m+QUZ6k0j2t618+8PLLpUao9gUVb9lGO9XUD/fcqw6TVATFvrlOiFVPx+Y HGj9XDGcLNhr7iq4dY3MvEh1RWEkkBXOTPjY1uxyPNekzyWvNJ2uGvQGSlbtiFdj8twoGK mnHwQGQGL/cl/6vGK4AonT/5IbDwvGt4zy7Y7IGSUk1aHqmh67FuEedEDCxSE6+V8lNirN lSeox4SL7/TwrmH5evZ4vmrvrNvUv6gnKcqACteGTo/9tX8XsGF5gzGayVxpOG3mMwTsfY FtmdP1rWg0V/1JUo3IDFvPegnhzrmVmL+HhjNhVwrH4/0GKqCW54edqdqbaqdA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649446058; a=rsa-sha256; cv=none; b=uWA6dMj+QT2JYI/FHnsQOV9q8QHhTX5CGYtDkxP9EdFGHcVjr3quAos5qHkXOo4B7WN4x7 oicxvZ4ZtmSQzCWuRsQZ5gtYm5vRofGyGqwpr2JG5Ou6FKe+tsgQUNzd8bikNPkReSwmNj /K+7w9YSppXjoF+wnzCSbvJCm9SWzLGZlRe+KVk1bhDO8Ol1KaOu49F4To3ITNqpaEKsaE FfFLNw4BOrQuXt1rPEVJx2NCjsZVUCUIatMFq5vl7cM/im5i90L4Jc198lHZlqwK2KaZlz V69cMzwtsBWcN3H4UKc8sgbq+PA6tm9TrlHTqnYIcruDlqpYX8Q033oW5kPNMQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 4/7/22 6:40 PM, Ravi Pokala wrote: > -----Original Message----- > From: on behalf of John Baldwin > Date: 2022-04-07, Thursday at 17:03 > To: , , > Subject: git: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd. > > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=885db9301ef9dfe420eff3c09aca497b7fc60924 > > commit 885db9301ef9dfe420eff3c09aca497b7fc60924 > Author: John Baldwin > AuthorDate: 2022-04-08 00:01:27 +0000 > Commit: John Baldwin > CommitDate: 2022-04-08 00:01:27 +0000 > > qlnx: Comment out remaining references to tx_data_bd. > > Why comment out, as opposed to removing outright (like most of the other unused-but-set cleanup)? > > Thanks, > > Ravi (rpokala@) In general I have commented out code for variables if the only uses of those variables are in commented out code vs removing it (as one would need to also remove the commented out code to remove it entirely) in case someone wanted to resurrect the commented out code. -- John Baldwin