Re: git: 7b1e19ad78c6 - main - Add libfido2 to the build

From: Peter Jeremy <peter_at_rulingia.com>
Date: Tue, 26 Oct 2021 20:54:12 UTC
On 2021-Oct-23 00:00:19 +0000, Ed Maste <emaste@FreeBSD.org> wrote:
>The branch main has been updated by emaste:
>
>URL: https://cgit.FreeBSD.org/src/commit/?id=7b1e19ad78c6a3f84f81cb1a16a39500f0337062
>
>commit 7b1e19ad78c6a3f84f81cb1a16a39500f0337062
>Author:     Ed Maste <emaste@FreeBSD.org>
>AuthorDate: 2021-10-07 01:52:05 +0000
>Commit:     Ed Maste <emaste@FreeBSD.org>
>CommitDate: 2021-10-22 23:57:57 +0000
>
>    Add libfido2 to the build

This triggered build failures on two of my hosts:

The first problem is that libfido2 is always built but has hard
dependencies on <dev/usb/usb_ioctl.h> and <dev/usb/usbhid.h>.  The latter
two headers are optionally installed based on "WITHOUT_USB".  I worked
around it by removing WITHOUT_USB but I'm not sure of the best general
solution here - making libfido2 optional would make the SSH integration
more complex.

The second problem showed up in a META_MODE parallel build as:
"install: libprivatefido2.a: No such file or directory"
with the following meta data:
.ERROR_TARGET='_libinstall'
.ERROR_META_FILE='/usr/obj/usr/src/arm64.aarch64/lib/libfido2/_libinstall.meta'
.MAKE.LEVEL='5'
.CURDIR='/usr/src/lib/libfido2'
.OBJDIR='/usr/obj/usr/src/arm64.aarch64/lib/libfido2'
.TARGETS='install'
DESTDIR='/usr/obj/usr/src/arm64.aarch64/tmp'

A retry succeeded so this may indicate a dependency tracking issue.  I
haven't dug into this further yet.

-- 
Peter Jeremy