From nobody Mon Oct 25 21:02:31 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5733E1821862 for ; Mon, 25 Oct 2021 21:02:40 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4HdS8J0TV0z3M3k for ; Mon, 25 Oct 2021 21:02:39 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1635195753; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=uXgCpctblJz5O3W5CKiOVswP2ku0zTtbVfgJHjWcjHuHSoW0KEeyZqs7LBUoFYEUU6UWAcLCT+4/+ ZBT33hy+7CZWCRKYWyPnh4mne3lnzXkIUpUdncKKRYswREgH9QtHo4yYNOzE1IDVjiLF6jJ3nAmT7q zudaH3IFT6unssKIWSkR1DaOwABGYrx0S0KBTaXsZOr17it/DtPo+7fGJi5Qe5K7Wrg/PLneWO+IdW mlhzK6sfEgGHQtj+fPa9Vwuc7oBIpB/JKDOv+zmhIB5el97hyefg3EvCat8j16EgeZXvTaJewHiKqD uEz8M7efEUyflgOO88bJwd+oPsucIqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=/rvx8eP5CN/8a8fmEuL4XbEUhiQRbJALZauTtSc9xE8=; b=M0Yp1swrnnwVia9nqMZDzPvdcRDwl/GZ1HOuccAQQHskvoowy4xLd0x3jcyVcndmtrM8Nzxlzdnz/ Z2cGdpS+B8yN9vNVq4FRQigYsG1BmdHDvzjGQp5GVnTSO0qtIwN5V8GxBeAvwXyr1l7Aa69Vqgsj92 UDCx9bxQAFwujvhpkvLtbHEd2YbTpegbpvr453v/qhTkUy7UWGkSSptwXDuSiUw3FniAG9DEjHHh9g KgELGssSvTXKDWGPxwAbjujLu672UzFBY0RgJfh5IS3HKZxLCRYKnVl9yX267yHuhOzYMttph6nGTl zEDL1YVrXOl15kbEcCxKa7FbmPXOc9g== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=24.8.225.114; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=/rvx8eP5CN/8a8fmEuL4XbEUhiQRbJALZauTtSc9xE8=; b=WnSRGQGPJxoFVnNOEmDroU0JLinoeW0LMB3Qk6967b98JVYHkkVFDIm2O9Y0OdHJPWMCAGQ7I5vbo Go2YY0yk3miyKmsioh1tbFamuhVMK3j1YAYGU7AR4+gSwsuACToQ7qrakjfhbFb2IhYVC6dFcBVeis W4ipq3jDYaN3FyRh+cl57VcQWvGbpfjPN1zlp399PUXjrI3NQxf+farnY4bxGQNY4wE2cCqFHCawty EP8FuPzEKf4nRJgtB/XlFM6oSFpNlCYc+TLs4HIWcRCpwN4THSIKuoROXyQ7fug77vr3aQ5KMVmJkG qd2NJryMlEd5mD2exUnDM4FwXWDqiHQ== X-Originating-IP: 24.8.225.114 X-MHO-RoutePath: aGlwcGll X-MHO-User: de912d67-35d6-11ec-a67c-89389772cfc7 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-24-8-225-114.hsd1.co.comcast.net [24.8.225.114]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id de912d67-35d6-11ec-a67c-89389772cfc7; Mon, 25 Oct 2021 21:02:32 +0000 (UTC) Received: from [172.22.42.84] (rev2.hippie.lan [172.22.42.84]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 19PL2Vx6097716; Mon, 25 Oct 2021 15:02:31 -0600 (MDT) (envelope-from ian@freebsd.org) X-Authentication-Warning: paranoia.hippie.lan: Host rev2.hippie.lan [172.22.42.84] claimed to be [172.22.42.84] Message-ID: <832a2403091df094d6f7ab471aef0694adebb939.camel@freebsd.org> Subject: Re: git: 548ada00e54a - main - LinuxKPI: add bcd.h From: Ian Lepore To: "Bjoern A. Zeeb" , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Date: Mon, 25 Oct 2021 15:02:31 -0600 In-Reply-To: <202110252023.19PKNSRO031788@gitrepo.freebsd.org> References: <202110252023.19PKNSRO031788@gitrepo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.3 FreeBSD GNOME Team List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4HdS8J0TV0z3M3k X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mon, 2021-10-25 at 20:23 +0000, Bjoern A. Zeeb wrote: > The branch main has been updated by bz: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=548ada00e54a9e7745d041b1ec7f68f3bd493365 > > commit 548ada00e54a9e7745d041b1ec7f68f3bd493365 > Author:     Bjoern A. Zeeb > AuthorDate: 2021-10-25 18:14:08 +0000 > Commit:     Bjoern A. Zeeb > CommitDate: 2021-10-25 20:20:53 +0000 > >     LinuxKPI: add bcd.h >     >     Add bcd2bin() as linuxkpi_bcd2bin().  Libkern does provide a > bcd2bin() > > [...] > + * We could use libkern, but we need the argument truncating. > + * What does that mean, "we need the argument truncating"? It looks to me like the only functional difference between the linux implementation and ours is that for invalid bcd data (nybble values in the range 0xA - 0xF) the linux version returns a crazy result and our lookup table returns 0. I doubt our code relies on that. -- Ian