From nobody Sat Oct 09 08:16:11 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2100E17E5CCB; Sat, 9 Oct 2021 08:16:21 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HRHvT0493z3ttC; Sat, 9 Oct 2021 08:16:21 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-ed1-x52b.google.com with SMTP id g8so45149179edt.7; Sat, 09 Oct 2021 01:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=g78y0fImNcabdUJNyZ8zD8Bh+WAe0w9VGUHDIqQwFHE=; b=iA2P+JMX5Bmgf9z2HinkZ3nXIR2lzMGl8meDPbUggcPnoLUoMYRwWWM22fl5qamI4u s6D4e5DmUtAh3PA3oRO3QQ0HQgm+SNDp5PjCSCJRZow3yEy6KDUZPrhszReFrTgOGfx6 j3+Vpap7wlDWkh5mkQQ+CRRcMDYeqKmbs22Q7GKWP0PdKSqiVfh3hYsoV3S6ZVpvfkNN cOGdD2fJt31b3mIYOoRYbRlyM5EfBK+v3mhlj5nYBM0NIQB/r/9h5HoXarUf6liAPyeT Dlhz1iktbqWob3P5WQ8+ejK7HWC51LsYaKX8NDyoOGs9xZ1P17JJOdFYzx9MZFkIWlmS +SNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=g78y0fImNcabdUJNyZ8zD8Bh+WAe0w9VGUHDIqQwFHE=; b=SWgmImICl8kipkIwqKpnqVCBQr5xKaD+JCoG4UsTfxyKT68qjq+AJzZd3Lcbj5hAtn WWzuzOXzKI6IJ/dnkTBEfLt25WCiE+00HYiFE/c3nWgAbJAtLKihVWV0cLISPs6u5xoI psmM4Zi+z3XKUgt3lbOlAOngkjkHGIvt++qns6vuTv+tkCIit9OvaNl32z4CIK7H+es/ +T0LnhbJPf5pyn9DD7/MllGQHrdj3OZS/6VTGizwxFWIkcHvGrvfiKudcbOuNw78IufL jNk3ji2qaUVBf9vRu1ZuRztrbMqw30zI/T+WmTvQJScLszW5Rw9h7M8lowKxmW5CkaFM jB0Q== X-Gm-Message-State: AOAM532E1t8EyXtdrlS7pyTwW8bzuWnCsL1MQqM184c8HimaRASZtKnU x/fNp/klMMGFYCFzGlJi3sEavEFq5wI= X-Google-Smtp-Source: ABdhPJwfUuJGssFP5uKJP7CXA5rNTymf4xEeFwYscuxpRCxOI1Oj7TdNi3y8qnNXYOuZaUj8dzyXDw== X-Received: by 2002:a05:6402:5112:: with SMTP id m18mr14062385edd.101.1633767373832; Sat, 09 Oct 2021 01:16:13 -0700 (PDT) Received: from ernst.home (p5b3becad.dip0.t-ipconnect.de. [91.59.236.173]) by smtp.gmail.com with ESMTPSA id o3sm644821eju.123.2021.10.09.01.16.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Oct 2021 01:16:12 -0700 (PDT) Date: Sat, 9 Oct 2021 10:16:11 +0200 From: Gary Jennejohn To: Konstantin Belousov Cc: "Piotr P. Stefaniak" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: bf8f6ffcb66a - main - Mention kern.timecounter.alloweddeviation in nanosleep.1 Message-ID: <20211009101611.07c89a1c@ernst.home> In-Reply-To: References: <202110081509.198F94HG022514@gitrepo.freebsd.org> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4HRHvT0493z3ttC X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Sat, 9 Oct 2021 09:43:34 +0300 Konstantin Belousov wrote: > On Sat, Oct 09, 2021 at 06:18:48AM +0000, Piotr P. Stefaniak wrote: > > On 2021-10-09 08:53:08, Konstantin Belousov wrote: > > > On Fri, Oct 08, 2021 at 03:09:04PM +0000, Piotr Pawel Stefaniak wrote: > > > > @@ -93,6 +93,8 @@ returns immediately and the calling thread is not suspended. > > > > .Pp > > > > The suspension time may be longer than requested due to the > > > > scheduling of other activity by the system. > > > > +It is also subject to the allowed time interval deviation > > > > +specified by the sysctl kern.timecounter.alloweddeviation. > > > This should be like > > > .Xr sysctl 3 > > > .Dv kern.timecounter.alloweddeviation > > > > @@ -94,7 +94,9 @@ returns immediately and the calling thread is not suspended. > > The suspension time may be longer than requested due to the > > scheduling of other activity by the system. > > It is also subject to the allowed time interval deviation > > -specified by the sysctl kern.timecounter.alloweddeviation. > > +specified by the > > +.Xr sysctl 3 > > +.Dv kern.timecounter.alloweddeviation . > > An unmasked signal will terminate the sleep early, regardless of the > > .Dv SA_RESTART > > value on the interrupting signal. > > > > > And then, it is missing a description what exactly is allowed by deviation, > > > for instance, what units this sysctl is? > > > > That would be redundant with sysctl -d. The point of this change is that now > > the user is much more likely to know of the sysctl and can look it up and read > > all about it. > > > sysctl -d is not a (good) documentation. When you read a man text, you are > supposed to get everything that is relevant there, although it might be > terse and requiring making logical deduction. This is not the case there. > > Anyway, I went ahead and did what you suggested. On one of my machines, > I got > solo% sysctl -d kern.timecounter.alloweddeviation > kern.timecounter.alloweddeviation: > solo% > > On another, > v1% sysctl -d kern.timecounter.alloweddeviation ~ > kern.timecounter.alloweddeviation: Allowed time interval deviation in percents > > Slightly more useful, but still. Percents of what? > I wondered about that myself when I looked at it yesterday. Just to be pedantic, percent is a contraction of per centum and does not have a plural form. It's always percent. > Imagine somebody reads the man page in the browser from Linux. Where should > he search for the sysctl description? > > > The bug may be that there isn't much documentation to be read about it, only > > sysctl -d and kern_tc.c. > > > > The only thing I worry that may be missing from this change is this reference > > in any other manual pages that might need it as much as nanosleep. > Well, nanosleep is just an example of a syscall requesting timeout. > Another poster childs there are select(2), and poll(2) family which > explicitly use precision. > > To get the definitive list, you would need to review all uses of > callout_reset() variants. > -- Gary Jennejohn