From nobody Sat Nov 27 23:38:01 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9F2D818B2EB4; Sat, 27 Nov 2021 23:38:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J1p2K2VNLz3k2J; Sat, 27 Nov 2021 23:38:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 354B0249E8; Sat, 27 Nov 2021 23:38:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1ARNc1VZ055450; Sat, 27 Nov 2021 23:38:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1ARNc1mC055449; Sat, 27 Nov 2021 23:38:01 GMT (envelope-from git) Date: Sat, 27 Nov 2021 23:38:01 GMT Message-Id: <202111272338.1ARNc1mC055449@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: c3134a6af07a - main - nfscl: Disable use of the LookupOpen RPC List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c3134a6af07af402b71f0b8587e09cb783c79eda Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638056281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=THoVrXIdnpUyrrcKsJF8QG0A1IyflWc+KBPKllpjO9M=; b=tVjIu1SwZtLBenf1P7q9VNl7pmfZIP/C3xZnEgCLhmOis6wfav2Djzi6GMkqu+eT2T+n4G A9UducNK/lvhUmdh5I6Rjx6c6O+np/mMHJKxhhvdxy+JUAmcC4RQmPGNbB9Riao0DvQ/4v CVwRxrzK4UeBpKGOlMPGjTAx5wqWstYJvxjzOjEXysJbH9WKZ+X07iWhzAOH0ugjvurFbp JiWmHz+RLSauxiJ7zPbPRZKwP2L6PjrvxceBiKwki1xYTxt+nALBaMMLgbO2Rmn6k6dJEu c3GYVXO9weMR/Kw0+l4nzQm+bQPujeLefa0SY2nlhyfsLSF7o/8vNGGnoMlRtg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638056281; a=rsa-sha256; cv=none; b=I3wN2NwN8VC/pPB/Yzaqzp8dB8eub4M4mml4gAMilyJFh4IOcx6pcvTggF3oMHs2jdZC89 j1y376gX9niAnAk0lHGug2Q+Iiu31lVVI+gQUPYHbAQkszRHafnCl2as8qo+o4vd87nasm 3/Y+aimWwJ806yB/hJsDW335XiV3v19o8Qb3VvlmBBc9xJY3aC0j9rc0CgXV5ukB7UlZxJ 8H4A7XRyc85xFkQauwiswRBKyMnETZMkzMiTn84OxdGlLcDAt0C/i/I/YlCXXZIFMKLuxh CpYIKTmDpcnl6Bww7eWuacBpz39pPlhkGtXyfAUwBEqTjZbkXbvbfn+QxHZaQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=c3134a6af07af402b71f0b8587e09cb783c79eda commit c3134a6af07af402b71f0b8587e09cb783c79eda Author: Rick Macklem AuthorDate: 2021-11-27 23:34:45 +0000 Commit: Rick Macklem CommitDate: 2021-11-27 23:34:45 +0000 nfscl: Disable use of the LookupOpen RPC The LookupOpen RPC reduces the number of Open RPCs needed. Unfortunately, it breaks certain software builds over NFS, so disable it until this is fixed. The LookupOpen RPC is only used for NFSv4.1/4.2 mounts when the "oneopenown" mount option is specified, so this should not affect many users. --- sys/fs/nfsclient/nfs_clvnops.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sys/fs/nfsclient/nfs_clvnops.c b/sys/fs/nfsclient/nfs_clvnops.c index 920bf2524c01..4a027ea07f26 100644 --- a/sys/fs/nfsclient/nfs_clvnops.c +++ b/sys/fs/nfsclient/nfs_clvnops.c @@ -1322,13 +1322,18 @@ nfs_lookup(struct vop_lookup_args *ap) cache_purge_negative(dvp); } + openmode = 0; +#if 0 + /* + * The use of LookupOpen breaks some builds. It is disabled + * until that is fixed. + */ /* * If this an NFSv4.1/4.2 mount using the "oneopenown" mount * option, it is possible to do the Open operation in the same * compound as Lookup, so long as delegations are not being * issued. This saves doing a separate RPC for Open. */ - openmode = 0; NFSLOCKMNT(nmp); if (NFSHASNFSV4N(nmp) && NFSHASONEOPENOWN(nmp) && (nmp->nm_privflag & NFSMNTP_DELEGISSUED) == 0 && @@ -1340,6 +1345,7 @@ nfs_lookup(struct vop_lookup_args *ap) openmode |= NFSV4OPEN_ACCESSWRITE; } NFSUNLOCKMNT(nmp); +#endif newvp = NULLVP; NFSINCRGLOBAL(nfsstatsv1.lookupcache_misses);