From nobody Fri Nov 26 14:24:00 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 65BC218A2B80; Fri, 26 Nov 2021 14:24:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J0xnY3t8jz4c8M; Fri, 26 Nov 2021 14:24:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 182CB2274; Fri, 26 Nov 2021 14:24:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1AQEO0jK002441; Fri, 26 Nov 2021 14:24:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1AQEO0Sa002440; Fri, 26 Nov 2021 14:24:00 GMT (envelope-from git) Date: Fri, 26 Nov 2021 14:24:00 GMT Message-Id: <202111261424.1AQEO0Sa002440@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andriy Gapon Subject: git: 578707ed4efd - main - twsi: improve a handful of debug messages List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 578707ed4efda4ec1c91ab1a8f1bace6b1eb714a Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637936641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XZ50NqMVLZ+yfgp0cRiGHBSyMajg7iubLTqvHWeOx3k=; b=JcdoOoXqgWeiCBmz7c4qeb9+cqh6n+0ohVb11+3C0MvXPquldFXQdjmLghHl/iBxZ7MLiW 2vRXgymHZrMYhhEg8dDME/4YvGF6B0Mbl/YbcU0xnvcZEaOc2/rZDwVKSf+7wOdHDRpcAY +DLVrlwa3ioQ2/M+anj2rtDwDYTP195hLiHHVWMccTfzosU+delIfMoGM4rc6XPlBDdObA n4q6J7OrE9uT0Y+1JEvmn1XvFXDu5Jy9C1AIFoafDWbjkokxACDk5rxzGoYqx2NjRsk0GE w4iUf5pjj9/DvOCNdrv5Go8oOxGuSRBxovgcOt5pXlVRh0rKF7Yg6Dg6IXbf0g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637936641; a=rsa-sha256; cv=none; b=tC6CodSSNwa3T4S9NVLmShJia1pN9w9kkhmoh3WsHogWaBoRONDYvObI7OcwIjtcKYIivO YEiVTcuPmzOiYy/O64KSgPIdjKBsmPAsydIZ5KdIJL9PG40HpxkJ0mdWn7yH0AVJ+Z2Dsg QSmKghvwLubFINPy71NKwEc1moxb5ncuxKssyR9ewIPb+U9YKj1b7HpLev5/2ogfCIslk2 XQK75yh1jko3KNuruu5p82sVOQzKsqg4EqFgyVQXXgb7N2ojXzIu8sfTSuwLpPUiwI+Pfv +9rRdipL3243d/Iit1x7+CFd4qAduhVa3cO7MBm58sQltO4OtKTxluWqZB7+9Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=578707ed4efda4ec1c91ab1a8f1bace6b1eb714a commit 578707ed4efda4ec1c91ab1a8f1bace6b1eb714a Author: Andriy Gapon AuthorDate: 2021-11-26 07:34:28 +0000 Commit: Andriy Gapon CommitDate: 2021-11-26 14:16:01 +0000 twsi: improve a handful of debug messages - use 0x prefix for hex values - print indexes and counts as decimals - break too long lines MFC after: 2 weeks --- sys/dev/iicbus/twsi/twsi.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sys/dev/iicbus/twsi/twsi.c b/sys/dev/iicbus/twsi/twsi.c index 5e899313ac45..384e19e120b9 100644 --- a/sys/dev/iicbus/twsi/twsi.c +++ b/sys/dev/iicbus/twsi/twsi.c @@ -534,9 +534,9 @@ twsi_transfer(device_t dev, struct iic_msg *msgs, uint32_t nmsgs) debugf(sc, "Error: %d\n", sc->error); /* Disable module and interrupts */ - debugf(sc, "status=%x\n", TWSI_READ(sc, sc->reg_status)); + debugf(sc, "status=0x%x\n", TWSI_READ(sc, sc->reg_status)); TWSI_WRITE(sc, sc->reg_control, 0); - debugf(sc, "status=%x\n", TWSI_READ(sc, sc->reg_status)); + debugf(sc, "status=0x%x\n", TWSI_READ(sc, sc->reg_status)); error = sc->error; mtx_unlock(&sc->mutex); @@ -553,10 +553,11 @@ twsi_intr(void *arg) sc = arg; mtx_lock(&sc->mutex); - debugf(sc, "Got interrupt Current msg=%x\n", sc->msg_idx); + debugf(sc, "Got interrupt, current msg=%u\n", sc->msg_idx); status = TWSI_READ(sc, sc->reg_status); - debugf(sc, "reg control=%x\n", TWSI_READ(sc, sc->reg_control)); + debugf(sc, "reg control = 0x%x, status = 0x%x\n", + TWSI_READ(sc, sc->reg_control), status); if (sc->transfer == 0) { device_printf(sc->dev, "interrupt without active transfer, " @@ -570,7 +571,8 @@ twsi_intr(void *arg) case TWSI_STATUS_START: case TWSI_STATUS_RPTD_START: /* Transmit the address */ - debugf(sc, "Send the address (%x)", sc->msgs[sc->msg_idx].slave); + debugf(sc, "Send address 0x%x\n", + sc->msgs[sc->msg_idx].slave); if (sc->msgs[sc->msg_idx].flags & IIC_M_RD) TWSI_WRITE(sc, sc->reg_data,