From nobody Sat Nov 20 08:10:49 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 63E1A1892CFF; Sat, 20 Nov 2021 08:10:52 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hx5nl6JBNz3sfg; Sat, 20 Nov 2021 08:10:51 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 1AK8AnPC037208 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 20 Nov 2021 00:10:49 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 1AK8An7W037207; Sat, 20 Nov 2021 00:10:49 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Sat, 20 Nov 2021 00:10:49 -0800 From: Gleb Smirnoff To: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ff94500855c1 - main - Add tcp_freecb() - single place to free tcpcb. Message-ID: References: <202111190428.1AJ4SEAh021121@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202111190428.1AJ4SEAh021121@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4Hx5nl6JBNz3sfg X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US] X-ThisMailContainsUnwantedMimeParts: N On Fri, Nov 19, 2021 at 04:28:14AM +0000, Gleb Smirnoff wrote: T> The branch main has been updated by glebius: T> T> URL: https://cgit.FreeBSD.org/src/commit/?id=ff94500855c16d0d9cc18aa8b0ba73ea94020c56 T> T> commit ff94500855c16d0d9cc18aa8b0ba73ea94020c56 T> Author: Gleb Smirnoff T> AuthorDate: 2021-11-19 04:26:09 +0000 T> Commit: Gleb Smirnoff T> CommitDate: 2021-11-19 04:27:45 +0000 T> T> Add tcp_freecb() - single place to free tcpcb. T> T> Until this change there were two places where we would free tcpcb - T> tcp_discardcb() in case if all timers are drained and tcp_timer_discard() T> otherwise. They were pretty much copy-n-paste, except that in the T> default case we would run tcp_hc_update(). Merge this into single T> function tcp_freecb() and move new short version of tcp_timer_discard() T> to tcp_timer.c and make it static. T> T> Reviewed by: rrs, hselasky T> Differential revision: https://reviews.freebsd.org/D32965 Should have been https://reviews.freebsd.org/D32966 -- Gleb Smirnoff