From nobody Mon Nov 15 16:16:43 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E175118961EE; Mon, 15 Nov 2021 16:16:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HtDpj629wz3tlF; Mon, 15 Nov 2021 16:16:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (unknown [IPv6:2601:648:8601:8b20:20ec:4262:a347:5719]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 173DA25F30; Mon, 15 Nov 2021 16:16:44 +0000 (UTC) (envelope-from jhb@FreeBSD.org) To: Randall Stewart Cc: Jessica Clarke , Randall Ray Stewart , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202111111131.1ABBVH6s017371@gitrepo.freebsd.org> <2a564b11-b1f4-a4fe-745b-27f45fb134eb@FreeBSD.org> <5A60AA15-F560-44D9-89A0-BD0A197E5E58@netflix.com> From: John Baldwin Subject: Re: git: b8d60729deef - main - tcp: Congestion control cleanup. Message-ID: <5cef43ac-0c37-5b3b-c938-1024fc746cb0@FreeBSD.org> Date: Mon, 15 Nov 2021 08:16:43 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 In-Reply-To: <5A60AA15-F560-44D9-89A0-BD0A197E5E58@netflix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 11/14/21 7:03 AM, Randall Stewart wrote: > John: > > This is fine to do, but I want to make sure everyone understands that > I was specifically asked to make compile fail on the transport call > if CC_XXXX or CC_DEFAULT was not defined. Its not how I had the code > originally but it was requested specifically. > > I am fine with all the changes aka it showing up in DEFAULT that’s a > good solution. > > And I think Warner’s patch with an ifndef in cc.c works perfectly that > way if you are say netapp and don’t use newreno you can do a > > nooptions CC_NEWRENO > options CC_CUBIC > options CC_DEFAULT=\”cubic\” > > And it all just works for you ;) No worries. I think this is one of those cases where some things just aren't obvious until subjected to wider testing. You sought review (and got a fair bit of it), and without some kind of available pre-commit CI I don't know that we can expect folks to boot changes in qemu for all architectures by hand prior to commit (which I think might have been the only realistic way to catch the breakage on arm64 or the vnet issues). I do think one of the goals of Warner's group is to figure out a way to provide some level of pre-commit CI that folks can opt into. FWIW, the arm64 breakage wasn't really due to the changes in this commit either, it was just that this commit exposed a longstanding bug in the hhook code that hadn't yet surfaced. -- John Baldwin