Re: git: 184c63db3c94 - main - Fix clerical error in page alloc

From: Doug Moore <unkadoug_at_gmail.com> wrote oo
Date: Sat, 25 Dec 2021 11:56:10 -0600 :
Guido -

> I've made three vm changes this month, though it's taken me 6 commits to
> do it.
> 
> The first change was trivial.
> 
> The last commit before the second change was
> commit 02732f945ed2ec2b4fd03421923720608b28a615
> and that change was in place after
> commit f7aa44763d20d06c9ea5caf330aca02a8b107a70
> 
> The last commit before the third change was
> commit b7ec0d268b73ce20c4f785d21cde9b174c91a553

That is an Alan Cox commit ("arm64: Introduce and
use pmap_pte_exists()") after one of yours,

fb38b29b5609b0c0769b2b2e1d6c917c0799f2a0
("vm_page: Remove extra test, dup code from page alloc")
(38 hours ago)

> and it was done after
> commit 0d5fac287294490ac488d74e598e019334610bdb
> (except for moving a comment).

That is one of yours ("vm: alloc pages from reserv before
breaking it"), 24 hours ago.

> I suggest you test before and after the second change to see if it
> introduced a problem, then before and after the third change.


I'll also note that:

https://lists.freebsd.org/archives/dev-commits-src-main/2021-December/002437.html

claims to have seen problems before:

0d5fac287294490ac488d74e598e019334610bdb (vm: alloc pages from reserv 
before breaking it)

and was hoping that progressing to that one would be a fix.

===
Mark Millard
marklmi at yahoo.com