From nobody Sat Dec 25 17:11:50 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 736BA191092C; Sat, 25 Dec 2021 17:11:53 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JLr7s1CTfz4XDZ; Sat, 25 Dec 2021 17:11:53 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from [172.24.42.21] (unknown [87.13.153.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 6B8CD617E; Sat, 25 Dec 2021 17:11:52 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: <675f75ea-b5ca-a47c-f1a9-9621b0c8b36e@FreeBSD.org> Date: Sat, 25 Dec 2021 18:11:50 +0100 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: git: 184c63db3c94 - main - Fix clerical error in page alloc Content-Language: en-US To: FreeBSD User , Doug Moore Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202112240851.1BO8pdnH043305@gitrepo.freebsd.org> <20211225122334.651e9acd@jelly.fritz.box> From: Guido Falsi In-Reply-To: <20211225122334.651e9acd@jelly.fritz.box> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1640452313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qxc9cHRxVWcWkfEsJ39oE+XAbayF7OvcsugW7p6OWPI=; b=KM9lkBaV7wYIjcweXoq5ODgVuHgptSEAVL4gsBQWzO3ysHdLM8Osb6x/TsPlqTG67DlzPS yaVypRvoFDCvBPPVctiZpiBQC/m5n58PPqKwb4kqd44X/s3jX5aB1YreiFGi7+XFu0bN37 gP+UlkXoFJCQxoUwqeUoJ2AruOFy5LE2W0+Gu1AGw1qrJt3YuruZz2sX4CZUZqIytCPiFX ij2GBKSlqBpMYNsRhRQFRdgpF2s9cMSpZ3LpDmIZxi9c9m/kNdpi+RU9vdHTR66BR5uCx8 B4XXR6oC5LM9AU6nc+57KByJsIjP4NfYLV9X33sVUBi+rsmWcxg1xzPQUqp3fw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1640452313; a=rsa-sha256; cv=none; b=ajC4n3eoaPpyVBVFeoOkuIsc0u7EaUtQDtrR3tSc8K8lxl37Xldqz+9RdPmAnyGJBWivVO qiiQYOnoswuFa3fGIRZcc9QVDtE9nqCzIwMhpDl41zV3GfDYxOVIjxMXU1+G5tp2A5OxEM 2E5t/eOAjacJ21ae1YF2Nm1YOIKD27PrWppxmEcJb9zaTGDNGP+AEfIabf+7+ScUC7/QOZ YrgPcaRmuDfGvmWWEGKQUv9SqgoBv/Mr9hHQsDmE9lrCL+juSDPOmSAHVE9tJxnkF2kF0E EIqCABJuRxufRPeTWQlcNMiOIv+9WPnon1rkBd+nQQLLFxRrwLvgtXSsHzXEzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 25/12/21 12:23, FreeBSD User wrote: > Am Fri, 24 Dec 2021 08:51:39 GMT > schrieb Doug Moore : > >> The branch main has been updated by dougm: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=184c63db3c949d8ba766dc7b2bd2f082404e169d >> >> commit 184c63db3c949d8ba766dc7b2bd2f082404e169d >> Author: Doug Moore >> AuthorDate: 2021-12-24 08:47:21 +0000 >> Commit: Doug Moore >> CommitDate: 2021-12-24 08:47:21 +0000 >> >> Fix clerical error in page alloc >> >> Fix a very recent change that introduced a page accounting error >> in case of a reserveration being broken. >> Reviewed by: alc >> Fixes: fb38b29b5609 (page_alloc_br) vm_page: Remove extra test, >> dup code from page alloc Differential Revision: >> https://reviews.freebsd.org/D33645 --- >> sys/vm/vm_page.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c >> index c24da96f4312..03351b0ad3dd 100644 >> --- a/sys/vm/vm_page.c >> +++ b/sys/vm/vm_page.c >> @@ -2186,11 +2186,11 @@ vm_page_find_contig_domain(int domain, int >> req, u_long npages, vm_paddr_t low, vm_page_t m_ret; >> >> vmd = VM_DOMAIN(domain); >> - if (!vm_domain_allocate(vmd, req, npages)) >> - return (NULL); >> #if VM_NRESERVLEVEL > 0 >> again: >> #endif >> + if (!vm_domain_allocate(vmd, req, npages)) >> + return (NULL); >> /* >> * Try to allocate the pages from the free page queues. >> */ >> > > It seems that our hosts running with this patch are "dead" after a > while while under load (poudriere): ssh on both IPv4 and IPv6 are dead > as well as http/https on IPv4/IPv6 (remote site, no connection via ssh > anymore, but hosts respond to ping, nmap show several other services on > local network as reachable, but no ssh(22)/apache24(http/https). > Other hosts at OS level before this patch seem to be allright so far > (i.e. FreeBSD 14.0-CURRENT #39 main-n251899-fa255ab1b895: Thu Dec 23 > 13:48:41 CET 2021 amd64). > > I have to admit its a wild guess that this patch is the culprit, but it > is strange that two out of four hosts with this patch applied are now > both unreachable on both ssh and http (lates www/apache24) while two > other hosts stuck with the version showed above seem to operate on > ssh/http. > > Can investigate earliest after 26th of December. I'm also seeing a strange behaviour related to memory and the VM subsystem with recent (24th December) head . It was not happening with head from mid November. I'm seeing strange issues with virtualbox on recent head too. It fails to launch VMs or VMs pause due to memory exhaustion, while the machine has lots of free memory. Maybe the real issue is memory fragmentation though. I'm now testing updating to newer head including commit 0d5fac287294490ac488d74e598e019334610bdb (vm: alloc pages from reserv before breaking it) which is definitely related and maybe fix this. Anyway there is definitely something going on with recent changes to VM subsystem that requires investigation. I can reproduce this easily, just install virtualbox-ose, create a VM with a non tiny memory footprint and run it, or run more than one. It is easier to reproduce if some other software is already running on the machine (this is why I suspect some memory fragmentation issue). -- Guido Falsi