From nobody Mon Dec 20 07:32:10 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8FC6F18F4618 for ; Mon, 20 Dec 2021 07:32:27 +0000 (UTC) (envelope-from wma@semihalf.com) Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JHWWb3BY3z3Kfl for ; Mon, 20 Dec 2021 07:32:27 +0000 (UTC) (envelope-from wma@semihalf.com) Received: by mail-yb1-xb35.google.com with SMTP id j2so25996587ybg.9 for ; Sun, 19 Dec 2021 23:32:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xTdQwLvs0MXYQIHAxugLzQGGqDAEZ4dOE7gYNi4bpcc=; b=EAYg60k+rM/HmbRkIdFid7GTnA2WChSCegXPISTzOKZBhuZi3HGmOjcq/v2tdS3bnH 6StuQc832wGYgtfmIF1nFZtxxp5MCj6zOxY2V0j/jELQ4wshcGiQ5nyUmnURrlfFgTHX 2rUNhx1QhweALPu9tefc1VtRqycecus7p2U/fn0ewJ9G36NhUICCtgvGes2H4eV/QGNy xMPGhUVLv18+XE+SsCHGRNYkE3qRo947RmLn+gC4gVgsT4eh4qbCLdlHVIDNwWqXl1bO F+Wg8/YR46rJqFT+tKCnjMRk53fOzFzjBH/yKIHteIxoVtnHsL7rBneq/c9q1+p1CSNU o4Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xTdQwLvs0MXYQIHAxugLzQGGqDAEZ4dOE7gYNi4bpcc=; b=w/ILAjEOCSNfuaGajsIcCaOFnSK7keU/v/2OkmB0C3UXMU658Eh2RwUmC2QOjamkv+ S5QPnPMlmFVeWs7pyEfn4RNHD8ia4NE5HW3NfiKJaP8DBRmLIgBTooHlj+jP+vz8CEVB bi83VTV9pN3G51XkiFIuzG9dZU59HoCBSGQ8z5ThIi/MDXQ3LuHnAK1uqf3KkKMovsRi ZoWe+5tqMxMbEmXoAXlW3XxFBSjVz9eb036nBIWa0oy81fIokNnZYvf/nPJIlHx3L6uT tOIJKCeT78388rd7SsdBPgcgWq2EsDvFfeIBwQ8Eftwt7kcrZ7bYuAJsSTtPn7nM/UjH xQuA== X-Gm-Message-State: AOAM531UyJxXod9rKknRmOTK9F5atnwDx3+6v5NaffzmoLWIEc6kWJPe uYBvg+7hBU1IXsSJnK4Vb/yMaaK+uWxdJgM1Q/fxbWgCpRI= X-Google-Smtp-Source: ABdhPJxdDWwJHaTK00ByzcUZpcPnaSJkxBpTMqPfQUxe199KMrSc7578lfeuDbaGFcVNpCYOVXccXvGBBC/7YWJ8CYQ= X-Received: by 2002:a25:ad06:: with SMTP id y6mr20862029ybi.278.1639985541221; Sun, 19 Dec 2021 23:32:21 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202112200529.1BK5T0np047358@gitrepo.freebsd.org> In-Reply-To: From: Wojciech Macek Date: Mon, 20 Dec 2021 08:32:10 +0100 Message-ID: Subject: Re: git: 4f741801d860 - main - t_setrlimit: Adjust resource limit to 20M To: Kyle Evans , Marcin Wojtas Cc: Wojciech Macek , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000009f256a05d38ee393" X-Rspamd-Queue-Id: 4JHWWb3BY3z3Kfl X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --0000000000009f256a05d38ee393 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Kyle, Thanks for the comment, I thought this one is discussed but apparently I was mistaken. Adding Marcin to handle this on our side. I'm fine with reverting it anyway or do whatever you decide. Regards, Wojtek pon., 20 gru 2021 o 07:51 Kyle Evans napisa=C5=82(a): > On Sun, Dec 19, 2021 at 11:29 PM Wojciech Macek wrote: > > > > The branch main has been updated by wma: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D4f741801d86089a1c5d631ba1e0f142= 1cdcf7a7e > > > > commit 4f741801d86089a1c5d631ba1e0f1421cdcf7a7e > > Author: Dawid Gorecki > > AuthorDate: 2021-12-20 05:27:12 +0000 > > Commit: Wojciech Macek > > CommitDate: 2021-12-20 05:28:20 +0000 > > > > t_setrlimit: Adjust resource limit to 20M > > > > With ASLR enabled by default, RLIMIT_STACK test fails due to the fa= ct > > that default stack gap can be as big as 15M. Because of that the > > resource limit of 4M results in test program receiving SIGSEGV > > immediately after exiting the setrlimit syscall. Since the idea of > this > > test is to check if rlim_cur does not extend past rlim_max, adjusti= ng > > the resource limit to 20M should not invalidate the test results. > > > > I can't seem to find the PR at the moment, but isn't this exactly the > kind of thing markj@ talked about trying to avoid elsewhere? It seems > like this probably should've been involved in the discussion rather > than hacked around independently. > > Thanks, > > Kyle Evans > --0000000000009f256a05d38ee393 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Kyle,

Thanks for the comment, I thou= ght this one is discussed=C2=A0but apparently I was mistaken.
Add= ing Marcin to handle this on our side. I'm fine with reverting it anywa= y or do whatever you decide.

Regards,
Wo= jtek

pon., 20 gru 2021 o 07:51=C2=A0Kyle Evans <kevans@freebsd.org> napisa=C5=82(a):
On Sun, Dec 19, 2021 at 11:2= 9 PM Wojciech Macek <wma@freebsd.org> wrote:
>
> The branch main has been updated by wma:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3D4f741801d86089a1c5d631ba1e0f1421cdcf7a7e<= /a>
>
> commit 4f741801d86089a1c5d631ba1e0f1421cdcf7a7e
> Author:=C2=A0 =C2=A0 =C2=A0Dawid Gorecki <dgr@semihalf.com>
> AuthorDate: 2021-12-20 05:27:12 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Wojciech Macek <wma@FreeBSD.org>
> CommitDate: 2021-12-20 05:28:20 +0000
>
>=C2=A0 =C2=A0 =C2=A0t_setrlimit: Adjust resource limit to 20M
>
>=C2=A0 =C2=A0 =C2=A0With ASLR enabled by default, RLIMIT_STACK test fai= ls due to the fact
>=C2=A0 =C2=A0 =C2=A0that default stack gap can be as big as 15M. Becaus= e of that the
>=C2=A0 =C2=A0 =C2=A0resource limit of 4M results in test program receiv= ing SIGSEGV
>=C2=A0 =C2=A0 =C2=A0immediately after exiting the setrlimit syscall. Si= nce the idea of this
>=C2=A0 =C2=A0 =C2=A0test is to check if rlim_cur does not extend past r= lim_max, adjusting
>=C2=A0 =C2=A0 =C2=A0the resource limit to 20M should not invalidate the= test results.
>

I can't seem to find the PR at the moment, but isn't this exactly t= he
kind of thing markj@ talked about trying to avoid elsewhere? It seems
like this probably should've been involved in the discussion rather
than hacked around independently.

Thanks,

Kyle Evans
--0000000000009f256a05d38ee393--