From nobody Sat Dec 18 20:33:51 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4FDA818EBECD; Sat, 18 Dec 2021 20:34:00 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4JGcyH2wVfz3Pkt; Sat, 18 Dec 2021 20:33:59 +0000 (UTC) (envelope-from hps@selasky.org) Received: from [10.36.2.165] (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 53F3A26047F; Sat, 18 Dec 2021 21:33:58 +0100 (CET) Message-ID: Date: Sat, 18 Dec 2021 21:33:51 +0100 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: git: 45b48cbc2b58 - main - usb: real freebsd32 support for most ioctls Content-Language: en-US From: Hans Petter Selasky To: Shawn Webb , Brooks Davis Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202112172128.1BHLSvgR063035@gitrepo.freebsd.org> <20211218190800.2v7bzacypzhiguvz@mutt-hbsd> <4961aa77-848f-ab04-91aa-7526ebb0bdde@selasky.org> In-Reply-To: <4961aa77-848f-ab04-91aa-7526ebb0bdde@selasky.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4JGcyH2wVfz3Pkt X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-1.31 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.99)[0.987]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: N On 12/18/21 21:13, Hans Petter Selasky wrote: > On 12/18/21 20:08, Shawn Webb wrote: >> +#ifdef COMPAT_FREEBSD32 >> +    hgd = (struct hidraw_gen_descriptor *)addr; > > Looks like this line should be moved before the COMPAT_FREEBSD32 ifdef. > I'll let Brooks fix this. > > --HPS > I've made two fixes. Brooks, please check these patches too: https://cgit.freebsd.org/src/commit/?id=34077a8ed39f40da4b7faffff0b112f1dcb62ab4 https://cgit.freebsd.org/src/commit/?id=8b60419b798ae9049988c529e6af3f313a5cce55 --HPS