From nobody Tue Dec 14 19:20:58 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EE9FA18E5541; Tue, 14 Dec 2021 19:21:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JD7Ww5spRz4rg2; Tue, 14 Dec 2021 19:21:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id EA68D598F; Tue, 14 Dec 2021 19:20:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 14 Dec 2021 11:20:58 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: git: 4dbc7835cdfc - main - mips: Turn off LLVM MIPS targets by default Content-Language: en-US To: Warner Losh Cc: Ed Maste , Warner Losh , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Dimitry Andric References: <202112101831.1BAIVQbm048153@gitrepo.freebsd.org> <367d9216-53f7-044d-34b9-fae8460bd7bc@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639509660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BN2w58mJBipsh6LvnUs4mXIu9KxzgObY5nvwfyCAHMA=; b=tuabTij7xMKRdKEiDtAItpoEqNn4aMvdpXsInHKWWgKvGnfwA9zdCUVUWDMeYYAXd3nDTZ 31/dCWtf98HD/sxsBC0MuVRouhvUMfEuJmWXWPRMldod7+xdLp9nGiaaERjOhxKADYJsAB 06RLEXbG9UUxo4I097dbjV1Cxn691vDf4S3iMsmxM1mOZ9tJYYD42OM1RToAJlKlLhq6Rn wJTqlpXETo2wkzGXf5OTF1kTSgPnoD9ar3uzSYY6BG2BGI0EhrlhYS82wP5NebIva2EzRA j/80fZEJRxoPHb4Se4DB34Ii54qac+diLgniHboB7HL58ksZehZJb2UDMmj52A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639509660; a=rsa-sha256; cv=none; b=frOfwR1hvtmoEzoOVpmJioJlcPmzUEXo7f2L3sogK34JAfwdrJNMAX2mK1POto/EsyR2B8 iqHdG+e7CPoimCqt7Su9Uo4WkyzQzBaC54VCeUM/JAxEZn6wKN53sPmhWnWn2m8qSh2HrB xfvTObT6nJvrYVnh9ytFuP7c4hiPQzBGEW3J/8lskp92kGER/xBBfSXZ5Sslu+mMySrpaZ FSqHJMtmuCHzpiE+wT9IN/edGhziVAfn7b8nbiyvhARChSvPnebUaR32+D3dbgOAx5ZZD1 WZxRB5KMIU8B3N4cChPXVQSoKXonbDSVNEpfJSk6pDzQsgFaHt3pnRHQKaWbtA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 12/14/21 11:09 AM, Warner Losh wrote: > On Tue, Dec 14, 2021 at 11:57 AM John Baldwin wrote: > >> On 12/14/21 10:42 AM, Ed Maste wrote: >>> On Tue, 14 Dec 2021 at 13:27, John Baldwin wrote: >>>> >>>> This breaks NO_CLEAN=yes builds in I think a lot of object files. >>>> ... >>>> Perhaps we should be generating those header files in OBJDIR (and use a >> move-if-changed >>>> scheme to avoid bumping the date if the contents haven't changed) so >> that make can handle >>>> these changes? >>> >>> Seems reasonable if that change is straightforward, but we could also >>> just add a special case in tools/build/depend-cleanup.sh to handle >>> this. depend-cleanup can be fairly liberal, e.g. delete *.def. >> >> Yes, but the problem isn't deleting *.def. Those are static files whose >> content >> changes based on -D flags passed on the command line and you need to >> delete all >> the *.o files that include those .def files. Note that if you switch from >> WITHOUT_LLVM_TARGET_ALL to WITH_LLVM_TARGET_ALL or vice versa between >> builds >> you would also hit this issue. >> > > True that. Hence my desire to move these into a file that changes when the > option changes :) > > If there's some cheap hack I can do to fix this, I'm open to suggestions. I > just don't want to spend > a day futzing with it since I have other things I'm trying to get done this > week.... I don't know that we have a cheap way to do this. Maybe dim@ is willing to look at generating those files? We'd want a move-if-change wrapper around them though which is not something we currently do for generated files. -- John Baldwin