From nobody Mon Dec 06 21:31:43 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 89B9B18B2F48 for ; Mon, 6 Dec 2021 21:31:45 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J7GpT3KJvz3JWQ for ; Mon, 6 Dec 2021 21:31:45 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f43.google.com with SMTP id i12so9194378wmq.4 for ; Mon, 06 Dec 2021 13:31:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=XooDW9J+qo0zvNWC0lKEuw8bV13r5UAKkQ2B0a5O0so=; b=ORPdSmDKzMa1dBAQalF7C0Voktt7l2AEtGo8QFt3TvCqkHDH+zDIRQIcOr2pf95w1+ NlDfP+ICQYyixlsc2Z4psBiT9PJz1gCFAbc8T5pYSaToBP3SJ4nHnOqf4hfIMHdtT9x7 AeOqncX9par+xkcPhGyMK6j1Nem4xhPL16pX5UPXE/c0PhgTGuCxt/mLtjlmZmarNrDj iFwYyhd5QfEzlr3beMaL74DFo4Xeuihf2pd8DT39wSGejtxHFR/RT0uaKi1gQRjo+UaH yWXxaQQiXgTdna1/9PmV7RUpc2cyxLETvwwjsCbO9b5jRxwjEsyc5TTS9QtnSLDi3VBU ESHg== X-Gm-Message-State: AOAM532h0a73hxAu8K2PLM2qNvECyJEgr8TnnhBkFSNH7cifIGJdiz+L BfMAvYNf0aPc1oWNz2IElnNssw== X-Google-Smtp-Source: ABdhPJydMd0/9qjr+Okbtm6soSvh51NL+JEsp+VfCEQRVYrX3Qz9y+d7RdIHZ+MrPG9+Ig+ecCEm6A== X-Received: by 2002:a1c:7517:: with SMTP id o23mr1418469wmc.172.1638826304458; Mon, 06 Dec 2021 13:31:44 -0800 (PST) Received: from smtpclient.apple (global-5-141.nat-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id g13sm16900768wrd.57.2021.12.06.13.31.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Dec 2021 13:31:44 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: ab4524b3d7fb - main - amd64: wrap 64bit sigtramp into vdso From: Jessica Clarke In-Reply-To: Date: Mon, 6 Dec 2021 21:31:43 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202112061848.1B6ImIf8065076@gitrepo.freebsd.org> To: Konstantin Belousov X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4J7GpT3KJvz3JWQ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 6 Dec 2021, at 21:28, Konstantin Belousov = wrote: >=20 > On Mon, Dec 06, 2021 at 08:51:02PM +0000, Jessica Clarke wrote: >> On 6 Dec 2021, at 18:48, Konstantin Belousov wrote: >>>=20 >>> The branch main has been updated by kib: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dab4524b3d7fba872a143b03c9346cb04= c3670efa >>>=20 >>> commit ab4524b3d7fba872a143b03c9346cb04c3670efa >>> Author: Konstantin Belousov >>> AuthorDate: 2021-11-05 08:07:24 +0000 >>> Commit: Konstantin Belousov >>> CommitDate: 2021-12-06 18:46:49 +0000 >>>=20 >>> amd64: wrap 64bit sigtramp into vdso >>>=20 >>> Reviewed by: emaste >>> Discussed with: jrtc27 >>> Tested by: pho >>> Sponsored by: The FreeBSD Foundation >>> MFC after: 1 month >>> Differential revision: https://reviews.freebsd.org/D32960 >>=20 >> This broke cross-building from non-FreeBSD: >>=20 >>> ERROR: ctfconvert: elf-vdso.so.o doesn't have type data to convert >>=20 >> The error message also shows up on FreeBSD, but ctfconvert has a = gross >> #ifdef __FreeBSD__ hack in it to make it non-fatal (dating right back >> to when it was imported), which of course doesn=E2=80=99t work when = building on >> non-FreeBSD, and is something I=E2=80=99ve wanted to remove from = FreeBSD too as >> silently allowing broken CTF is a bad idea these days (see AArch64 >> where LLVM 13 bogusly emits DWARF using C++ constructs for C, = breaking >> CTF entirely, which wasn=E2=80=99t caught until it was built on = non-FreeBSD). >>=20 >> I imagine this just needs no-ctfconvert in files.amd64 for both = VDSOs? >=20 > I have no idea. If you think it is the right fix for your problem, go = ahead? > I doubt that vdso wrapper objects would ever carry anything that = resemble > type info, or that could be useful as the dtrace material. Sure, I have other cross-build changes to push too as the world isn=E2=80=99= t quite unbroken after the libdwarf change (Linux is happy now, but macOS isn=E2=80=99t due to libcrypt not being a thing there... whack-a-mole = continues). > BTW, we have enough .S files that do not generate any dwarf data. Why = is it > not a same problem? I imagine because we list the .S not the resulting .o in files? Jess