From nobody Mon Dec 06 21:28:05 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6F3A918B1BC7; Mon, 6 Dec 2021 21:28:13 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4J7GkP0NZSz3Hqd; Mon, 6 Dec 2021 21:28:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 1B6LS5Vt014724 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 6 Dec 2021 23:28:08 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 1B6LS5Vt014724 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 1B6LS5EA014723; Mon, 6 Dec 2021 23:28:05 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 6 Dec 2021 23:28:05 +0200 From: Konstantin Belousov To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: ab4524b3d7fb - main - amd64: wrap 64bit sigtramp into vdso Message-ID: References: <202112061848.1B6ImIf8065076@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on tom.home X-Rspamd-Queue-Id: 4J7GkP0NZSz3Hqd X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mon, Dec 06, 2021 at 08:51:02PM +0000, Jessica Clarke wrote: > On 6 Dec 2021, at 18:48, Konstantin Belousov wrote: > > > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=ab4524b3d7fba872a143b03c9346cb04c3670efa > > > > commit ab4524b3d7fba872a143b03c9346cb04c3670efa > > Author: Konstantin Belousov > > AuthorDate: 2021-11-05 08:07:24 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2021-12-06 18:46:49 +0000 > > > > amd64: wrap 64bit sigtramp into vdso > > > > Reviewed by: emaste > > Discussed with: jrtc27 > > Tested by: pho > > Sponsored by: The FreeBSD Foundation > > MFC after: 1 month > > Differential revision: https://reviews.freebsd.org/D32960 > > This broke cross-building from non-FreeBSD: > > > ERROR: ctfconvert: elf-vdso.so.o doesn't have type data to convert > > The error message also shows up on FreeBSD, but ctfconvert has a gross > #ifdef __FreeBSD__ hack in it to make it non-fatal (dating right back > to when it was imported), which of course doesn’t work when building on > non-FreeBSD, and is something I’ve wanted to remove from FreeBSD too as > silently allowing broken CTF is a bad idea these days (see AArch64 > where LLVM 13 bogusly emits DWARF using C++ constructs for C, breaking > CTF entirely, which wasn’t caught until it was built on non-FreeBSD). > > I imagine this just needs no-ctfconvert in files.amd64 for both VDSOs? I have no idea. If you think it is the right fix for your problem, go ahead? I doubt that vdso wrapper objects would ever carry anything that resemble type info, or that could be useful as the dtrace material. BTW, we have enough .S files that do not generate any dwarf data. Why is it not a same problem?