From nobody Mon Dec 06 20:51:02 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4641C18D2EB4 for ; Mon, 6 Dec 2021 20:51:10 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J7Fvf1N3Sz4vTn for ; Mon, 6 Dec 2021 20:51:10 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f41.google.com with SMTP id 137so9156256wma.1 for ; Mon, 06 Dec 2021 12:51:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=9Tfj/TC/S/xjfGuGLVQtv3vSGdLcK/907xnrsEqEs5k=; b=PVv/LCBWUjloprEdaHk6oUBbeIDUwhko2HPxZ69DSZb2seAkhoBZrjIanqybOXXe1I BBuBfw5f7hx7/Qn5xP8BdJsVNUPweVU5JNvxt33gh5F0VGoGK1DYwhcNdhY0Aj0dsy0W OhVI3qtPsxL5i4Ibdr30y9bfDxn8LpVNbhGseqMCiHV28QoyapyQYKisdQ5Smpz5wDWv faLNfsgpPApM5WsR1IJ1nVISdO4aeNj7vnI143wFMvq8j9/1FTMmZaB0EaR9OTmZ7vLM 4IrBGATrZRS1ZqbJpbfCoKfZMaDf399Yk+acvwwT8gRGhgUp6ZXZlAu6BU4OYHpj97z3 uu+g== X-Gm-Message-State: AOAM533jHkiPIv0UuLlVn8zwhM7EYXtH9mMQgWA0LpYJnH8uYOqV0RSb KuQI302lNEdUZoJmISZEJslgOw== X-Google-Smtp-Source: ABdhPJxs5OX2qbf8L5CA7rFp6hQpH00vtDpEJA5KxCsPX+FfhItfjoArAjKc0P6GMIHtn3NJ6jOS+Q== X-Received: by 2002:a1c:540c:: with SMTP id i12mr1187980wmb.33.1638823863661; Mon, 06 Dec 2021 12:51:03 -0800 (PST) Received: from smtpclient.apple (global-5-141.nat-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id m125sm403473wmm.39.2021.12.06.12.51.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Dec 2021 12:51:03 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: ab4524b3d7fb - main - amd64: wrap 64bit sigtramp into vdso From: Jessica Clarke In-Reply-To: <202112061848.1B6ImIf8065076@gitrepo.freebsd.org> Date: Mon, 6 Dec 2021 20:51:02 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202112061848.1B6ImIf8065076@gitrepo.freebsd.org> To: Konstantin Belousov X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4J7Fvf1N3Sz4vTn X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 6 Dec 2021, at 18:48, Konstantin Belousov wrote: >=20 > The branch main has been updated by kib: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dab4524b3d7fba872a143b03c9346cb04= c3670efa >=20 > commit ab4524b3d7fba872a143b03c9346cb04c3670efa > Author: Konstantin Belousov > AuthorDate: 2021-11-05 08:07:24 +0000 > Commit: Konstantin Belousov > CommitDate: 2021-12-06 18:46:49 +0000 >=20 > amd64: wrap 64bit sigtramp into vdso >=20 > Reviewed by: emaste > Discussed with: jrtc27 > Tested by: pho > Sponsored by: The FreeBSD Foundation > MFC after: 1 month > Differential revision: https://reviews.freebsd.org/D32960 This broke cross-building from non-FreeBSD: > ERROR: ctfconvert: elf-vdso.so.o doesn't have type data to convert The error message also shows up on FreeBSD, but ctfconvert has a gross #ifdef __FreeBSD__ hack in it to make it non-fatal (dating right back to when it was imported), which of course doesn=E2=80=99t work when = building on non-FreeBSD, and is something I=E2=80=99ve wanted to remove from FreeBSD = too as silently allowing broken CTF is a bad idea these days (see AArch64 where LLVM 13 bogusly emits DWARF using C++ constructs for C, breaking CTF entirely, which wasn=E2=80=99t caught until it was built on = non-FreeBSD). I imagine this just needs no-ctfconvert in files.amd64 for both VDSOs? Jess