From nobody Wed Dec 01 21:09:09 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A5E5118C953B; Wed, 1 Dec 2021 21:09:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J4BXj2TrHz4vnw; Wed, 1 Dec 2021 21:09:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3559310FBD; Wed, 1 Dec 2021 21:09:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1B1L99o6034288; Wed, 1 Dec 2021 21:09:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1B1L99ou034287; Wed, 1 Dec 2021 21:09:09 GMT (envelope-from git) Date: Wed, 1 Dec 2021 21:09:09 GMT Message-Id: <202112012109.1B1L99ou034287@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Vincenzo Maffione Subject: git: d91559564dc6 - main - e1000: remove unused ifp backpointer List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vmaffione X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d91559564dc647846479824340bdf94b7cf98c05 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638392949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lg5GzV/qSLLVb7BNTmkYNtU7a3Zi23OAuNB9euwlZZc=; b=BLcVMqk504ugOs/0RyZSd2tlMkbbgmmqgftvoeyfJfhwmtGow9KhKQ+gwM/42xdB3BKbuO wFGEdnXIAUHg1ca7RhsUQqekXa1Rz2P5aTcomQPIlOIswFeQ2HFdoiW6PM28+1ci/yzTbC Hqv4bOh5/F08M+t9EgA8WMADCMVumfIfWXf7rA8/VSy4l4r/gWBIdzW5/bO+l1gvq2a/SM olt2j8qIc6wvKa1JIEOUFUnHj/eC+Ox3QdAoLqUNZSqT2ziYD61VGRZ+6vmR5FFnYy3/E1 YLvruAvFRlw7spp7R4QpIcJZEtAMij73L4ZhONMa1q/6qyieuy0+Pb0LQpc9NA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638392949; a=rsa-sha256; cv=none; b=WCS6QOCpFh0pV2MpcUB6UB8ltjjxWb502Jcef+WIxBQobSnsAYuWcwcLMBWS41WhHXOmRm Iheo95x2+jZ+h6sK7GHLY/K3EMMqfP+rKJiNPyEQEOxQSIkcFaHcPwPI85GJMKWg7SJEK7 vvAJZNUYXGQ7tk5gvD+C53s1NZqRCrI9gMEEoguq84JhUNP6GXMj72SVouCoF58hVI7ldi D87SJwHINjeyifZ2Tb+ngpsm9ehYLKfbyyEflvqQCwAVVbFUxUAELEIBQ0+tzOwBok7Og/ KkXU1A5BFBkK/MqYM0zDvQqbytk+obdbue4UwBx1npT9C2iOpvf6j1BNRJd8Gg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by vmaffione: URL: https://cgit.FreeBSD.org/src/commit/?id=d91559564dc647846479824340bdf94b7cf98c05 commit d91559564dc647846479824340bdf94b7cf98c05 Author: Vincenzo Maffione AuthorDate: 2021-11-29 21:28:26 +0000 Commit: Vincenzo Maffione CommitDate: 2021-12-01 21:08:31 +0000 e1000: remove unused ifp backpointer The ifp (struct ifnet) backpointer in the e1000 private ifnet data is not used anymore since the iflib transition. Remove it so that developers are not tempted to use it and get a NULL pointer dereference. Reviewed by: markj, kbowling, erj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D33157 --- sys/dev/e1000/if_em.h | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/dev/e1000/if_em.h b/sys/dev/e1000/if_em.h index 33ba22a88552..ed5a88013f5b 100644 --- a/sys/dev/e1000/if_em.h +++ b/sys/dev/e1000/if_em.h @@ -439,7 +439,6 @@ struct em_rx_queue { /* Our softc structure */ struct e1000_softc { - struct ifnet *ifp; struct e1000_hw hw; if_softc_ctx_t shared;