git: 1d8bbe5ba370 - stable/14 - TCP RACK: remove variable with is only initialized and not changed

From: Michael Tuexen <tuexen_at_FreeBSD.org>
Date: Wed, 05 Feb 2025 20:53:05 UTC
The branch stable/14 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=1d8bbe5ba370f909192818d3be9075caa5fb0730

commit 1d8bbe5ba370f909192818d3be9075caa5fb0730
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2025-01-04 20:11:26 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-02-05 09:52:35 +0000

    TCP RACK: remove variable with is only initialized and not changed
    
    minslot is initialized to 0 and never changed. It is not clear to me
    under which condition minslot should be set to which value.
    Therefore, remove it and the code checking that it is not zero.
    No functional change intended.
    
    Reviewed by:            rrs
    CID:                    1523812
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D48321
    
    (cherry picked from commit 84e894ce1309b426aa5d1a20ec194401f35dc478)
---
 sys/netinet/tcp_stacks/rack.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c
index a8542c093f74..c9fd18be1ede 100644
--- a/sys/netinet/tcp_stacks/rack.c
+++ b/sys/netinet/tcp_stacks/rack.c
@@ -17681,7 +17681,6 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str
 {
 	uint64_t srtt;
 	int32_t slot = 0;
-	int32_t minslot = 0;
 	int can_start_hw_pacing = 1;
 	int err;
 	int pace_one;
@@ -18013,11 +18012,6 @@ rack_get_pacing_delay(struct tcp_rack *rack, struct tcpcb *tp, uint32_t len, str
 				}
 			}
 		}
-		if (minslot && (minslot > slot)) {
-			rack_log_pacing_delay_calc(rack, minslot, slot, rack->r_ctl.crte->rate, bw_est, lentim,
-						   98, __LINE__, NULL, 0);
-			slot = minslot;
-		}
 	done_w_hdwr:
 		if (rack_limit_time_with_srtt &&
 		    (rack->use_fixed_rate == 0) &&