git: a60eeb4331e5 - stable/14 - pfctl: fix crash on "pfctl -a '*' -vvsr"

From: Kristof Provost <kp_at_FreeBSD.org>
Date: Mon, 21 Apr 2025 21:15:46 UTC
The branch stable/14 has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=a60eeb4331e5ee63f66e2458a16aae186168923f

commit a60eeb4331e5ee63f66e2458a16aae186168923f
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2025-04-14 16:41:00 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2025-04-21 20:25:46 +0000

    pfctl: fix crash on "pfctl -a '*' -vvsr"
    
    When printing a nat anchor we don't have rule information, or rule
    counters. Do not attempt to print them. The information is nonsensical
    anyway, and this can cause a crash converting the timestamp to a string,
    as years in the very distant future use more digits, and we exceed the
    30 byte buffer allocated for this.
    
    MFC after:      2 weeks
    Sponsored by:   Orange Business Services
    
    (cherry picked from commit 168d873ae41fd8bd40555322a79c9f215cb4cb9c)
---
 sbin/pfctl/pfctl.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sbin/pfctl/pfctl.c b/sbin/pfctl/pfctl.c
index dfc473f21566..ddf450a5d052 100644
--- a/sbin/pfctl/pfctl.c
+++ b/sbin/pfctl/pfctl.c
@@ -1452,7 +1452,6 @@ pfctl_show_nat(int dev, const char *path, int opts, char *anchorname, int depth,
 		}
 		mnr = prs.nr;
 
-		pfctl_print_rule_counters(&rule, opts);
 		for (nr = 0; nr < mnr; ++nr) {
 			prs.nr = nr;
 			if (ioctl(dev, DIOCGETRULESET, &prs))