git: cc1cb8e37646 - stable/14 - smbios: style(9): smbios_cksum()

From: Olivier Certner <olce_at_FreeBSD.org>
Date: Tue, 08 Apr 2025 13:40:57 UTC
The branch stable/14 has been updated by olce:

URL: https://cgit.FreeBSD.org/src/commit/?id=cc1cb8e376464e41dcc2de532552fd7e83695b13

commit cc1cb8e376464e41dcc2de532552fd7e83695b13
Author:     Olivier Certner <olce@FreeBSD.org>
AuthorDate: 2025-03-04 16:29:22 +0000
Commit:     Olivier Certner <olce@FreeBSD.org>
CommitDate: 2025-04-08 13:38:25 +0000

    smbios: style(9): smbios_cksum()
    
    Reduce some variables' lifecycle.  Remove useless casts.  Remove
    superfluous braces.  Add some consts.
    
    MFC after:      2 weeks
    Sponsored by:   The FreeBSD Foundation
    
    (cherry picked from commit ef446a8065ac0228a5da15f233cd2f964e4d7433)
---
 sys/dev/smbios/smbios.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/sys/dev/smbios/smbios.c b/sys/dev/smbios/smbios.c
index 24e110f722d3..b9fd7bd25f11 100644
--- a/sys/dev/smbios/smbios.c
+++ b/sys/dev/smbios/smbios.c
@@ -339,25 +339,24 @@ smbios_eps3 (void *v)
 static int
 smbios_cksum (void *v)
 {
-	struct smbios3_eps *eps3;
-	struct smbios_eps *eps;
-	u_int8_t *ptr;
+	const u_int8_t *ptr;
 	u_int8_t cksum;
 	u_int8_t length;
 	int i;
 
 	if (smbios_eps3(v)) {
-		eps3 = (struct smbios3_eps *)v;
+		const struct smbios3_eps *eps3 = v;
+
 		length = eps3->length;
 	} else {
-		eps = (struct smbios_eps *)v;
+		const struct smbios_eps *eps = v;
+
 		length = eps->length;
 	}
-	ptr = (u_int8_t *)v;
+	ptr = v;
 	cksum = 0;
-	for (i = 0; i < length; i++) {
+	for (i = 0; i < length; i++)
 		cksum += ptr[i];
-	}
 
 	return (cksum);
 }