From nobody Tue Nov 19 00:28:16 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xslhc2xFSz5dGcl; Tue, 19 Nov 2024 00:28:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xslhc1MW2z4gH2; Tue, 19 Nov 2024 00:28:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731976096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PTJ04vcHOG+nxZdBnmH1OUtz8LZAsxp2Pxqc5PiXfVw=; b=J+N4S7fKIBM1Cz6llo2Vohht9vV0IGstzaMI8lB4kIGsy5jP78JOVaqX3V4E6fBQEMpfSD j8jyGG2qPLZ/8OandsVNETc6ILlXl+m57MF9SKErffS/wHVy/aRB+ZGUdKPQPfiSYgMxeh 1KBv5rfcUzftMPFJNgiRQltNRlf0bqjzldH/DWf9SJhz/e1bynsvG5QTEFwtsQmX2lFePD 66qNA9o65QYpgPBcK3LG67k1Ews8hzwD7R9b2g03vw4CV695LqZEAxVMWYwjmnLSVXSPdt w5CBdU29+SdkygiwrNbiIZrsw9KF2LApwwgkAcGbLNAwb20zh+m2WkyjkA6vEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731976096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PTJ04vcHOG+nxZdBnmH1OUtz8LZAsxp2Pxqc5PiXfVw=; b=Na8k0QL6FLcd6dZyzhwmw7r0QtAyQ359/VDSdPzsHgXxVG81BmT6AFwLRch07uJzrXNmNq BOdNRdPOigqHasQjpEqcg7Ls9G7X6rnpqPwBFJdTXox9yDy0BTZzlS05Q/Y52OFpY/iRwr Bfc92Thy1je61LiRHyYlC2JVRX+FIcfdueTcPhEnF4FiYmzNiPDUx4LK5Fv13u/TaCt/c/ vI24ctGZAE9xXUafprh/qsiyjszebCM9bu0ctQ+13vJP03y9yqqx/7hGttJO3uqQBETCng P1Vuto4IGDPTQEqkRxXlo+eHYVErOc0yB9pQBjT/ira4I+v5sOMq+AlJZVb5Rw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1731976096; a=rsa-sha256; cv=none; b=BpdF3fuKIkrLBdihZp0BCgufM2qMOtkgS8vx62VZIId7vbMjWUODCHJ9DSIhFjDanNHd/3 k5XmLUH5FMauz90v0dn2jtO3s7+L+FoCuQ5EcTgXrW1kHZVusV8R/d/gWoMo91MPN9KSGR FC2n09FIvH191yTnZL2FbxHpK+ii6yNgZCsxDQDc44vK2iUND48nxNrxtVBZ3RMwWLOcfM X8TE0kvCcWAJAdVS78s8Mb2Vt1vWl2Hy6AQ/0hJxOLYHyJNB4SLSMetDb5g8Ym+RfDJRhO 02kFDSwgu8hn28IQ/Wz09ZBRM4U3v78PiEWDSvh3LegpMQrTA1G4SRK0jfohFw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xslhc0wj7z12Vj; Tue, 19 Nov 2024 00:28:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4AJ0SGl8064724; Tue, 19 Nov 2024 00:28:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4AJ0SGUC064722; Tue, 19 Nov 2024 00:28:16 GMT (envelope-from git) Date: Tue, 19 Nov 2024 00:28:16 GMT Message-Id: <202411190028.4AJ0SGUC064722@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 7bc49d8b1e49 - stable/13 - ipfilter: Print the hash name when adding a hashnode fails List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 7bc49d8b1e490eba0710923ef149d52418197472 Auto-Submitted: auto-generated The branch stable/13 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=7bc49d8b1e490eba0710923ef149d52418197472 commit 7bc49d8b1e490eba0710923ef149d52418197472 Author: Cy Schubert AuthorDate: 2024-11-07 15:51:12 +0000 Commit: Cy Schubert CommitDate: 2024-11-19 00:27:07 +0000 ipfilter: Print the hash name when adding a hashnode fails As with when printing errors for failed poolnodes, printing the hash node (IP address) only leads to speculation which hash pool the failed add occurred. This is especially useful when the same IP address is listed in multiple hash pools. (cherry picked from commit 8aae4220d76602f22291d7567ba0c61b9aa8c188) --- sbin/ipf/libipf/load_hashnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/ipf/libipf/load_hashnode.c b/sbin/ipf/libipf/load_hashnode.c index 11525dc96e35..bf22edb9be87 100644 --- a/sbin/ipf/libipf/load_hashnode.c +++ b/sbin/ipf/libipf/load_hashnode.c @@ -55,7 +55,7 @@ load_hashnode(int unit, char *name, iphtent_t *node, int ttl, if (!(opts & OPT_DONOTHING)) { char msg[80]; - snprintf(msg, sizeof(msg), "%s node from lookup hash table", what); + snprintf(msg, sizeof(msg), "%s node from lookup hash table(%s)", what, name); return (ipf_perror_fd(pool_fd(), iocfunc, msg)); } return (0);