From nobody Sun Jul 28 19:04:19 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WX9rz6V3Kz5RSTp; Sun, 28 Jul 2024 19:04:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WX9rz5zHkz43nk; Sun, 28 Jul 2024 19:04:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722193459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EgokET+yF1XGboNIRxxaLYoHP5vJj/ZiV/nMBXJcq+0=; b=xOkQzsDKIlNM9pYpR1Q/tUMKQh3fXjuiaarQG03dMi7p3THfJMsg40vn9N+29pArWdLf3T 4MWvwNpg48erVzN7RS64LqbiulHpuQsNDumEYeNSG3Douv4JqBPvcbUnl/xljh4l89lCS6 wDwS0l6ufGIRdTrCe8b/Wb4d3G0nlsX7iYXl8xOlmOiB/0o5iXJ4pUY7bFiSrNCyuWuZyM tPkLci7Bhocj7F/VI9x4ZGS8AqhfY2yjNP2A60Je5byruUBzFFbX2lu8ubuPxst9VOSkr4 b4aTtoOhAELV+Di7rw2VpoMJ9fOhKOPU+tjZis3/NV6LPJQzR8AYeiXOEnp0OQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1722193459; a=rsa-sha256; cv=none; b=a/8cTZ8LmH6itvGf6tkW+hDUENuTsgylLs6jvA/2EAbZTiAKHS2tjP+QZPeaDenSb9yV3X Ik6bJ4w6NeOFV9O5GBukCFK8JVSxltgWOcfsCcTPyThytk0LC5aw3prml+ykqLqU7ljCjC teErOhmVxt8FVMUfB8u3P6bcs6vPIqnV7xFgkSJ01kqGg8I58A3GIMQQr9u5P916hg6qht CLlRvZIOIONaA+R5f9qYbraOzcqcRhSTnjQLehUppo1tTY7qt00xVkhpD/Qc0AF0kG4+OX hEjtUZi+QnOeR1FRKF+QO/H2kzyqbY625szAfUrQmqz9Sd8jSqLWfaihdnIAiA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722193459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EgokET+yF1XGboNIRxxaLYoHP5vJj/ZiV/nMBXJcq+0=; b=BnLgqBZguPw2ih+ROuMxljHPpXFC49xlWhEHTxKKjEFjlEAxCyzq2B8RC5zjew8HlQ/N9Y rXffOTEaY/bbj0pjd8kuM8VXf2le5megq7QzO7Wnz1nFjGFVdV9/ixUsV8/pV9JRp1Vq79 XfxwY/eS5OljQszxnqSAj16pd3ntjh/jWTcOwPynGeUPQZY5xN+554sNc/QuojoJam1g/f Xfbg9n48WMgK5O+jZZ5N1cpAsf2Onkn85BuLJKo3nPGaUlOrSG9CC8uZR8lGIDCwHc83p5 SECCbOcxlF+WxxljzOq4LIayPC6cnVImGvN1Kv9TpFArKrE5WvWmW0HSN7GzfA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WX9rz5YHdz12r5; Sun, 28 Jul 2024 19:04:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 46SJ4JgJ015123; Sun, 28 Jul 2024 19:04:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 46SJ4J84015120; Sun, 28 Jul 2024 19:04:19 GMT (envelope-from git) Date: Sun, 28 Jul 2024 19:04:19 GMT Message-Id: <202407281904.46SJ4J84015120@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kirk McKusick Subject: git: b45276b1693d - stable/14 - Do not allow snapshots on UFS filesystems using gjournal. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mckusick X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: b45276b1693db0f13d6203a8b989fe7ea856dbfb Auto-Submitted: auto-generated The branch stable/14 has been updated by mckusick: URL: https://cgit.FreeBSD.org/src/commit/?id=b45276b1693db0f13d6203a8b989fe7ea856dbfb commit b45276b1693db0f13d6203a8b989fe7ea856dbfb Author: Kirk McKusick AuthorDate: 2024-07-25 06:09:58 +0000 Commit: Kirk McKusick CommitDate: 2024-07-28 19:04:10 +0000 Do not allow snapshots on UFS filesystems using gjournal. PR: 280216 (cherry picked from commit cab41e0dd31d184bdb0d14403ca71a0f6c9a5e83) --- sys/ufs/ffs/ffs_snapshot.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sys/ufs/ffs/ffs_snapshot.c b/sys/ufs/ffs/ffs_snapshot.c index 7e8c4dbb17d1..fedac50e38fb 100644 --- a/sys/ufs/ffs/ffs_snapshot.c +++ b/sys/ufs/ffs/ffs_snapshot.c @@ -224,6 +224,15 @@ ffs_snapshot(struct mount *mp, char *snapfile) ump = VFSTOUFS(mp); fs = ump->um_fs; sn = NULL; + /* + * At the moment, filesystems using gjournal cannot support + * taking snapshots. + */ + if ((mp->mnt_flag & MNT_GJOURNAL) != 0) { + vfs_mount_error(mp, "%s: Snapshots are not yet supported when " + "using gjournal", fs->fs_fsmnt); + return (EOPNOTSUPP); + } MNT_ILOCK(mp); flag = mp->mnt_flag; MNT_IUNLOCK(mp);