From nobody Tue Jan 30 17:55:21 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TPXrT6RnXz59Ggw; Tue, 30 Jan 2024 17:55:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TPXrT5wzVz4N3W; Tue, 30 Jan 2024 17:55:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706637321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ay8g1isjJSSLdLQUvvBBofwNSN2zIKKnipFREjiMdb8=; b=u+Z/WT6TFxMWDwLlzT2MeeVgbXZasxZ1dkvODM9eqGRBiYrEZVzvuBwMxbUapybFDBsVSB 7KKqYLx7abyIm2Eu6YMRkShHZFwxfl8ynrasxsGPDgAY0QT+ytZGDqVKDeFDEG3HEzAJNM WjwMucjXNaAhF5U5p3LodIvyWz0oCHcIIi+vEorHhJqoAI2LiSLOK1FtKBTadqsxidoerz o09VVK2IOBbmMC8F7poZ7h/3KbrrBrq92A3ngSm5zCYUAwsNGe7rUDECC9AQk4s8qhKWkc rDcloKt3xAezheawhlqxvD3LZvDiu88wzZVNCti/hCrRZv9x78tl6OnoqxqPEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706637321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ay8g1isjJSSLdLQUvvBBofwNSN2zIKKnipFREjiMdb8=; b=quqS6bx2ugPQko4RMi3vH90YN0URkCy22xrxGRPEN/aGDtR95O0cEHUV9N8ojG4m/eC61n 4i9DgZna/8pSS2+E58bAnobKFRI1e5Rpro6xF9fBC4LU1RhiW+QCiXTaaOnVGorCp8tjjF vm0MmuhXZzH09GfpZxD50xnkLlFacFHpxFB+rOjj9Os8+WG/VOzIt268XcZdbX9M/DD+G4 Pjgqsh4AxXulYwbX29+YRVM9iMT9xRuZaRz07LSlG8LNPWEgxnPVhL48L0xZsUwjLdwoog e6VqhOTzzMzYXG66d7wplihiPbqNQJUuWrsWdYurrAXY4Ps/lfXBTcY3VbBdHA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706637321; a=rsa-sha256; cv=none; b=eI74pd6tLGxV228ukcLWLWTeKvShWQ/+rRauC9vJOdDkLGnHnzRxhWgGGSnNHYm1GqOf95 bTrdFQgv4pXkvj1psI2gZKyw32oLffd1ZBKSQ54qgWGSLCOAc0bKiB2g8mr4j1azJfNbHl 8GFSSBOS5Mv2G2jM8bJMsCt2GAihD+CkD/e+iE+lqG0a6q7H9OHIqvoTRyX/EEYcnaqpXZ O/Ae4OqsBYnfAww4sgUySFlEcz8BTrIHBegAZHmHYu0x/58d4tBYcSYHkFhX0jJBmxpynO VYpBkMChuHbm3jEtuWpvvlh4t8xfGtBSP3PKQr1pGsMulcT2fF4hcgN6t7T/FA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TPXrT52TGzldR; Tue, 30 Jan 2024 17:55:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40UHtLKD066764; Tue, 30 Jan 2024 17:55:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40UHtLEQ066761; Tue, 30 Jan 2024 17:55:21 GMT (envelope-from git) Date: Tue, 30 Jan 2024 17:55:21 GMT Message-Id: <202401301755.40UHtLEQ066761@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 869cfe9fedd7 - stable/13 - msun: remove fabs from Symbol.map, and adjust comment List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 869cfe9fedd77d676dec565ffb2cbe1e5c5e5d5d Auto-Submitted: auto-generated The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=869cfe9fedd77d676dec565ffb2cbe1e5c5e5d5d commit 869cfe9fedd77d676dec565ffb2cbe1e5c5e5d5d Author: Dimitry Andric AuthorDate: 2024-01-27 21:24:38 +0000 Commit: Dimitry Andric CommitDate: 2024-01-30 17:53:47 +0000 msun: remove fabs from Symbol.map, and adjust comment We have s_fabs.c, but fabs(3) is already provided by libc due to historical reasons, so it is not compiled into libm. When the linker does not use --undefined-version, this leads to a complaint about the symbol being nonexistent, so remove it from Symbol.map. While here, adjust the comment about some functions being supplied by libc: while it is true that all these are indeed in libc, libm still includes its own versions of frexp(3), isnan(3), isnanf(3), and isnanl(3). Reported by: Steve Kargl MFC after: 3 days (cherry picked from commit d04e03c19a8d7660ea36f62720eef9bc96b69889) --- lib/msun/Makefile | 3 ++- lib/msun/Symbol.map | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/msun/Makefile b/lib/msun/Makefile index 8bc984c2c342..03146bd39463 100644 --- a/lib/msun/Makefile +++ b/lib/msun/Makefile @@ -146,7 +146,8 @@ COMMON_SRCS+= catrig.c catrigf.c \ s_cproj.c s_cprojf.c s_creal.c s_crealf.c s_creall.c \ s_csinh.c s_csinhf.c s_ctanh.c s_ctanhf.c -# FreeBSD's C library supplies these functions: +# FreeBSD's C library supplies these functions (but note we still have s_frexp.c +# and s_isnan.c enabled above, so they are duplicated): #COMMON_SRCS+= s_fabs.c s_frexp.c s_isnan.c s_ldexp.c s_modf.c # Exclude the generic versions of what we provide in the MD area. diff --git a/lib/msun/Symbol.map b/lib/msun/Symbol.map index 6e74918ade6e..4d5a5e4d7e6e 100644 --- a/lib/msun/Symbol.map +++ b/lib/msun/Symbol.map @@ -88,7 +88,6 @@ FBSD_1.0 { exp2f; expm1; expm1f; - fabs; fabsf; fabsl; fdim;