From nobody Sun Jan 28 09:02:37 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TN56j6j5pz589hM; Sun, 28 Jan 2024 09:02:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TN56j5zRzz4Tr0; Sun, 28 Jan 2024 09:02:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706432557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2fbfEocRNzrxAHcT3ZyGugohyMoVUkd145Sh78d8lmg=; b=YZ+tjnAyZ+r5VojVs902NeWZAHX7lGzhn15Oxf/gdWf7B0EQkRDGWljWfGSuKiF0Y9liOx 2bnmg0jZRAFSUz5A89VLok6RilLYb9SVTGePnXk0vGvMPlBsRFk7KFzYrMoNrSmDdbx5ES wegqD4egv86lLce62fkoMGr6UZ56r05D7ACe0d75L9B2WYZg0oJZhspluKu+ca8gFRGoAG DqeZ/UPqe5bDO1nOnSR02DoWEtRMA8ZMp5ax/vs4sFCzBE+LrWMLKnvXsxS2WJxgHPH3I0 H5Bj4OWJW//BNaLI6OIj0Mu8I1Lde4hWr45AvcI028ZUiTc5/2SauhbyUPuMGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706432557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2fbfEocRNzrxAHcT3ZyGugohyMoVUkd145Sh78d8lmg=; b=mFO6bW2AShghAukuzpHqSmAa+cx7+caYCtNOBpsLpZh4lHupTSeNC8uvK5BjM7ujP37NNM V7I1m81+B6rF1xxhDI1WezA+EVTyK7x5xdqxWwTOTg4QY0Ez5J0GEQkxqBMBsHSPZnaFwP pV9r2dxYnfg71dFTOxJoqB9i77wBWjr5buzIzkpqUrU/CTyrUrnW0eXgjI2joLAd0lCFF3 FxcPDU2hMmv9odtVoMRKPWlEbMhZ93jnpqEghNEvupGUTY6QUaMbhegKtoTyOms77YyuXs +aRXmeNelTuLLvoad1Hvcz6+3ZYM1/ogBowcky5V2vhrJuy/Zr7xedU1LW5AlA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706432557; a=rsa-sha256; cv=none; b=IVf0Oe5lQygSf2y89ePTeTM1JHvnisgqtBIHBSgN/fhBIc3opWm6XxOZtS7Vkp3mNqeAS/ CHMVlcigJjpoGwSzv32+W3Zg5BnY6ncMY6KSJBUK5QzMbCOqWuo372qVev0p0t6GM6Tbyh p4Rj+EqSy/LxiB45YZkdysvzs3qMXSyJ+I57sU/1tfmmS2KwH490usAF/RQ8upGQ0EOsD3 RnGBgONFpzYtcsPvF9Spperj6frEHLfq99wsycqCI4P9KpAIOssRXmeo86oG9Msjplmvhv J+P1t7+/1dDUYblaoeXFvIN0wFiAcQEktfKvH7zjCbdmluGBbEjMLc9gFsk/lg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TN56j53S9z11HR; Sun, 28 Jan 2024 09:02:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40S92bkJ018155; Sun, 28 Jan 2024 09:02:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40S92bXq018152; Sun, 28 Jan 2024 09:02:37 GMT (envelope-from git) Date: Sun, 28 Jan 2024 09:02:37 GMT Message-Id: <202401280902.40S92bXq018152@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Peter Grehan Subject: git: 2ee407b6068a - stable/14 - Fix issue with Linux guest XHCI tablet probing. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: grehan X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2ee407b6068a994bba45597c995c5ea76eec9cf3 Auto-Submitted: auto-generated The branch stable/14 has been updated by grehan: URL: https://cgit.FreeBSD.org/src/commit/?id=2ee407b6068a994bba45597c995c5ea76eec9cf3 commit 2ee407b6068a994bba45597c995c5ea76eec9cf3 Author: Peter Grehan AuthorDate: 2024-01-14 11:27:12 +0000 Commit: Peter Grehan CommitDate: 2024-01-28 09:01:49 +0000 Fix issue with Linux guest XHCI tablet probing. The USB3 spec mandates that the device-descriptor max packet size be 512 bytes, which requires a field size of 9 since it is a power-of-2. Linux kernels recently started validating this field, resulting in the table not being probed and the cursor not working in bhyve VNC. PR: 275760 (cherry picked from commit 0c243cd4a3671bf728f33378ac593c08d8367bc2) --- usr.sbin/bhyve/usb_mouse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/usb_mouse.c b/usr.sbin/bhyve/usb_mouse.c index 80f79980a98e..a37941c0cd9d 100644 --- a/usr.sbin/bhyve/usb_mouse.c +++ b/usr.sbin/bhyve/usb_mouse.c @@ -154,7 +154,7 @@ static struct usb_device_descriptor umouse_dev_desc = { .bLength = sizeof(umouse_dev_desc), .bDescriptorType = UDESC_DEVICE, MSETW(.bcdUSB, UD_USB_3_0), - .bMaxPacketSize = 8, /* max packet size */ + .bMaxPacketSize = 9, /* max pkt size, 2^9 = 512 */ MSETW(.idVendor, 0xFB5D), /* vendor */ MSETW(.idProduct, 0x0001), /* product */ MSETW(.bcdDevice, 0), /* device version */