From nobody Wed Jan 03 17:50:00 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T4y0m3k47z56MVc; Wed, 3 Jan 2024 17:50:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T4y0m3CjRz4rXq; Wed, 3 Jan 2024 17:50:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704304200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KAh8FfvlHfsHR2I9UhWyL1ViDBSCaCLv19/dGMV0+Zw=; b=XYDAi2Yx0yQsgdERFXeEXMB+loYBKpoUYUHePPdvo/cyqrJ/MHsoB9ei2TKGhnwPR94K8B H3QUpSTdaRKon3N9/FkPy9ATlHrWlpmt3FR5oLnrBRfXgzINd1VoxJ9gu1JyOTMNmPz4PT CjoXuifVxkqEFasqOw5h/EKGN63qigH8KDLfBNse28SIIjYAXWSFsTT/8k129zQLHLd3bH 9gqpRDZ7T/YAktewgQ3SGqgEE7FglbY9Qi8OdBzY7mU+loFLdFAF2kuISJMch+JfKI9OCr 3Qy4T0SFO7AakrrderzJFco1BvaOs3dKEeTfLFYV8o4uv9Jw/lsqk1zkPmPpeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704304200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KAh8FfvlHfsHR2I9UhWyL1ViDBSCaCLv19/dGMV0+Zw=; b=aIEKXQl5oQb1LgboknUquoDAb/EboItR7Y5l/KFmNXHf7qFUv0vs0R64vyrJUjvBQC7tTj s7VHWsmmOJHEzLlukl9lLMu7Qh9SFwlRVDU4siBl3w68fFbiyxaXZZuIBokfdIvy23ogiU 44AWPZYrP0UTrkk2IM5XIdEgN0gCIOrhC/Mx0W0GquhmY9d/kfkTJF6SeJ+KDpVQTric8A SA4UO3Up5+l3T/2HRP3uF4GYshwTIZfletTuA5sMW1p6Iaq/06s5lXwjgwRns+NcS+tGeO NEwPakemHFIVKXdA/geHR3LhQEazP3mGzmVELvWuSTwR2Bsqk/oBX9a6CFCtMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704304200; a=rsa-sha256; cv=none; b=XdTrWKq+lKuGPpDNYR2sqOTkAKnvkkSTl0FgqzxLzX1dkFasRm+WpFyA4Xe9RlZ6bqU9mS WBEjz93YqfMMZk2Lt21dDuSxi5I9sQddqUB9S9MhJlw8amuooImTLUlFrOYQKfmZY5Hffz OyHY4t4NOTIWIyWtSgIDEUuACgVqSuy0qE0Jliu09bS3+T/fIQKZsJToU3vGBV8XedK0yv soHaxr77KKxkphR0Rq+vD04jsskACT0gbV2IxZJ2oO86sOi/YsJy5nrBM7bJfcn9Gw28Ky fGORmKODrpteSf6LtYMMByx6RZL7gJvwuGaWrYA2CFuE8itdoaFfB924J+Rdxw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T4y0m22XhztvL; Wed, 3 Jan 2024 17:50:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 403Ho0G8034851; Wed, 3 Jan 2024 17:50:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 403Ho0bV034836; Wed, 3 Jan 2024 17:50:00 GMT (envelope-from git) Date: Wed, 3 Jan 2024 17:50:00 GMT Message-Id: <202401031750.403Ho0bV034836@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 1dcd99610434 - stable/14 - libcasper: Neuter false positive -Wuse-after-free warnings from GCC 13 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1dcd9961043444b1a8a14c4fd36826e454fae0c5 Auto-Submitted: auto-generated The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=1dcd9961043444b1a8a14c4fd36826e454fae0c5 commit 1dcd9961043444b1a8a14c4fd36826e454fae0c5 Author: John Baldwin AuthorDate: 2023-11-15 02:34:01 +0000 Commit: John Baldwin CommitDate: 2024-01-03 17:43:47 +0000 libcasper: Neuter false positive -Wuse-after-free warnings from GCC 13 GCC 13 incorrectly thinks a call to free after a failed realloc is a use after free. lib/libcasper/services/cap_grp/cap_grp.c: In function 'group_resize': lib/libcasper/services/cap_grp/cap_grp.c:65:17: error: pointer 'buf' may be used after 'realloc' [-Werror=use-after-free] 65 | free(buf); | ^~~~~~~~~ lib/libcasper/services/cap_grp/cap_grp.c:63:19: note: call to 'realloc' here 63 | gbuffer = realloc(buf, gbufsize); | ^~~~~~~~~~~~~~~~~~~~~~ Reviewed by: imp, emaste Differential Revision: https://reviews.freebsd.org/D42576 (cherry picked from commit b7f7cc25c01aeacaafb86ebcffdeb258b7933b08) --- lib/libcasper/services/cap_grp/Makefile | 3 +++ lib/libcasper/services/cap_netdb/Makefile | 3 +++ lib/libcasper/services/cap_pwd/Makefile | 3 +++ 3 files changed, 9 insertions(+) diff --git a/lib/libcasper/services/cap_grp/Makefile b/lib/libcasper/services/cap_grp/Makefile index b46f3bfdaa47..0f722e3979f9 100644 --- a/lib/libcasper/services/cap_grp/Makefile +++ b/lib/libcasper/services/cap_grp/Makefile @@ -40,3 +40,6 @@ MLINKS+=cap_grp.3 cap_grp_limit_fields.3 MLINKS+=cap_grp.3 cap_grp_limit_groups.3 .include + +# GCC 13 complains incorrectly about free after failed realloc: GCC bug #110501 +CFLAGS.cap_grp.c+= ${NO_WUSE_AFTER_FREE} diff --git a/lib/libcasper/services/cap_netdb/Makefile b/lib/libcasper/services/cap_netdb/Makefile index 36c57103b414..653aa21c9b32 100644 --- a/lib/libcasper/services/cap_netdb/Makefile +++ b/lib/libcasper/services/cap_netdb/Makefile @@ -29,3 +29,6 @@ MLINKS+=cap_netdb.3 libcap_netdb.3 MLINKS+=cap_netdb.3 cap_getprotobyname.3 .include + +# GCC 13 complains incorrectly about free after failed realloc: GCC bug #110501 +CFLAGS.cap_netdb.c+= ${NO_WUSE_AFTER_FREE} diff --git a/lib/libcasper/services/cap_pwd/Makefile b/lib/libcasper/services/cap_pwd/Makefile index be6b4b21070f..4e0e6db6f86d 100644 --- a/lib/libcasper/services/cap_pwd/Makefile +++ b/lib/libcasper/services/cap_pwd/Makefile @@ -40,3 +40,6 @@ MLINKS+=cap_pwd.3 cap_pwd_limit_fields.3 MLINKS+=cap_pwd.3 cap_pwd_limit_users.3 .include + +# GCC 13 complains incorrectly about free after failed realloc: GCC bug #110501 +CFLAGS.cap_pwd.c+= ${NO_WUSE_AFTER_FREE}