From nobody Wed Feb 21 20:26:02 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tg78B675Zz5BJ5P; Wed, 21 Feb 2024 20:26:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tg78B5gSyz4Ck5; Wed, 21 Feb 2024 20:26:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708547162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fPJN8VZN0EHFOH5wzRub/UaaE+DMxnr8pDVsjS3zyow=; b=bNaumxq7HGm4RW28a/BFvXrOCsR4TWOYdQGYQG6ir0vrZeOxkfv6ipcxns1eF6RLLTDLsh Kn7Wk89OD6URUUiCnbfFEju9rZROsr1arBYkabQYy5FQAZpq4t4lDNcXzhFIrC5obslqdK Ui/8wr1ZVAXahR8SbKVZgec3Motg3QTkgplOHwsTPpuq/WxYOLahnNIiDTDQKrdH7qaclg gx4zbNpLcjyHLvqU0a/tka2+7oKR0bvsEz3C6zQy64lPFAm63NEUdeuYE72PP9pmorpGBf CLYmC5aA4Jb+nuVd/SvnisorSQuJa1VdLbaMcOk8gLF9B7QIDBWzMwF5/MMuvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708547162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fPJN8VZN0EHFOH5wzRub/UaaE+DMxnr8pDVsjS3zyow=; b=Uz/N6pOqc0RxHWWHiPXNwr8uwbLKtokRwlqcMpTBlIvL6NitlqKCq8wM9m8YYn4sX1UxD9 7EgeEHmirlXNAk9ZlRZLXvuLijEMIE8eqmH97JFVDOpCF6XDUsH++eUkhTP/Ssbhk5zoCO dCQz4NJTrIwNt3IIo/KQLBKCKdjmFqkJqLOICOVFSiWg5XKZ7IaK2oaHvKBNscXgYrq1Wj iXW0gakrcua2wG0QLwbC0c1hfbPACvymrgDJVnOzLlm71ZRv04a9BDeVToISpGOmdEiJ4z Twr+Ar/Kd+uc9HfQDnI9piJjHb695Jldqn8ZscJwqBrV4WafO4dvGCUG/thfXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708547162; a=rsa-sha256; cv=none; b=wIhZ/GNZpi6ZmXQgv9AvJW5XGmuaOQfTk6WSrpBs7arm1usS7XccLqAqs3tonkwjSs8NrL dR4VzPu3TSYS1iWX7MAI48ohrA5xKK2CYYBo7B0t3NmxTz4PPscVnc28O4f/FXh9V0ijZi l96r9P/QrfLIrW1yDoUxiT+XSsb/+12SkCN+UZXKuo/78tpWzA3hlPPYE0xe1LXjoRIfN6 kJNwA4BaIaUZr6VE7HWORTdHzmdjfrlboGv0zCP5ZwQHrWL9Bv56fHwfOaGMCtp/VvSUPu qQ1/XeqEQhCZg/2X3NPJQpaPjso6jvxULn5FkVh6qJsFutSh8/HXkZUre0vxww== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tg78B4Z1rz1H8x; Wed, 21 Feb 2024 20:26:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41LKQ2HJ086115; Wed, 21 Feb 2024 20:26:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41LKQ2Ow086112; Wed, 21 Feb 2024 20:26:02 GMT (envelope-from git) Date: Wed, 21 Feb 2024 20:26:02 GMT Message-Id: <202402212026.41LKQ2Ow086112@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: bec5e729ceef - stable/12 - heimdal: Fix NULL deref List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: bec5e729ceef12259609dbd8f5191e19464be95d Auto-Submitted: auto-generated The branch stable/12 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=bec5e729ceef12259609dbd8f5191e19464be95d commit bec5e729ceef12259609dbd8f5191e19464be95d Author: Cy Schubert AuthorDate: 2024-02-15 15:41:07 +0000 Commit: Ed Maste CommitDate: 2024-02-21 20:24:16 +0000 heimdal: Fix NULL deref A flawed logical condition allows a malicious actor to remotely trigger a NULL pointer dereference using a crafted negTokenInit token. Upstream notes: Reported to Heimdal by Michał Kępień . From the report: Acknowledgement --------------- This flaw was found while working on addressing ZDI-CAN-12302: ISC BIND TKEY Query Heap-based Buffer Overflow Remote Code Execution Vulnerability, which was reported to ISC by Trend Micro's Zero Day Security: CVE-2022-3116 Obtained from: upstream 7a19658c1 (cherry picked from commit fc773115fa2dbb6c01377f2ed47dabf79a4e361a) (cherry picked from commit 6b421e431a2de6eb9e8bd670efffe76e6617d520) --- crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c b/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c index b60dc19ad8e3..48542f06fcbe 100644 --- a/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c +++ b/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c @@ -605,7 +605,7 @@ acceptor_start * If opportunistic token failed, lets try the other mechs. */ - if (!first_ok && ni->mechToken != NULL) { + if (!first_ok) { size_t j; preferred_mech_type = GSS_C_NO_OID;