From nobody Sat Feb 17 19:22:43 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tcdwz4XjJz53xgF; Sat, 17 Feb 2024 19:22:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tcdwz26LLz4G3g; Sat, 17 Feb 2024 19:22:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708197763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6UNvMRc4c6XslDBGTDvUirNs4lonWMvMGJJ+03uFPtY=; b=TWtBdzItJQEx+uMq/fchSPRjaqoS2KlHYLI0pnZ5Lv/L518SayF5l0uRvs2GO36ViB680e 8dBE2ouKqiBEc+BTVOtyfC4AnRmcEUjh6rS3yaSlP50EOcmCasjAwITldauzRqG2qErbZY RJXLAjA2BWHRbTHh0nJ2xcRW243ZKl4oextUbTKwJLxcy0Ye7P/aunEQy1asFuv/O3ccT9 O2CPSFrEwccTCCbUPH6Kj9AfUks5ykk02iDSC+FSzxTlRyW12jcPtpPbJB7XdJUYuglGW5 0/6nwYggP2rCFTcfaI79I+f+/z6JvxavyUgtFirrePAfmGSpkleeCmFDlkoejg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708197763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6UNvMRc4c6XslDBGTDvUirNs4lonWMvMGJJ+03uFPtY=; b=uVeksto+PfCbzl5vxXqXVur5ZflpOoy2+T6lV6ZKZNwRthRiKGXgGPv8RDTBxaUli7QPNq zJW9Ym8VzC+ZAmOqGVTZPqONm2mgiQYWpwB6WmwEHPkcmueb4ihhF+wRcLcjmzFqbCFrzj dFiDe9Pl4vtUArZ2nEgjOCARRsW6hyGtB63Zl9vK2wNBfdskGyJlyu3H8YBvPU5YgDox0w aWVAw82DEPbYEC+/DTJRj7SVz7UI7/TgkUURI70cHvgJfGzmNNvMdNGIttLEQmkpRYoPkp qb5eL5UG1KnxJcZLJf0CF4wVNoiVpNQNQuW5rGdA6T0eHrGf2ggCXAbx3J4S4Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708197763; a=rsa-sha256; cv=none; b=fEeIT5Z/wvgxAzlopgS1nPVp27zyzpM/5hqrfPHcUMGuRcDgHejv3716txwK0wICgo9di6 DR7higqImqPcIPTrGj6SQHRmIpIClWa7X1IGWcqdsEBNDs3XlwL9coepK3kGS8Y/nVUNs1 fVxmKhPfXZHGcw8wAeZ5EQZzXBvc3R6cxPXL3uVWrrVYxWBIGeqVOAh5kQUq/ugkt4Tm+u y1ac/d2BpP+QaDBg5hL7oq+WN4u7lCyW7Dn0b6KiJt3pK6zCZMgcjAIqnoasXI7y3gxuLf zoSj8egloceYDZmqRmqeatVKSNBnoOS7sqvMjjGJtE//iYQsC59XOJ0VKxaXWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tcdwz1DLSzLJ1; Sat, 17 Feb 2024 19:22:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41HJMhXK000843; Sat, 17 Feb 2024 19:22:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41HJMhfu000840; Sat, 17 Feb 2024 19:22:43 GMT (envelope-from git) Date: Sat, 17 Feb 2024 19:22:43 GMT Message-Id: <202402171922.41HJMhfu000840@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andriy Gapon Subject: git: a669851b3516 - stable/13 - subr_bus: report DEVICE_SUSPEND failures List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: a669851b35163a849ebcbae0c9c8048f86efde10 Auto-Submitted: auto-generated The branch stable/13 has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=a669851b35163a849ebcbae0c9c8048f86efde10 commit a669851b35163a849ebcbae0c9c8048f86efde10 Author: Andriy Gapon AuthorDate: 2023-01-03 08:39:32 +0000 Commit: Andriy Gapon CommitDate: 2024-02-17 19:22:08 +0000 subr_bus: report DEVICE_SUSPEND failures This greatly aids with diagnosing system suspend failures when they are due to a device driver or hardware. (cherry picked from commit 4d1161f094dd90428847f7e5989767e9957055f4) --- sys/kern/subr_bus.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/kern/subr_bus.c b/sys/kern/subr_bus.c index 8abf7fa83750..d34bcc3cca58 100644 --- a/sys/kern/subr_bus.c +++ b/sys/kern/subr_bus.c @@ -3881,8 +3881,12 @@ bus_generic_suspend_child(device_t dev, device_t child) error = DEVICE_SUSPEND(child); - if (error == 0) + if (error == 0) { child->flags |= DF_SUSPENDED; + } else { + printf("DEVICE_SUSPEND(%s) failed: %d\n", + device_get_nameunit(child), error); + } return (error); }