From nobody Thu Aug 08 04:35:38 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WfZ402trtz5SMJM; Thu, 08 Aug 2024 04:36:00 +0000 (UTC) (envelope-from scf@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WfZ4029bdz4SC3; Thu, 8 Aug 2024 04:36:00 +0000 (UTC) (envelope-from scf@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723091760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8QLDeuuOC3PrYdKUw1ap6B4UvleW2X8JGxRxcZHwO5Y=; b=KS3KI/QvPLG7kNnFpjf6AOqWtUUNkj/vtXM8B1Lvw8UppGcaqINZb77GfmH68XbAsZZ1AX BMxXJDY+4NlvP10w0v2+yceT73wUbdclyJykjS4mPEC8aHTMhNN8/3TCKQroxUnVA7Kzmc jaKqWgm52KKmmY7mPgbekt3wK040r3/AvUeqGcs1vv969vOTEZHVrUbx4gCjvIvyrAmv4U TFKZIUs3VTsRw5YngQhKQWlO+8+REQNfQ1AMKA3DMqSeeKBlWhv7GZ623Q/XZsYYrXWBC0 2aQkHHfxx/NQnEZax3h5lcy8ZuCS/6szorQwgsV1eOxZBBlgqtW0vzvn6OKmBA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723091760; a=rsa-sha256; cv=none; b=wRdbZzWd9VzYxoHH6KWhdExDiYxvfi/aBiRu+N6MveTpvcL/eoMaB6tQpGy2+mE/oQNOqa EhW0gfSs7CSp7slGiaAxSsj6Na3b6g/6nfGY1EJKGNbnB32Ky+ImGGR8AMlT8cTgp5EPUi iIjBdEMe0XD+kfTYcPZq+40BLgWSoum27SZ8Rdz83NDZ6Ui9RpjMhkdWIPv3H2BV8h3ib7 pFk49Yb/sWbRClrrP5AnB4FKD2O7V8obtH6fXFwE60pO8adgvUuHxUNgluvdsxuPygCkdS r+kj/zlb0QZzW5wMI+Gwf1lBWBNwdtSAgAU9AyS+jw9HXPwj0CmWYH3OBaIiNg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723091760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8QLDeuuOC3PrYdKUw1ap6B4UvleW2X8JGxRxcZHwO5Y=; b=lx4TkiEpohE09ZoSVtWfyMdDHvDhD8Yhw0OgQOxbdEfByXjowTy0LuA5RH9L3NA3CHnfaP T5HjMwOKSElqpCW77jSr+m0yToYx8+2v8OBbCVSemh+ZrRAknkCkzDb81rbFBG7Z2zYZvI F29c4Bno8zoYXl0qcZglqzK3f5uM0D1VgkrPTyHtZmoEz3IFuZuEhGhuU2eKG6BMyszjOw v/z98Grl0FpjngNIZtm4wJ+liiWUYyfduBoj2Sduq4fG7fQ15gkctxJACrREB80EfOQ8Iv KBNNIbH31aBLEH7t/NvHIGSppeX4ho/zV5i38Ap6Zh4XufMtTRQiE02caWWaVA== Received: from thor.farley.org (1609341-v107.1360-static.crmlinaa.metronetinc.net [104.254.222.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: scf/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WfZ3z73JVz11dp; Thu, 8 Aug 2024 04:35:59 +0000 (UTC) (envelope-from scf@FreeBSD.org) Date: Thu, 8 Aug 2024 00:35:38 -0400 (EDT) From: "Sean C. Farley" To: Ed Maste cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: Re: git: fc43a1b6842a - stable/14 - tzsetup: symlink /etc/localtime instead of copying In-Reply-To: <202408011538.471FcJDS026885@gitrepo.freebsd.org> Message-ID: <784ce21d-a604-bb91-c52e-29c78e2bb6e4@FreeBSD.org> References: <202408011538.471FcJDS026885@gitrepo.freebsd.org> List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII On Thu, 1 Aug 2024, Ed Maste wrote: > The branch stable/14 has been updated by emaste: > > URL: https://cgit.FreeBSD.org/src/commit/?id=fc43a1b6842afa806dfd7ba48de5bece63d04456 > > commit fc43a1b6842afa806dfd7ba48de5bece63d04456 > Author: Ed Maste > AuthorDate: 2022-10-14 16:44:35 +0000 > Commit: Ed Maste > CommitDate: 2024-08-01 15:11:45 +0000 > > tzsetup: symlink /etc/localtime instead of copying > > Using a symlink means that new timezone data (installed by an errata > update, say) will be usable without having to be copied again. > > Reviewed by: bapt, kevans, philip > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D37005 > > (cherry picked from commit 5e16809c953f4cd19fadb1767469dec319de0353) I ran across an issue with this when using "etcupdate -D" to update a jail from the host. "tzsetup -r -C /tmp/chroot", as called by etcupdate, prepends the path of the chroot to the link which breaks things inside the jail. For example, if you run the following: mkdir -p /tmp/chroot/etc mkdir -p /tmp/chroot/usr/share mkdir -p /tmp/chroot/var/db ln -s /usr/share/misc /tmp/chroot/usr/share/misc ln -s /usr/share/zoneinfo /tmp/chroot/usr/share/zoneinfo cp /var/db/zoneinfo /tmp/chroot/var/db/. tzsetup -C /tmp/chroot -r The result will be the following: /tmp/chroot/etc/localtime@ -> /tmp/chroot//usr/share/zoneinfo/America/Indiana/Indianapolis Sean -- scf@FreeBSD.org