From nobody Thu Aug 01 20:32:44 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WZgd90lHwz5RPsb; Thu, 01 Aug 2024 20:32:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WZgd873Njz4Kf4; Thu, 1 Aug 2024 20:32:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722544365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uFMT6dzHJOSrrm/OWMNzfCdSmuFxcnNN9shIkTeoT60=; b=GOeOAhnkVKng6QGRX8lmmGjfyna6hfqmKmOC4yJtf2WAV5TCwURPPeRsthqE6LfB49n1hb xUJwEUIYkMxY7AJZhtmv/95ijqblk2uqKyEUearjDMrI5WltyWva81X5ZCe2g2Oo+OvhOc KNvRSQWNsPnYhnBi5Uo6m2HIUk97a1npK72Jfyt65jCE4guy7zeSDynAzzJObbR/lBN54F d2YLEGr7ikuLeIglf2h/3EsliZIrgPhI8b8Tw+xH5gBrL3Tu8+Sd/F2ucpXxoirQkZM700 U0coiJmJZKAKbdeLk8JHzLlSVBWAA9iDwEIzhW9XpG5qp/kYNXX9OU3+nCdPFA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1722544365; a=rsa-sha256; cv=none; b=sLZezbuozQAjAkJUOAMfzWb47vL4SPB37w2T12wn3bO8jyXb8EJQ5JLDPa3b7Aw9snGP0h ZBEhcy++wHurL3M5sbqDNiBHy1bSHPUhtXexU6FvwfySkgT6RBvle4gZjnTGjpelwdfbxI lDtkjGGt+BtcooNjQ8dG+AKIx2X4EcJASUH49MEBVZxFmb11OZfj3rGNh8C2f7fY2A1o5/ 4yBPWS4P9IwF9SNDLkCS8koDdjsvBdNoiNRzvN2y1HOz0+W6UhVQLeyQtf2A3KWCeSuzsw Q91SPBIOmpngTKAyZ9TcNzDUmyd7z7JdXaStpUvDopdq8Y6JC35U/NmXtW+szQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722544365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uFMT6dzHJOSrrm/OWMNzfCdSmuFxcnNN9shIkTeoT60=; b=Qp98zzl56Ja+Qi0nxVb7H3Viz3146fiuSqqA5Kj1k35CcVbp5t6OAKu30Mp5O5Mz2Vw1I6 OKa8TshVlzJeCbtVRcKTWvEXmVp5wR6ESg/90J9NQvVsVKIMPJh9ur4wxhIeRjepeCubYp AIAmiFDBh1tg6lkVeiI2ZK5VW67AOY0fE6mKlr4eB/fcpSukRgEz39a8zD2rErwYtGVmkV Mvw1DL0w//OaCI+8bOdf+wt8s9Nhqnq/nCOktbRv2YCescjQz5Mm2hO4QuMsYUqyGj6ACq ZbewzhDNplGhjGHdKvIwPh455R2e7+d3sJc20c29rodRotukW4UAu3FKyvws8w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WZgd86frdz10XP; Thu, 1 Aug 2024 20:32:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 471KWiUX037319; Thu, 1 Aug 2024 20:32:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 471KWiNB037316; Thu, 1 Aug 2024 20:32:44 GMT (envelope-from git) Date: Thu, 1 Aug 2024 20:32:44 GMT Message-Id: <202408012032.471KWiNB037316@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 7f328eb439a3 - stable/13 - tcp hpts: initialize variable List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 7f328eb439a32176b4e6d00c0d4d3fdff53a06ee Auto-Submitted: auto-generated The branch stable/13 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=7f328eb439a32176b4e6d00c0d4d3fdff53a06ee commit 7f328eb439a32176b4e6d00c0d4d3fdff53a06ee Author: Michael Tuexen AuthorDate: 2024-04-05 15:30:31 +0000 Commit: Michael Tuexen CommitDate: 2024-08-01 20:32:02 +0000 tcp hpts: initialize variable Ensure that tv.tv_sec is zero in all code paths. Reported by: Coverity Scan CID: 1527724 Reviewed by: rscheff Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D44584 (cherry picked from commit aaaa01c0c858fd703194c6cbd515dd514574381f) --- sys/netinet/tcp_hpts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_hpts.c b/sys/netinet/tcp_hpts.c index 4c177367a7ea..ee4e68572c47 100644 --- a/sys/netinet/tcp_hpts.c +++ b/sys/netinet/tcp_hpts.c @@ -1995,6 +1995,7 @@ tcp_hpts_thread(void *ctx) * enough activity in the system that we don't need to * run as often (if we were not directly woken). */ + tv.tv_sec = 0; if (hpts->p_direct_wake == 0) { counter_u64_add(hpts_back_tosleep, 1); if (hpts->p_on_queue_cnt >= conn_cnt_thresh) { @@ -2019,7 +2020,6 @@ tcp_hpts_thread(void *ctx) * Directly woken most likely to reset the * callout time. */ - tv.tv_sec = 0; tv.tv_usec = hpts->p_mysleep.tv_usec; } goto back_to_sleep;