From nobody Sun Sep 24 21:46:52 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rv02h42zMz4tWvf; Sun, 24 Sep 2023 21:46:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rv02h2qYdz4ZGY; Sun, 24 Sep 2023 21:46:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695592012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UVPZsZctgfe5jgXCj8jw24a+VPajrmNsb6GShSGar8c=; b=kAdgNFzZQ/oouZ5G/Oc2K9M9/DxS45Bi3oJlxxtVXqNVEeCY+KF6rMj8YizptmtW3WNiwA 0Gpt6zJLjLNFj543723wwkWr0/L6l3VSSINNgMYA1cw+ETuQYU2CnAfQNABk+RdbeOJNaw /NdK8jrjnZbzb9CS5E6SSlzkzulTQ6Z0zim5HaUEqM8NwaBF6ySq2kBnOus0ffiTW5I8xY f0AcTqOJw0soE/k5OMX6LHMQiThKxfgfud+MzXB4Z476B5LIt6MhXJsvdXUcut0qrYVs9Z uuYcrROOiRXseXn51M8Kai77OQrbJY5q+RmrqPdIk9p05C6HhpeAxilaNBSc6Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695592012; a=rsa-sha256; cv=none; b=s6makEfx1KNA0XziwwD9PFx6WM9UnQ6rKOt/fVho31fmxc6GLw+BGwoXcEMdeV1Sq7HQRH IJAejNvu6CiZaatjxDK+xSJ+kiqVEtHqgLe1HqD6+3Fr/hgKA8WURDCpjxjh9JGLZ10tgL fuPBUNW0jCgevp6JF/gpUtsLLhelaCLWUHruetcnVeiHsXncqGnGN5dKhuaxonuQ1rh6E0 h9a2Zc2x8pH2Vo7kofDotsqw5E7N2SGHGAYq/pBTmsfb7sMsXw90M5u+cUyptZa0pM5SPz qTAOKODbsr4idvu0fSeqKKGazLT4uCpi+wBa7n3V7BqcxsPMLfXQwpQQw7x2iQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695592012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UVPZsZctgfe5jgXCj8jw24a+VPajrmNsb6GShSGar8c=; b=dRpY7OqdeLe/WaWiv4k8ozfgjEyQ41UfSrpi+UAMGLRkw5MgYYzyq8a3/rOPp4DssHryoE 3EjKqbr8deFhJsaL3og9KQyzN/7Ge3BaIG9PSX3RMJBAvuoXH7Jo7rHDlOAo/R1vt+0LNo k233bPA6JtTbt/9NhPeQg368mgaGS7dLdgJnGXGzYIVvH8q5tnCpIiPTcuVdWa83euS/c+ EFBSpw1Tkts2eIkKH/fbDSQD4tctWXd0MFHyWjAaayoDBuzStkmzcFriekWFTNlDBrf4w2 /SY1Alsxnc+OiLqhnOsj+BszV4SJJy5UFwonAN533DTv5ZEOGUIYX4y/NfN4kg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rv02h1xB5z13Vf; Sun, 24 Sep 2023 21:46:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38OLkqMH030569; Sun, 24 Sep 2023 21:46:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38OLkqQD030566; Sun, 24 Sep 2023 21:46:52 GMT (envelope-from git) Date: Sun, 24 Sep 2023 21:46:52 GMT Message-Id: <202309242146.38OLkqQD030566@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: 6d5db9c5239b - releng/14.0 - vfs: fix stale comment about freevnodes management List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: 6d5db9c5239b3ed27fec9d52420443ab800353ea Auto-Submitted: auto-generated The branch releng/14.0 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=6d5db9c5239b3ed27fec9d52420443ab800353ea commit 6d5db9c5239b3ed27fec9d52420443ab800353ea Author: Mateusz Guzik AuthorDate: 2023-09-14 17:28:32 +0000 Commit: Mateusz Guzik CommitDate: 2023-09-24 21:45:46 +0000 vfs: fix stale comment about freevnodes management Approved by: re (gjb) (cherry picked from commit 9dc0c983b0931f359c2ff10d47ad835ef74e929a) (cherry picked from commit 210dd7aa1f48848707b09a172a957f0f4b7aacab) --- sys/kern/vfs_subr.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 4c9cb6200f10..ed478d33aed0 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -1444,12 +1444,12 @@ static struct proc *vnlruproc; static int vnlruproc_sig; /* - * The main freevnodes counter is only updated when threads requeue their vnode - * batches. CPUs are conditionally walked to compute a more accurate total. + * The main freevnodes counter is only updated when a counter local to CPU + * diverges from 0 by more than VNLRU_FREEVNODES_SLOP. CPUs are conditionally + * walked to compute a more accurate total. * - * Limit how much of a slop are we willing to tolerate. Note: the actual value - * at any given moment can still exceed slop, but it should not be by significant - * margin in practice. + * Note: the actual value at any given moment can still exceed slop, but it + * should not be by significant margin in practice. */ #define VNLRU_FREEVNODES_SLOP 126