From nobody Thu Mar 16 17:45:35 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pcvmv6KtCz3yNZP; Thu, 16 Mar 2023 17:45:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pcvmv5ckwz3wBN; Thu, 16 Mar 2023 17:45:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678988735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=clYQFCPMIJe32NCgI43hupWFY62LIkp2cmgYKqDlWy0=; b=ROPEiii2eMyNLXhRH78OF/BwpSx55NIr4vq3J4D4dRq3GCYwDT7ivNSBYMekv1i+vC5feI 1gpmzTIFDTyRsJydt4BHK5BmUriBT/9mgMNaBCAV8lsRo1MYrnEQiH2NGeXwPdY3VMuruN sK5W9YkHt0OH6OEDVIpIndKZAE9DhQsKxDaR8aBUyJx0b6FdGzG5HJkJNfTx6PsM1ZbwjH JRS5T76LJBl2/UD9iCHcSsQ5REzQZRVtnZvQdqu9fiRUAWujEjG/wfqN3nZJb+VugZDhSO 0rs3jwfJN7PhLAXOJhGKK8sGc5Er06hez37l+BN03mIYe9JVQp9Z5npy2QeuhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678988735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=clYQFCPMIJe32NCgI43hupWFY62LIkp2cmgYKqDlWy0=; b=x9E6VP+bC1xs7ryZcuZj0luvQdmMXKKYJUy8XrWY5pSbF2pq2aTiMEnmDghKD1rbB5qmQz P4+oWLoywEggE0/OnjXsrdsGwLV08HfC0yAWXCwIfwWC4t54ghw3ZKG+4HeLHeU76PcjXU 6llc24/pa9LJhF8iDXNTW2dqeaiTRBCpHlOjlbZIiqWpn9x9ve2u4x4y3PtZjZNwnQNQcp eWU3YS2XXBGH8S4KqUEQuz/Mf1JraPD8UlwwiMg9kDyZSOHSVZVtgJYC7zgXYFERf/aO6W 3pKcgvjkwPxo+MdNT6+JgrvDzoDFjPmRjs6G+tvlNA90Rl11++F9vD0IgoN07Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678988735; a=rsa-sha256; cv=none; b=jwGpp5qLL+TVlfpOi7kgpOVg5mVLCB+QEJoztQwgb7Pxvo/BkBGRao3uSF95nW7VAWqSKV J8/PFoQt32Mle4XiPNcj5AbBGhw59s7kvWiGSq72Fkm7TcKhtZ7uyn44s6+KB6K+fYH4pP N8GVnJSzBCyeePN07sEwxrR6hBTGoWk2S2oE+zOepiESXrK/5kA9YsSWhtmNyR8Zap+I0a kbjjNtdt+q0X+PmE6YApY7zJ7A8KGwRkXuFRs+VjpW2bVSF4Dggx621WLJNpaRPoQ4qscu 8UKZnoDeP/2k1z8PfXbTQM4Wn8pswSfGvVRdMqRtxMYF/A8JoyWTdHoo/ap5eg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Pcvmv4gtFzsRc; Thu, 16 Mar 2023 17:45:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 32GHjZg4020610; Thu, 16 Mar 2023 17:45:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 32GHjZAV020609; Thu, 16 Mar 2023 17:45:35 GMT (envelope-from git) Date: Thu, 16 Mar 2023 17:45:35 GMT Message-Id: <202303161745.32GHjZAV020609@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 08ffa93d9f0e - releng/13.2 - heimdal: Fix CVE-2022-4152, signature validation error List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/releng/13.2 X-Git-Reftype: branch X-Git-Commit: 08ffa93d9f0e5c03b15e6f3326d5a0056bfc4a52 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch releng/13.2 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=08ffa93d9f0e5c03b15e6f3326d5a0056bfc4a52 commit 08ffa93d9f0e5c03b15e6f3326d5a0056bfc4a52 Author: Cy Schubert AuthorDate: 2023-03-10 01:03:52 +0000 Commit: Ed Maste CommitDate: 2023-03-16 17:44:41 +0000 heimdal: Fix CVE-2022-4152, signature validation error When CVE-2022-3437 was fixed by changing memcmp to be a constant time and the workaround for th e compiler was to add "!=0". However the logic implmented was inverted resulting in CVE-2022-4152. Reported by: Timothy E Zingelman Security: CVE-2022-4152 Security: https://www.cve.org/CVERecord?id=CVE-2022-45142 Security: https://nvd.nist.gov/vuln/detail/CVE-2022-45142 Security: https://security-tracker.debian.org/tracker/CVE-2022-45142 Security: https://bugs.gentoo.org/show_bug.cgi?id=CVE-2022-45142 Security: https://bugzilla.samba.org/show_bug.cgi?id=15296 Security: https://www.openwall.com/lists/oss-security/2023/02/08/1 Approved by: re (cperciva) (cherry picked from commit 5abaf0866445a61c11665fffc148ecd13a7bb9ac) (cherry picked from commit 59c26d1a95a00418892e08341e3eae074c238680) --- crypto/heimdal/lib/gssapi/krb5/arcfour.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/heimdal/lib/gssapi/krb5/arcfour.c b/crypto/heimdal/lib/gssapi/krb5/arcfour.c index 3b8d452877dd..7d1143c95d83 100644 --- a/crypto/heimdal/lib/gssapi/krb5/arcfour.c +++ b/crypto/heimdal/lib/gssapi/krb5/arcfour.c @@ -307,7 +307,7 @@ _gssapi_verify_mic_arcfour(OM_uint32 * minor_status, return GSS_S_FAILURE; } - cmp = (ct_memcmp(cksum_data, p + 8, 8) == 0); + cmp = (ct_memcmp(cksum_data, p + 8, 8) != 0); if (cmp) { *minor_status = 0; return GSS_S_BAD_MIC; @@ -695,7 +695,7 @@ OM_uint32 _gssapi_unwrap_arcfour(OM_uint32 *minor_status, return GSS_S_FAILURE; } - cmp = (ct_memcmp(cksum_data, p0 + 16, 8) == 0); /* SGN_CKSUM */ + cmp = (ct_memcmp(cksum_data, p0 + 16, 8) != 0); /* SGN_CKSUM */ if (cmp) { _gsskrb5_release_buffer(minor_status, output_message_buffer); *minor_status = 0;