From nobody Wed Jan 18 00:32:11 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NxRXr1cMSz2sX7d; Wed, 18 Jan 2023 00:32:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NxRXr1641z4Kw5; Wed, 18 Jan 2023 00:32:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674001932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7K9vD+zi8o8EmIgtKPeTrqIlHvmWJQZDf0T0JJnbfAM=; b=AZ5BFMkr7uWb99BueGa7sp8Bc/v+4DTzQsKH3L3IZCYDU573JRjcWnqJF9aO+87Y+bT6Kn tFKKGmX9RzJBbfiYYFtITWLta2+2RKwmFUfVQV3VCxX7DmXsmnDbVMsXrP+9g8HBKZ1Ja3 mlO/NVHoNGD5PEAdsW0svATh5z9U5Ps97m3yWTW8tXIPrGO3v/Tjw2LWZc7/G1oKK1d0EZ Qzup/Zr86GPYrsCnabnXrGItxZeCGcZ4PRg9ke2kIQhuqTHWX/FkngOG0RRdjAVfZCUMUw GKzHJYtgX0kwZse0G4+EGyP5jZbTPS1P8TctuQ3Q9UScOtyYexs/PuPNrLnhoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674001932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7K9vD+zi8o8EmIgtKPeTrqIlHvmWJQZDf0T0JJnbfAM=; b=J3oawkkZ8uR+9nIxOwAMhtJypfb0CYpWVpx2vKIeWxZEUos4bzHllt9Eb8rXDoJLhSeYBb doUxfBzIQqeI/T8aBhxgKxAUnI/QZZVJdkh6mz/FGA3eQmv/dcuYmCfJwE+Zf7m9X4wHM/ 0khOngVnJWPytTVeg+IjKmKhgupxqhCm9tpZdYazbboI5162h9iWYWfm+d/YA88rrdQWZT MQq1MsULz4RDXGpH9l6KLFhMNv2J6zKU6ziBKYyNWk9T2S7qXxdv8IaI1+0zaQVAiBR6hs VyTHfVaQxnt487gR1mZuiHUgWyKlca2NmNKJLDAA6bGlJ2I6OqKUBbzu1CE7Fg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674001932; a=rsa-sha256; cv=none; b=GVS4IRZ/hbQY/XQmuo8HSXyXO5wyCBY8OFIhSkyR0eHj8gl6IqsKQuV+/Rghk+E9QgePHV HilITFZr65AMjagMfi7O7fjTXPQDQJrFTiLyaNFwh4JigyIqwAoq7KE5Wiu5e+AXoTZtxu lsN5dGcOCkh40iuwjcXp++spCTHZs1d25C0UYOIN5cJALsPU9jABAWFoj0+pR21+rGROG6 r++Rd3w9JL4qolM6qPXR5rxoTNsFjN2bhOz4toc6EejX6K28HA8oTaILlW04+HK4enoDJy HhVmjQLn9DauwJcFwCFRe/m7ibn1TzW6SZeH8zAZ+bXoaDOyo1Gx16zMoo6Wjw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NxRXr035Rzrs7; Wed, 18 Jan 2023 00:32:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30I0WBA8080002; Wed, 18 Jan 2023 00:32:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30I0WBae080001; Wed, 18 Jan 2023 00:32:11 GMT (envelope-from git) Date: Wed, 18 Jan 2023 00:32:11 GMT Message-Id: <202301180032.30I0WBae080001@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kirk McKusick Subject: git: 3f908eed27b4 - stable/13 - Enable taking snapshots on UFS/FFS filesystems using journaled soft updates. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mckusick X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 3f908eed27b47ae40947e3fec2b262acdb5efcd5 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by mckusick: URL: https://cgit.FreeBSD.org/src/commit/?id=3f908eed27b47ae40947e3fec2b262acdb5efcd5 commit 3f908eed27b47ae40947e3fec2b262acdb5efcd5 Author: Kirk McKusick AuthorDate: 2022-11-13 06:56:03 +0000 Commit: Kirk McKusick CommitDate: 2023-01-18 00:30:46 +0000 Enable taking snapshots on UFS/FFS filesystems using journaled soft updates. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D36491 (cherry picked from commit 78f41298760509f5c2b5865b2158c801d4023363) --- sbin/newfs/newfs.8 | 4 +--- sbin/tunefs/tunefs.8 | 4 +--- sys/ufs/ffs/ffs_snapshot.c | 9 --------- 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/sbin/newfs/newfs.8 b/sbin/newfs/newfs.8 index 43896fe0bdb4..803b3221503d 100644 --- a/sbin/newfs/newfs.8 +++ b/sbin/newfs/newfs.8 @@ -205,9 +205,7 @@ is running. Running a full fsck on a UFS filesystem is the equivalent of running a scrub on a ZFS filesystem. .Pp -Presently it is not possible to take a snapshot on a UFS filesystem -running with journaled soft updates. -Thus it is not possible to reliably dump mounted filesystems or +Presently it is not possible to run background fsck on filesystems enabled for journaling. .It Fl k Ar held-for-metadata-blocks Set the amount of space to be held for metadata blocks in each cylinder group. diff --git a/sbin/tunefs/tunefs.8 b/sbin/tunefs/tunefs.8 index b9a581df6784..0264c3e5f772 100644 --- a/sbin/tunefs/tunefs.8 +++ b/sbin/tunefs/tunefs.8 @@ -131,9 +131,7 @@ is running. Running a full fsck on a UFS filesystem is the equivalent of running a scrub on a ZFS filesystem. .Pp -Presently it is not possible to take a snapshot on a UFS filesystem -running with journaled soft updates. -Thus it is not possible to reliably dump mounted filesystems or +Presently it is not possible to run background fsck on filesystems enabled for journaling. .It Fl J Cm enable | disable Turn on/off gjournal flag. diff --git a/sys/ufs/ffs/ffs_snapshot.c b/sys/ufs/ffs/ffs_snapshot.c index 89301576f48a..709038db071f 100644 --- a/sys/ufs/ffs/ffs_snapshot.c +++ b/sys/ufs/ffs/ffs_snapshot.c @@ -226,15 +226,6 @@ ffs_snapshot(struct mount *mp, char *snapfile) ump = VFSTOUFS(mp); fs = ump->um_fs; sn = NULL; - /* - * At the moment, journaled soft updates cannot support - * taking snapshots. - */ - if (MOUNTEDSUJ(mp)) { - vfs_mount_error(mp, "%s: Snapshots are not yet supported when " - "running with journaled soft updates", fs->fs_fsmnt); - return (EOPNOTSUPP); - } MNT_ILOCK(mp); flag = mp->mnt_flag; MNT_IUNLOCK(mp);